Link to home
Start Free TrialLog in
Avatar of skn73
skn73

asked on

Request Validations

getTest1( String tNo, String tn, String state) //all three required as input

getTest2(String tn, String State) // both data values required
for both of these input needs to be validated to see if it is null and is in the right format ..

I have this fn to test this
public void validateReq(String qualTrackNo, String tn, String state) throws ServicesApplicationException
{
      String fctStr = "ServiceRequestBean::checkReq()";
      
      PatternMatcher re = new Perl5Matcher();

      if (!reInit)
            setupRePatterns();
      
      try
      {
         // EDIT THE TELEPHONE NUMBER
         if ( (tn == null) || (!re.matches(tn, reTn)) )
            throw exception;...                                                                        
         // EDIT THE QUALIFICATION TRACKING NUMBER
         if ( TrackNo == null ||
           (!re.matches(TrackNo, reQualTrackNum)) )
            throw exception...                                                                              
            // EDIT THE STATE
       if ( state == null ||       (!re.matches(state, reState)) )
            throw exception...                                                
      
}
private synchronized void setupRePatterns() throws ServicesApplicationException
{
   try
   {
         TraceLog.write(TraceLog.DEBUG, "Initializing regular patterns...");
      
         if (reInit)
            return;
         reTn = new Perl5Compiler().compile(props.getValue(ServicesConstants.REGEXP_TN_10DIGIT), Perl5Compiler.READ_ONLY_MASK);
         reQualTrackNum = new Perl5Compiler().compile(props.getValue(ServicesConstants.REGEXP_QUAL_TRACK_NO), Perl5Compiler.READ_ONLY_MASK);
         reState = new Perl5Compiler().compile(props.getValue(ServicesConstants.REGEXP_STATE_2CHAR), Perl5Compiler.READ_ONLY_MASK);

         reInit = true;
         return;
   }
        
   catch(Throwable t)
   {
         ServicesError.throwProcessingException(t, "ServiceRequestBean::setupRePatterns()", props);
   }

   return;
}

How do I retain the same fns and test for both getTest1 and getTest2? other than polymorphism?
Avatar of Hammadian2
Hammadian2

getTest1( String tn, String state, String tNo = "xxx")

where "xxx" is a valid value for tNo
these way it can be used with 2 or 3 parameters
Avatar of skn73

ASKER

getTest1(tno, Tn, state) & getTest2(tn, state) needs to call validateReq() to validate the input
I dont want to change getTest1 or getTest2.

as it is written currently ..
if getTest2() calls validateReq("",tn,state) because there is no tracknum ...
it will error out saying tracknum is null or is in iinvalid format..

How can I use validateReq fn to do validations for both getTest1 and getTest2
ASKER CERTIFIED SOLUTION
Avatar of zcayo
zcayo

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Avatar of skn73

ASKER

Thanks .. this is exactly what I did ...