# How do I group a list of numbers into a condensed form...

Hi,

I am trying to write a function to convert the following string...
1, 2, 3, 4, 8, 9, 14, 16, 17 ,18
into...
1-4, 8-9, 14, 16-18

Any help would be appreciated..

James
LVL 4
Senior Principle Software EngineerAsked:
###### Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Commented:
Well, its not the neatest solution but I think it works OK :)

Public Sub test()

Dim sInput      As String
Dim sOutput     As String
Dim sNums()     As String
Dim iNum        As Integer
Dim bInRange    As Boolean

sInput = "1, 2, 3, 4, 8, 9, 14, 16, 17 ,18 "

sNums = Split(Replace(sInput, " ", ""), ",")
'sOutput = sNums(LBound(sNums))

For iNum = LBound(sNums) To UBound(sNums) - 1

If Val(sNums(iNum + 1)) = Val(sNums(iNum)) + 1 Then

If Not bInRange Then
If Right(sOutput, 2) = ", " Or sOutput = "" Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If
End If

bInRange = True

ElseIf bInRange Then

sOutput = sOutput & " - " & sNums(iNum) & ", "
bInRange = False

Else

If Right(sOutput, 2) = ", " Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If

End If

Next

If bInRange Then
sOutput = sOutput & " - " & sNums(UBound(sNums))
Else
If Right(sOutput, 2) = ", " Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If
End If

Debug.Print sOutput

End Sub
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Senior Principle Software EngineerAuthor Commented:
Looks good to me...

Doesn't need to be optimised, just work well!!!

Thanks for the help,

James
0
Commented:
The code above did a comma at the beginning if the first number wasn't a "range" so ....

Public Sub test()

Dim sInput      As String
Dim sOutput     As String
Dim sNums()     As String
Dim iNum        As Integer
Dim bInRange    As Boolean

sInput = "1, 3, 4, 8, 9, 14, 15, 16, 17 ,18 ,20"

sNums = Split(Replace(sInput, " ", ""), ",")
'sOutput = sNums(LBound(sNums))

For iNum = LBound(sNums) To UBound(sNums) - 1

If Val(sNums(iNum + 1)) = Val(sNums(iNum)) + 1 Then

If Not bInRange Then
If Right(sOutput, 2) = ", " Or sOutput = "" Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If
End If

bInRange = True

ElseIf bInRange Then

sOutput = sOutput & " - " & sNums(iNum) & ", "
bInRange = False

Else

If Right(sOutput, 2) = ", " Or sOutput = "" Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If

End If

Next

If bInRange Then
sOutput = sOutput & " - " & sNums(UBound(sNums))
Else
If Right(sOutput, 2) = ", " Then
sOutput = sOutput & sNums(iNum)
Else
sOutput = sOutput & ", " & sNums(iNum)
End If
End If

Debug.Print sOutput

End Sub

This one fixes that.
0
###### It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Visual Basic Classic

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.