Binary Search

#include <stdio.h>
#include <stdlib.h>

/* Small program to explore using binary trees.
   The program takes an array filled with random numbers
   and inserts the numbers into a binary tree.
   The program then prints the contents of the tree in
   key order. It should print -
   0 1 2 3 4 5 6 7 8 9
   The program then free's up the tree.

   I can't seem to find the error of this program..
*/

struct treeRecord
{
   int key;
   struct treeRecord *left, *right;
};

typedef struct treeRecord treeNode;

void insertArrayInTree(treeNode **root, int array[], int size);
void insertElementInTree(treeNode **root, int number);
void printTree(treeNode *start);
void freeTree(treeNode **start);
treeNode* newNode(int number);

int main()
{
   int array[] = { 6, 3, 8, 1, 5, 2, 9, 7, 4, 0 };
   treeNode *root = NULL;

   insertArrayInTree(&root, array,10);
   printTree(root);
   printf("\n");
   freeTree(&root);

   return 0;
}


void insertArrayInTree(treeNode **root, int array[], int size)
{
   /* insert elements of array into correct position in binary tree */

   int i;

   for (i=0; i<size; i++)
   {
      insertElementInTree(root, array[i]);
   }
}

void insertElementInTree(treeNode **root, int number)
{
   treeNode *temp = *root;

if (*temp != NULL)
{
      if (number < (*root)->key)
         insertElementInTree(&(temp->left), number);
      else
         insertElementInTree(&(temp->right), number);
}
else
{
   *root = newNode(number);
}
}

void printTree(treeNode *root)
{
   /* print the contents of the tree in order */

   while (root != NULL)
   {
      printf(" %d", root->key);
      root = root->right;
   }
}

void freeTree(treeNode **root)
{
   /* free up memory allocated to binary tree */
   treeNode *temp = *root;

   if (temp != NULL)
   {
      if (temp->left != NULL) freeTree(&temp->left);
      if (temp->right != NULL) freeTree(&temp->right);
      free(temp);
      *root = NULL;
   }
}
treeNode* newNode(int number)
{
   /* dynamicaly allocate memory for a treeNode
      make sure it is initialised correctly
   */

   treeNode *temp;

   temp = (treeNode *) malloc(sizeof(treeNode));
   if (temp == NULL)
   {
      printf("WARNING - Memory allocation error\n");
      exit(EXIT_FAILURE);
   }
   temp->key = number;
   temp->left = NULL;

   return temp;
}
blaze_wkAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

van_dyCommented:
thre are not many errors  however make the following changes

void insertElementInTree(treeNode **root, int number)
{
   treeNode *temp = *root;

if (temp != NULL)            //not *root
{
      if (number < (*root)->key)
         insertElementInTree(&(temp->left), number);
      ..// rest of you insertElementTree()



and use this function for printing tree
void printTree(treeNode *root)
{
   /* print the contents of the tree in order */

      if(!root)
            return;
      printTree(root->left);
      printf(" %d", root->key);
      printTree(root->right);

}


hope this helps,
van_dy


0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
van_dyCommented:
in case i was not clear, in my last post, in  function void insertElementInTree(treeNode **root, int number)

>> if (temp != NULL)            //not *root
should be
     if(temp != NULL)            //not *temp
0
ksanand_beCommented:
Hi,

Is that (*root)->key or root->key? Does that make any difference?
0
van_dyCommented:
>>Is that (*root)->key or root->key? Does that make any difference?
It should be (*root)->key in insertElementInTree(treeNode **root, int number). (*root) will be a pointer to treenode,
so u access its key memeber by (*root)->key
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Software

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.