Make a for-loop from 22 document.form.value statements

Posted on 2004-11-23
Medium Priority
Last Modified: 2007-12-19
I am close -- but no cigar.   I have a series of 22 forms that save input values (scores) and then pass to one "super" form that then sends to a response page.  How do I write these statements in a more compact for-loop?   Writing in Javascript document.write statements is cumbersome, but sometimes necesary since this will involve making these into either an array or variables .

function final_results() {
         // assigns values to the final input value <--- from each of 22 forms values
        document.results_form.finalTotal1.value = document.form1.total.value;
      document.results_form.finalTotal2.value = document.form2.total.value;
      document.results_form.finalTotal3.value = document.form3.total.value;
      document.results_form.finalTotal4.value = document.form4.total.value;
      document.results_form.finalTotal5.value = document.form5.total.value;
      document.results_form.finalTotal6.value = document.form6.total.value;
      document.results_form.finalTotal7.value = document.form7.total.value;
      document.results_form.finalTotal8.value = document.form8.total.value;
      document.results_form.finalTotal9.value = document.form9.total.value;
      document.results_form.finalTotal10.value = document.form10.total.value;
      document.results_form.finalTotal11.value = document.form11.total.value;
      document.results_form.finalTotal12.value = document.form12.total.value;
      document.results_form.finalTotal13.value = document.form13.total.value;
      document.results_form.finalTotal14.value = document.form14.total.value;
      document.results_form.finalTotal15.value = document.form15.total.value;
      document.results_form.finalTotal16.value = document.form16.total.value;
      document.results_form.finalTotal17.value = document.form17.total.value;
      document.results_form.finalTotal18.value = document.form18.total.value;
      document.results_form.finalTotal19.value = document.form19.total.value;
      document.results_form.finalTotal20.value = document.form20.total.value;
      document.results_form.finalTotal21.value = document.form21.total.value;
      document.results_form.finalTotal22.value = document.form22.total.value;
      return document.results_form.finalTotal1.value;    
      return document.results_form.finalTotal2.value;    
      return document.results_form.finalTotal3.value;    
      return document.results_form.finalTotal4.value;    
      return document.results_form.finalTotal5.value;    
      return document.results_form.finalTotal6.value;    
        return document.results_form.finalTotal7.value;    
      return document.results_form.finalTotal8.value;    
      return document.results_form.finalTotal9.value;    
      return document.results_form.finalTotal10.value;    
        return document.results_form.finalTotal11.value;    
      return document.results_form.finalTotal12.value;    
      return document.results_form.finalTotal13.value;    
      return document.results_form.finalTotal14.value;    
      return document.results_form.finalTotal15.value;    
      return document.results_form.finalTotal16.value;    
      return document.results_form.finalTotal17.value;    
      return document.results_form.finalTotal18.value;    
      return document.results_form.finalTotal19.value;    
      return document.results_form.finalTotal20.value;  
      return document.results_form.finalTotal21.value;    
      return document.results_form.finalTotal22.value;    
      document.results_form.totalscore.value = ????
      return document.results_form.totalscore.value;

The final document.results_form.totalscore.value is a summation value that could be an increment statement or a final addition of all of the above.

Tight, economical code always greatly appreciated.
Question by:bodywise
  • 3
  • 3
  • 2
  • +1
LVL 25

Expert Comment

ID: 12660455
I hope I did without errors :)

in every form add keyword "this" on onsubmit attribute

like this:
<form onsubmit="return final_results(this)">

and the function:

function final_results(obj)
      // assigns values from the 22 forms into an input of the final super form
            var total=0;
            for(var i=1;i<23;i++)
                  eval("document.results_form.finalTotal"+i+".value = obj.total.value;")
                  return false;
               document.results_form.totalscore.value = total;
            return true;


Accepted Solution

_aaron_ earned 500 total points
ID: 12660570

         Not sure of the process, but I think that you are trying to call this function only once ( rather than at the end of each form [ maybe? ] )... Anyway, this will only have to be called once:

function final_results() {
   var tot = 0
   for ( var i = 0 ; i < 3 ; ++i )
      eval("document.forms['destForm'].finalTotal" + i ).value = document.forms['form'+i].total.value
      tot += parseFloat(document.forms['form'+i].total.value)

   document.forms['destForm'].FINAL.value = tot

<body onload=final_results()>
<form name="form0">
<input type=text name="total" value='2'></input>

<form name="form1">
<input type=text name="total" value='4'></input>

<form name="form2">
<input type=text name="total" value='6'></input>

<form name="destForm">
<input type=text name="finalTotal0">
<input type=text name="finalTotal1">
<input type=text name="finalTotal2">

<input type=text name="FINAL">
LVL 25

Expert Comment

ID: 12660580
a yeah, one bug I see :)


should be:

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!


Author Comment

ID: 12660881
Again ... thanks for such a speedy response.  I need to work through this and get back to both of you in a few hours (I am still at work)  ...  I  think this is right.  

The partial answer is, yes, this is supposed to be a one time call at the end of complete of the 22 forms.   So each of the 22 forms needs to call up an "upTotal"  function that totals the results.  The superform just inputs these total values all at once to post to the response page.


Expert Comment

ID: 12660901
The example given provides the total in the "FINAL" input box, there is no need call another 'upTotal' function; anyway, see how it goes ;-)
LVL 14

Expert Comment

ID: 12662840
Hi bodywise,

Here is the code you have, (basically), in compact form. I do not understand why you need to "return" all of those values, or where you are returning them to. If you can show me more of your code, I could maybe understand.

Here is the script:

function final_results(){
         num = i+1;
         var num = num.toString();
         getForm = document.forms['form'+num].total.value;
         document.results_form.elements['finalTotal'+num].value = getForm;
         grand_total += parseInt(getForm);
     document.results_form.totalscore.value = grand_total;

Are you calling the results from the "final_results()" function from inside another function, or why the "return" statements?

Anyway, hope that helps.


Author Comment

ID: 12663017
Gee.  Thanks to all of you.   This has been a very short and sweet interchange.  I went with the simplest and most effective solution from aaron, although I think the other suggestions from all of you would work as well.  Eadh teaches me just a slight variation.  obj.total.value is another very clever convention that I have not used.

Here is what I learned that I did not quite understand.

1. form can be named as forms['form'+i]    most clever and most compact

2. the part eval("document.forms['destForm'].finalTotal" + i ).value  is what I was looking for.  I could not figure out how to phrase this and the end  == finalTotal" + i ).value ==  was just not apparent to me.  It works!

3. the increment counter works just right -- I think -- although it is not the absolute critical value.  the 22 total scores are the important variables that are passed to the response page

4. the <body onload> statement is probably critical to setting up the "re-evaluation" process

5. I had to change the counter from 0 to 1 since my forms are named as form1, form2 etc and not form0, form1 ...  The 0 array system still confuses me greatly.   I seem to remember that Pascal allows you to change array counting from 0 to 1.  I don't think you have that option in JS so I just put dummmy text in the first array element.

hope to encounter you again with any remianing problems.bodywise

here is the rather hidden page that you may need to sign-in to view.


Expert Comment

ID: 12670206
Great, happy to see that u learnt so much... I am still constantly learning new and improved ways of coding in JScript - its a fairly amazing language ( well I think anyway )


Author Comment

ID: 12670719
Indeed.  I have programmed in TurboPascal, PHP, ASP, a tiny bit of Fortran, Basic, and here comes along Javascript.  Yes, it is a rather amazing scripting language.

Thank you to all of the above for succinct and relevant answers.

Happy Turkey Day.

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In Part 1 (http://www.experts-exchange.com/Programming/Languages/Scripting/JavaScript/A_7849-Hex-Maze.html) we covered the hexagonal maze basics -- how the cells are represented in a JavaScript array and how the maze is displayed.  In this part, we'…
International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
The viewer will learn the basics of jQuery, including how to invoke it on a web page. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery.: (CODE)
The viewer will learn the basics of jQuery including how to code hide show and toggles. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery…
Suggested Courses

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question