Link to home
Start Free TrialLog in
Avatar of skn73
skn73

asked on

can this be made static

public Vector getConvertedError( String errCode) throws PropertyApplicationException
      {
            Vector v1 = new Vector();
            if( errCode.compareTo(props.getValue(ServicesConstants.ACCOUNT_NON_TELCO_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_NON_TELCO_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_NON_TELCO_ERROR_MSG));
            }
            else if ( errCode.compareTo(props.getValue(ServicesConstants.ACCOUNT_INVALID_COS_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_INVALID_COS_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_INVALID_COS_ERROR_MSG));
            }      
            else if ( errCode.compareTo(props.getValue(ServicesConstants.ACCOUNT_SIWTN_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_SIWTN_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_SIWTN_ERROR_MSG));
            }
            else if ( errCode.compareTo(props.getValue(ServicesConstants.ACCOUNT_UNE1_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_UNE1_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_UNE1_ERROR_MSG));
            }
            else if( errCode.compareTo(props.getValue(ServicesConstants.ACCOUNT_UNN1_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_UNN1_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_UNN1_ERROR_MSG));
            }
            else if( errCode.compareTo(props.getValue(ServicesConstants.CSR_NO_DATA_FOUND)) == 0)
            {
                   v1.add(props.getValue(ServicesConstants.CSR_NO_DATA_FOUND));
                   v1.add(props.getValue(ServicesConstants.CSR_NO_DATA_FOUND));
            }
            else if (errCode.compareTo(props.getValue(ServicesConstants.IM_ACCOUNT_TO_LARGE_ERROR_CODE)) == 0)
            {
                  v1.add(props.getValue(ServicesConstants.IM_ACCOUNT_TO_LARGE_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.IM_ACCOUNT_TO_LARGE_ERROR_MSG));
            }
            else if (errCode.startsWith(props.getValue(ServicesConstants.IM_SYSTEM_UNAVAIL_ERROR_CODE)) )
            {
                  v1.add(props.getValue(ServicesConstants.IM_SYSTEM_UNAVAIL_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.IM_SYSTEM_UNAVAIL_ERROR_MSG));
            }
            else if (errCode.startsWith(props.getValue(ServicesConstants.IM_INVALID_INPUT_COMB_ERROR_CODE)))
            {
                  v1.add(props.getValue(ServicesConstants.IM_INVALID_INPUT_COMB_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.IM_INVALID_INPUT_COMB_ERROR_MSG));
            }
            else if (errCode.startsWith(props.getValue(ServicesConstants.IM_SYSTEM_TIMEOUT_ERROR_CODE)))
            {
                  v1.add(props.getValue(ServicesConstants.IM_SYSTEM_TIMEOUT_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.IM_SYSTEM_TIMEOUT_ERROR_MSG));
            }
            else if(errCode.startsWith(props.getValue(ServicesConstants.ACCOUNT_TIMEOUT_ERROR_CODE)))
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_TIMEOUT_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_TIMEOUT_ERROR_MSG));
            }
            else if( errCode.startsWith(props.getValue(ServicesConstants.IM_SCHEDULED_DOWNTIME_ERROR_CODE).trim()) )
            {
                  v1.add( props.getValue(ServicesConstants.IM_SCHEDULED_DOWNTIME_ERROR_CODE));
                  v1.add( props.getValue(ServicesConstants.IM_SCHEDULED_DOWNTIME_ERROR_MSG));
            }
            else
            {
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_INVALID_ERROR_CODE));
                  v1.add(props.getValue(ServicesConstants.ACCOUNT_INVALID_ERROR_MSG));      
            }
            return v1;
      }

I guess I am confused what method to make static ? it beats me when a method can be static ? Here the input errorId can be different , but the properties file can be constant
SOLUTION
Avatar of bobbit31
bobbit31
Flag of United States of America image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
public static String blah (String s) {
...
}
Avatar of Mike Tomlinson
(It has been a long time since I have done any Java)

When a method is static, everything it accesses must also be static, so your props variable must be declared static as well.

~IM
ASKER CERTIFIED SOLUTION
Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial