Bozzie u da man! I tried this and flopped: uidoc.fieldgettext("Req_Requestor") Can you explain for me how to tell the difference on these situations?

Yes, I'll explain : fieldgettext returns a String (and if you have multiple values, you get an invalid emailadres).  My syntax returns a variant, in this case an array of Strings (the individual mail addresses).  The rest of your code expects this array (see  the for-next loop).

cheers,

Tom

Bozzie ur da man! Thanks! If your ever in Orlando........Beers on Me! or ICe tea if your not a drinker!

Beer please (try West Vleteren, Orval or Westmalle :-) )

cheers,

Tom

I'll do that.....where are these bers from? I'm a Killians man myself!

real quick what if I want to grab 2 fields would it look like this?
Sendto = uidoc.document.req_Requestor + uidoc.document.Req_Notify

No, two fields is a bit trickier. You'll need to loop through them both (if they both are multivalue) and add them to an  array.  A simple solution is to first add them both to a new field (Req_NotifyAll), computed, and put in this formula :
@trim(@unique( REQ_Requestor:REQ_Notify))

Your script then must have a uidoc.refresh() in it, to force the computation of this formula.

 A very easy way of doing this, however, is to assume you are working with single value fields, then it looks like this :
Sendto = uidoc.document.req_Requestor(0) + uidoc.document.Req_Notify(0)

cheers,

Tom

I created a hidden field Req_NotifyAll and asigned the code to it but it isn't working, do you want me to open another question cause now I need to modify the original code to just send out a generic message without the input box, plus I'd like to have it run when the Admin hits the save and close button....maybe as an agent so that the admin changes the status to complete and clicks the save and close button and the users are notified........I'll gladly open another ticket if you can help me out with this today.....250 sound good?

Ok :-)

You could put the code you  have in the QuerySave event, so it's executed  as someone saves the document.

Change this
   Set uidoc = ws.CurrentDocument
     Set doc = uidoc.document

(and change all occurences of "uidoc" to "source")
To

Call source.refresh()
set doc = source.document

And the sendto line , to

Sendto = source.document.REQ_NotifyAll


cheers,

Tom

Tom, will this not then shoot out the emailseverytime somebody saves the document?

The query save should only work when the Status is completed........

When I look at the Req_NotifyAll field it has pickedup all the names but it's separating them with a ";" no quotes, and it does not mail could that be the cause? Also how do I prevent this t2 = Inputbox("Enter Any Pertinent Information for the Requestor", "") from happening?

You could put the code you  have in the QuerySave event, so it's executed  as someone saves the document.

Change this
   Set uidoc = ws.CurrentDocument
     Set doc = uidoc.document

Change it to what?

Set source = ws.currentDocument
Set doc = source.document
????

Yes, you should  add a check first then.

if source.document.Status(0) = "Completed" then
' send the mail
....
end if


Ah, and for the Req_NotifyAll field, make sure the property "Allow multiple values" is checked.  

If you don't want the inputbox,  just delete it (or put a single quote in front of it, to comment it out, like this:
'this would be comment

cheers,

Tom

Everything with an asterisk ***** I've changed, did I miss anything or screw anything up?

Sub Click(Source As Button)
     Stop
     Dim LF As String
     Dim ws As New notesuiworkspace
*****Dim Source As notesuidocument#####
     Dim doc As notesdocument
     Dim i As Integer
     Dim e1 As String
     
     Dim t1 As String
     Dim t2 As String
     
     Dim flag As Integer
     Dim SendTo As Variant
     Dim CopyTo As String
     Dim BlindCopyTo As String
     Dim WebSubject As String
     Dim body As String
     Dim wmail As String
     
*****Set source = ws.CurrentDocument
*****Set doc = source.document
     LF=Chr$(13)+Chr$(10)
*****e1 = "Requested:  "+source.fieldgettext("Req_VMName")#####
*****doc.inheritedsubject = Source.document.subject(0)

******if source.document.Status(0) = "Completed" then
******' send the mail
******....
******end if
     

     t1 = ""
     
     
***** 't2 = Inputbox("Enter Any Pertinent Information for the Requestor", "")
     
     If Ltrim$(t2) = "" Then
          Exit Sub
     End If
     
     
****Sendto = uidoc.document.req_NotifyAll
     If Isempty(Sendto) Then
     Exit Sub
     End If
     
     CopyTo = ""
     BlindCopyTo = ""
     WebSubject = "Your VM Ware request is Complete "+doc.inheritedsubject(0)
    *****body = "Here is a link to the Original Ticket:  " '+t2
     wmail = "Double Click this link to access the document -->"
     i = Lbound(sendto)
     For i = Lbound(sendto) To Ubound(sendto)
          flag% = SendMailMemo(sendto(i),CopyTo,BlindCopyTo,WebSubject,body,doc, wmail)#####
     Next
     If (flag%) Then
          Messagebox "The person or persons you selected have been notified"
     Else
          Messagebox "The mail notification failed to send properly.  "          
     End If
End Sub

I get errors where there are #### after the line.

yes, it should goin the querysave event, with the source parameter

help me out "with the source parameter" huh?

The Query Save event already has the source parameter :

Sub Querysave(Source As Notesuidocument, Continue As Variant)
 Stop
     Dim LF As String
      Dim doc As notesdocument
     Dim i As Integer
     Dim e1 As String
     
     Dim t1 As String
     Dim t2 As String
     
     Dim flag As Integer
     Dim SendTo As Variant
     Dim CopyTo As String
     Dim BlindCopyTo As String
     Dim WebSubject As String
     Dim body As String
     Dim wmail As String
     
Set doc = source.document

     LF=Chr$(13)+Chr$(10)
e1 = "Requested:  "+source.document.Req_VMName(0)
doc.inheritedsubject = Source.document.subject

if source.document.Status(0) = "Completed" and source.document.REQ_MailSent(0) <> "1"  then
' send the mail
     t1 = ""
      't2 = Inputbox("Enter Any Pertinent Information for the Requestor", "")
       '   If Ltrim$(t2) = "" Then
   '       Exit Sub
   '  End If
     
     
Sendto = uidoc.document.req_NotifyAll
     If Isempty(Sendto) Then
     Exit Sub
     End If
     
     CopyTo = ""
     BlindCopyTo = ""
     WebSubject = "Your VM Ware request is Complete "+doc.inheritedsubject(0)
  body = "Here is a link to the Original Ticket:  "
     wmail = "Double Click this link to access the document -->"
     i = Lbound(sendto)
     For i = Lbound(sendto) To Ubound(sendto)
          flag% = SendMailMemo(sendto(i),CopyTo,BlindCopyTo,WebSubject,body,doc, wmail)
     Next
     If (flag%) Then
          Messagebox "The person or persons you selected have been notified"
     Else
          Messagebox "The mail notification failed to send properly.  "          
     End If

source.document.REQ_MailSent = "1"

else
print "not sending mail, request not complete."

end if
End Sub

something is a little flaky, it is trying to send out the email even when the status is something other then completed and I am getting a variant does not contain object

yeah - change this line :

if source.document.Status(0) = "Completed" and source.document.REQ_MailSent(0) <> "1"  then

to

if source.document.Status(0) = "Completed" and not(source.document.hasItem("REQ_MailSent"))  then

cheers,

Tom

Hey Tom, let me open up another questions and shoot you some points for this! I think we are almost there, I'm not getting any errors, but no emails either.....BEERs on ME! Lake Mary Florida anytime !!!!

I suspect the SendMailMemo : in the Options sections,could you put in
Option declare

You'll get errors about variables and functions that are  not declared properly.

Also, run the code in the debugger (file/tools/debug lotusscript and then create a test document).  Step through the code, and see where it goes wrong.

cheers,

Tom

I tried running the debugger but once I click on the save and close button that's all that happens, it doesn't open the debugger at all.

Option Declare??? Is this on the Globals? or there is the options and there is a declarations....

Sorry dude, I am looking for a good course on Lotus script, if you know of any let me know.

I'm sorry I'm a dumb A$$ I put Option Declare in the Options section it found a uidoc error which I changed to source but still no emails and I really can't tell now if it's trying to send the emails even when the status is not completed.....

You'll be able to see what happens if  you step through the code with the debugger.  The status field is case-sensitiive, by the way, so if its value is "completed",  it won't send a mail

I am curious about the field Req_NotifyAll, I have it set to type names computed but when I look at the field the names are separated by a ; not a comma is this a factor?

No, this is not a factor.  This is quite correct, the ; is the default multivalue separator.  

well I ran it through the debugger and what I found is that it isn't running this code:
Function SendMailMemo(sendTo As String, _
cc As String, _
bcc As String, _
subject As String, _
body As String, _
linkTo As Variant, _
linkurl As String) As Integer
'      flag% = SendMailMemo("SendTo", "cc", "bcc", "Subject", "Body Text", NotesDocument)
      Stop
      'On Error Goto ErrorHandler
      On Error Resume Next
      
      Dim mailDb As New NotesDatabase("", "")
      Dim mailDoc As NotesDocument
      Dim rtItem As NotesRichTextItem
      Dim Doc As NotesDocument
      
      
      Call mailDb.OpenMail
      If (mailDb.IsOpen = False) Then Call mailDb.Open("", "")
      Set mailDoc = mailDb.CreateDocument
      Maildoc.Principal="""VM Ware Request"" <DO NOT RESPOND>"
      mailDoc.Form = "Memo"
      mailDoc.SendTo = Sendto
      mailDoc.CopyTo= cc
      mailDoc.BlindCopyTo = bcc
      mailDoc.Subject = subject
      Set rtItem = mailDoc.CreateRichTextItem("Body")
      Call rtItem.AppendText(body)
      If Not(linkTo Is Nothing) Then
            Call rtItem.AddNewLine(2)
            Call rtItem.AppendDocLink(linkurl, "Double-click to open document")
      End If
      If Not(linkurl ="") Then
            Call rtItem.AddNewLine(2)
            Call rtitem.AppendText(linkurl)
            
            Call rtitem.AppendDocLink(linkto, "FYI:")
      End If
      Call mailDoc.Send(False)
      SendMailMemo = True
      Exit Function
      
ErrorHandler:
      Print "Error " & Str$(Err) & ": " & Error$
      Resume TheEnd
      
TheEnd:
      SendMailMemo = False
End Function      

This was created when I pasted the code into the Query save event. The debugger only runs the code you posted here....

Should there be a call to this function on the query save???? Whenever I close the form only the first portion of the code runs it never makes it to this function......

You must have the function in the global section of the form, or in the Querysave scope too.
If your script doesn't reach the function  (the calling of the fucntion), something else is probalby wrong.  Check  with the debugger where he ends (is it the  if statement ?)

cheers,

Tom

I've run the debugger I get no errors and it goes through the entire code on the query save. When i pasted the code to the querysave it created an object called sendmailmemo, I figured that it would work just like the buttons but it seems to not make it that far. I uncommented the  't2 = Inputbox("Enter Any Pertinent Information for the Requestor", "")
       '   If Ltrim$(t2) = "" Then
   '       Exit Sub
   '  End If
just to see if it would prompt me but it doesn't make it that far. Whne I click on the save and close the form just seems to close.

I tried moving the Function to the globals declarations but I got all kinds of script errors, the first on the Flag% which I assume is calling the Function. So it needs the function under the form objects. I just can't see why the code is not executing. It works fine on a button.

how do I incorporate thecode into the query save?

HOLD everything guys!!!! It's working, SORT of..........here's the deal, I commented out these lines:

if source.document.Status(0) = "Completed" and not(source.document.hasItem("REQ_MailSent"))  then

source.document.REQ_MailSent = "1"

else
print "not sending mail, request not complete."

end if

and it worked...........small problem, now it wants to send the email everytime the document is closed, I just need it to send when the Req_Status is complete......could this be because the query save actually runs before the document is saved? Can I put something on the Save/Close button so that the form is saved then the querysave runs????

Yes, query save runs before the document is saved, you can  still cancel the document save.

But that's not the issue.  After sending the mail and saving the document the first time, the document should have received a new field REQ_MailSent.  You can check if this happens correctly, bylooking at the document properties.

Your Save/Close button only needs to contain this :

@command([filesave]);
@command([fileclosewindow])

cheers,

Tom

Tom,
If I don't comment the fields mentioned previously, the document just saves, it won't run through the entire querysave code. So I don't get my message:
  If (flag%) Then
          Messagebox "The person or persons you selected have been notified"
Without the code I get the message and the email goes out with a doclink. I checked all my previous test and cannot find under the document properties the Req_Mail field.......Which I assume is added after it is sent?!?!? But if it isn't sending then it won't add the field, also I am not getting any of the prompts.

I can send you a copy of the db if you'd like so you can look at it. It's not big at all.

I am getting a type mismatch when I create the request but the email still gets out, once I click on completed it works perfectly without any errors.......here's the code:
Sub Querysave(Source As Notesuidocument, Continue As Variant)
      Stop
      Dim LF As String
      Dim doc As notesdocument
      Dim i As Integer
      Dim e1 As String
      
      Dim t1 As String
      Dim t2 As String
      
      Dim flag As Integer
      Dim SendTo As Variant
      Dim CopyTo As String
      Dim BlindCopyTo As String
      Dim WebSubject As String
      Dim body As String
      Dim wmail As String
      
      
      Set doc = source.document
      
      LF=Chr$(13)+Chr$(10)
      e1 = "Requested:  "+source.document.Req_VMName(0)
      doc.inheritedsubject = Source.document.subject
      Call source.Refresh
      'If ( source.FieldGetText( "Req_Status" ) = "Complete" )  Then
      
      
      If source.document.Req_Status(0) = "Completed" And source.document.REQ_MailSent(0) <> "1"  Then
      'If source.document.Status(0) = "Completed" And Not(source.document.hasItem("REQ_MailSent"))  Then
' send the mail
            t1 = ""
            't2 = Inputbox("Enter Any Pertinent Information for the Requestor", "")
            'If Ltrim$(t2) = "" Then
                  'Exit Sub
            'End If
            
            
            Sendto = source.document.Req_NotifyAll
            If Isempty(Sendto) Then
                  Exit Sub
            'End If
                  source.document.REQ_MailSent = "1"
                  
            Else
            'Print "not sending mail, request not complete."
                  
            End If
      End If
      CopyTo = ""
      BlindCopyTo = ""
      WebSubject = "Your VM Ware request is Complete "+doc.inheritedsubject(0)
      body = "Here is a link to the Original Ticket:  "
      wmail = "Double Click this link to access the document -->"
      i = Lbound(sendto)
      For i = Lbound(sendto) To Ubound(sendto)
            flag% = SendMailMemo(sendto(i),CopyTo,BlindCopyTo,WebSubject,body,doc, wmail)
      Next
      If (flag%) Then
            Messagebox "The person or persons you selected have been notified"
      Else
            Messagebox "The mail notification failed to send properly.  "          
      End If
      
End Sub

OK here it is, this is where I am getting my errors:
i = Lbound(sendto)
For i = Lbound(sendto) To Ubound(sendto)

I tried commenting then out and I get a variant does not contain a container ERROR.

Try this, there where still some conceptual  errors in your code:

Sub Querysave(Source As Notesuidocument, Continue As Variant)
     Stop
     Dim LF As String
     Dim doc As notesdocument
     Dim i As Integer
     Dim e1 As String
     
     Dim t1 As String
     Dim t2 As String
     
     Dim flag As Integer
     Dim SendTo As Variant
     Dim CopyTo As String
     Dim BlindCopyTo As String
     Dim WebSubject As String
     Dim body As String
     Dim wmail As String
     
     
     Set doc = source.document
     
     LF=Chr$(13)+Chr$(10)
     e1 = "Requested:  "+source.document.Req_VMName(0)
     doc.inheritedsubject = Source.document.subject
     Call source.Refresh
     'If ( source.FieldGetText( "Req_Status" ) = "Complete" )  Then
         
     If source.document.Req_Status(0) = "Completed" And source.document.REQ_MailSent(0) <> "1"  Then
     'If source.document.Status(0) = "Completed" And Not(source.document.hasItem("REQ_MailSent"))  Then
' send the mail
          t1 = ""
          't2 = Inputbox("Enter Any Pertinent Information for the Requestor", "")
          'If Ltrim$(t2) = "" Then
               'Exit Sub
          'End If
         
         
          Sendto = source.document.Req_NotifyAll
          If Isempty(Sendto) Then
               Exit Sub
         End If
         source.document.REQ_MailSent = "1"
         
 CopyTo = ""
     BlindCopyTo = ""
     WebSubject = "Your VM Ware request is Complete "+doc.inheritedsubject(0)
     body = "Here is a link to the Original Ticket:  "
     wmail = "Double Click this link to access the document -->"
     i = Lbound(sendto)
     For i = Lbound(sendto) To Ubound(sendto)
          flag% = SendMailMemo(sendto(i),CopyTo,BlindCopyTo,WebSubject,body,doc, wmail)
     Next
     If (flag%) Then
          Messagebox "The person or persons you selected have been notified"
     Else
          Messagebox "The mail notification failed to send properly.  "          
     End If

      Else
          Print "not sending mail, request not complete."
               
         
     End If
   
     
End Sub

Tom, that worked great!!! Where was I screwing this up? Beers on Me! Let me post a new questions and give you some points on this.

get your points here!
https://www.experts-exchange.com/questions/21582056/Querysave-email-with-field-check-and-link-FOR-BOZZIE.html