Error: Collection was modified; enumeration operation may not execute.

Hi There,

I'm getting an error when I try to update multiple rows from shopping cart. When I have one row it works fine but when I have multiple rows it gives me the error "Collection was modified; enumeration operation may not execute. " after the first iteration of the loop.

Could someone help me out with the syntax please?

Sean

!--- code

 Sub ChangeQuantity(ByVal send As Object, ByVal E As EventArgs)
        Dim i As Int32 = 0
        Dim strCode As String = ""
        Dim intusercode As Int32 = 0
        ' For i = 0 To cart.Items.Count - 1
        For Each dataItem As RepeaterItem In cart.Items
            Dim ItemQuantity As TextBox = (CType(dataItem.FindControl("ItemQuantity"), TextBox))
            Dim txtcode As TextBox = (CType(dataItem.FindControl("txtcode"), TextBox))
            Dim txtitemnumber As Label = (CType(dataItem.FindControl("lblPitemnumber"), Label))
            Dim lblprice As Label = (CType(dataItem.FindControl("lblprice"), Label))
            If Not txtcode.Text = "" Then
                strCode = GetValidCode(txtcode)
                If strCode Is Nothing Then 'if the user does not have a valid code then call the function
                    Call UpdateCart(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
                Else 'if the user has a valid code then look it up
                    Session("THECODE") = strCode
                    intusercode = 1
                    Call GetDistributorPrice(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
                End If
            Else
                'if the code is nothing then call the function
                Call UpdateCart(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
            End If
            'Exit For
        Next
    End Sub


!--- repeater code

<asp:repeater id="cart" runat="server">
                        <HeaderTemplate>
                              <table border="1" cellpadding="3" style="background-color:#F6F6F6; border-collapse:collapse">
                                    <tr>
                                          <th>
                                                Number</th>
                                          <th>
                                                Title</th>
                                          <th>
                                                Price</th>
                                          <th>
                                                Quantity</th>
                                          <th>
                                                MTA / Reseller Code</th>
                                          <th>
                                                Amount</th>
                                          <th>
                                                &nbsp;
                                          </th>
                                    </tr>
                        </HeaderTemplate>
                        <ItemTemplate>
                              <tr>
                                    <td align="center">Item Number:
                                          <%# Container.DataItem("Pitemnumber") %>
                                          <asp:Label id="lblPitemnumber" runat="server" ReadOnly="True" Visible="false" Text='<%# Container.DataItem("Pitemnumber") %>'>
                                          </asp:Label>
                                    </td>
                                    <td align="left">Item Name:
                                          <asp:Label id="lblPitemname" runat="server" ReadOnly="True" Visible="true" Text='<%# Container.DataItem("Pname") %>'>
                                          </asp:Label>
                                    </td>
                                    <td align="right">Item Price:
                                          <asp:Label id="lblprice" runat="server" ReadOnly="True" Visible="true" Text='<%# Container.DataItem("Pprice") %>'>
                                          </asp:Label>
                                          <asp:Label id="lblPhandling" runat="server" ReadOnly="True" Visible="False" Text='<%# Container.DataItem("Phandling") %>'>
                                          </asp:Label>
                                    </td>
                                    <td align="center">
                                          <asp:TextBox id="ItemQuantity" runat="server" Text='<%# Container.DataItem("Pitemquantity") %>' MaxLength="2" Style="width:30px; text-align:right"/>
                                    </td>
                                    <td>
                                          <asp:TextBox id="txtcode" runat="server" MaxLength="11" Style="width:100px; text-align:right" /></td>
                                    <td align="right"><b><%# FormatNumber(GetItemAmount(Container.DataItem("Pprice"), Container.DataItem("pitemquantity")), 2) %></b></td>
                        </ItemTemplate>
                        <FooterTemplate>
                              <tr>
                                    <th align="right" colspan="4">
                                          Postage & Handling:
                                    </th>
                                    <td align="right"><b><%# FormatCurrency(GetOrderShipping()) %></b></td>
                              </tr>
                              <tr>
                                    <th align="right" colspan="4">
                                          Order Total:
                                    </th>
                                    <td align="right"><b><%# FormatCurrency(GetOrderTotal()) %></b></td>
                                    <td>
                                          <asp:Button Text="Update" class="small" runat="server" onclick="ChangeQuantity" ID="Button1"
                                                NAME="Button2" />
                                    </td>
                              </tr>
                        </FooterTemplate>
                  </asp:repeater>
LVL 5
bullroutAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Pratima PharandeCommented:
I think i...after excuting the UpdateCart() function ... it goes to page load............
or/and updated data must be bind again with repeater control anywhere else in your code........
make sure what happens exactly.

ThanX :)
0
tovvenkiCommented:
Hi,
from the help on For...each
"The foreach statement repeats a group of embedded statements for each element in an array or an object collection. The foreach statement is used to iterate through the collection to get the desired information, but should not be used to change the contents of the collection to avoid unpredictable side effects."

instead of using For..each iterate using an index like

for index = 0 to cart.items.count
...
next

hope that this helps you

Regards
Venki
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
bullroutAuthor Commented:
Hi tovvenki,

I have changed this using your suggestion but now when I try to pick up the contents of the textboxes & labels and I get an error saying "Object reference not set to an instance of an object. " How can I access the values of the objects?
It falls over on this line "If Not txtcode.Text = "" Then"


Sub ChangeQuantity(ByVal send As Object, ByVal E As EventArgs)
        Dim i As Int32 = 0
        Dim strCode As String = ""
        Dim intusercode As Int32 = 0
        For i = 0 To cart.Items.Count - 1
            '  For Each dataItem As RepeaterItem In cart.Items
            Dim ItemQuantity As TextBox = (CType(cart.FindControl("ItemQuantity"), TextBox))
            Dim txtcode As TextBox = (CType(cart.FindControl("txtcode"), TextBox))
            Dim txtitemnumber As Label = (CType(cart.FindControl("lblPitemnumber"), Label))
            Dim lblprice As Label = (CType(cart.FindControl("lblprice"), Label))

            If Not txtcode.Text = "" Then
                strCode = GetValidCode(txtcode)
                If strCode Is Nothing Then 'if the user does not have a valid code then call the function
                    Call UpdateCart(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
                Else 'if the user has a valid code then look it up
                    Session("THECODE") = strCode
                    intusercode = 1
                    Call GetDistributorPrice(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
                End If
            Else
                'if the code is nothing then call the function
                Call UpdateCart(ItemQuantity, txtcode, txtitemnumber, lblprice, intusercode)
            End If
            'Exit For
        Next
    End Sub
0
Pratima PharandeCommented:
   For i = 0 To cart.Items.Count - 1
            '  For Each dataItem As RepeaterItem In cart.Items
            Dim dataitem as RepeaterItem  =  cart.Items(i)
                   
            Dim ItemQuantity As TextBox = (CType(dataitem.FindControl("ItemQuantity"), TextBox))

         
0
bullroutAuthor Commented:
Yah thanks guys!!!!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
ASP.NET

From novice to tech pro — start learning today.