Basic login script help

This is what I have so far, but an error is coming up at the moment that it cannot convery type string to booleon.

 Dim objConnection As SqlConnection = New _
         SqlConnection("data source=sqlserver;Initial Catalog=Test;user id=sa;password=")

    Dim ObjDataAdaptor As SqlDataAdapter = New SqlDataAdapter("Select SurveyorName, Password from Surveyors", objConnection)
    Dim objDataSet As DataSet

Private Sub btnOk_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnOk.Click
        If txtLoginName.Text & txtPassword.Text <> "" Then
            If txtLoginName.Text = ("SurveyorName") & txtPassword.Text = ("Password") Then
                Dim Main As New FormMain()
                Main.Show()
            Else
                MsgBox("login Failed")
            End If
        End If
    End Sub


Any ideas?

Something like this (to simplify)

SQL = "SELECT * FROM Surveyors WHERE SurveyorName = '" & txtLoginName.Text & "' AND Password  = '" & txtPassword.Text

dim cmd as SqlCommand = SqlCommand (SQL, objConnection)
dim dtr as SqlDataReader = cmd.ExecuteReader()

If dtr.Read Then
 
   ' OK

End If

Morning,

Ok, now you are confusing me, :)

'  I have this at the moment, Should your code be going in the declarations sections or within the button click for the ok button

Think this code may be wrong, esp the sqlcommand call, please help.

    Private Sub btnOK_click(ByVal sender As System.Object, _
                ByVal e As System.EventArgs) Handles btnOk.Click
        Dim objConnection As SqlConnection = New _
               SqlConnection("data source=sqlserver;Initial Catalog=Test;user id=sa;password=")

        Dim ObjDataAdaptor As SqlDataAdapter = New SqlDataAdapter("SELECT * FROM Surveyors WHERE SurveyorName = '" & txtLoginName.Text & "' AND Password  = '" & txtPassword.Text, objConnection)

        Dim cmd As SqlCommand = SqlCommand(ObjDataAdaptor, objConnection)
        Dim dtr As SqlDataReader = cmd.ExecuteReader()

        If dtr.Read Then

            ' OK

        End If


    End Sub

Dim cmd As SqlCommand = NEW SqlCommand(ObjDataAdaptor, objConnection)

Its now telling me that the ObjDataAdaptor cannot be converted to string

I have treid also as your code, but using "SQL = ...." it has an erro saying "sys.data.sql.... is not accessable in this context as it is private
 

I have this functions inside a module

Public Function GetConnection() As SqlConnection
            Dim conn As SqlConnection
            Dim strConn As String = "Data Source=Server1;Initial Catalog=MyDatabaseName;Integrated Security=True"
                         
              conn = New SqlConnection(strConn)
            Try
                conn.Open()
            Catch ex As SqlException
                Console.WriteLine("SQL Server ERROR: " & ex.Message & " in " & ex.StackTrace)

            Catch ex As Exception
                Console.WriteLine("ERROR opening connection: " & ex.Message)
            End Try
            GetConnection = conn
        End Function

        Public Function RetrieveData(ByVal query As String) As SqlDataReader
            Dim rdr As SqlDataReader
            Dim conn As SqlConnection = GetConnection()
            Try
                Dim cmd As SqlCommand = New SqlCommand(query, conn)
                ''CommandBehavior.CloseConnection closes the underlying connection
                ''whenever the reader is closed
                rdr = cmd.ExecuteReader(CommandBehavior.CloseConnection)
            Catch ex As SqlException
                Console.WriteLine("SQL Server ERROR: " & ex.Message & " in " & ex.StackTrace)
            Catch ex As Exception
                Console.WriteLine("ERROR retrieving data: " & ex.Message)
            End Try
            RetrieveData = rdr
        End Function


And I use it this way


Dim SQL as String = "SELECT * FROM Surveyors WHERE SurveyorName = '" & txtLoginName.Text & "' AND Password  = '" & txtPassword.Text
Dim sqlReader as SqlDataReader = ExecuteReader(SQL)

If sqlReader.Read Then

End If
sqlReader.Close()
sqlReader = Nothing

Ok thats cool, I see the advantages of having them in a module,

I have entered the above functions into a module and called it functions.vb

I have entered the last bit of code into my apps login form.

I have put this under the OK button, is this correct as it is saying that ExecuteReader is not declared?

This is the complete code for my login form,

Imports System.Data
Imports System.Data.SqlClient
Imports System.Windows.Forms

Public Class Login
    Inherits Form

    'Dim objConnection As SqlConnection = New _
    '              SqlConnection("data source=sqlserver;Initial Catalog=Test;user id=sa;password=")

#Region " Windows Form Designer generated code "


#End Region


    Private Sub Login_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load

    End Sub

    Private Sub btnOK_click(ByVal sender As System.Object, _
                ByVal e As System.EventArgs) Handles btnOk.Click


        Dim SQL As String = "SELECT * FROM Surveyors WHERE SurveyorName = '" & txtLoginName.Text & "' AND Password  = '" & txtPassword.Text
        Dim sqlReader As SqlDataReader = ExecuteReader(SQL)

        If sqlReader.Read Then

        End If
        sqlReader.Close()
        sqlReader = Nothing

    End Sub

End Class

Sorry, is not ExecuteReader but RetrieveData.

This is all put in the button event.

The erro it comes up with is "Object Reference not set to instance of an object"

Show me your code and where it breaks

It breaks on the "If sqlreader.read then"

Private Sub btnOK_click(ByVal sender As System.Object, _
                ByVal e As System.EventArgs) Handles btnOk.Click

        Dim SQL As String = "SELECT * FROM Surveyors WHERE SurveyorName = '" & txtLoginName.Text & "' AND Password  = '" & txtPassword.Text
        Dim sqlReader As SqlDataReader = RetrieveData(SQL)

        If sqlReader.Read Then

            MsgBox("OK")
        Else
            MsgBox("Not OK")
        End If
        sqlReader.Close()
        sqlReader = Nothing

Cheers for all your help, that works ok.

Youve been more than helpful so I win end this question here.

I will however be opening up another question, as I need to assigned the SurveyorId to a globalVariable (globalSurveyorId)

Thanks again for all your help jpaulino