We help IT Professionals succeed at work.

We've partnered with Certified Experts, Carl Webster and Richard Faulkner, to bring you a podcast all about Citrix Workspace, moving to the cloud, and analytics & intelligence. Episode 2 coming soon!Listen Now

x

Controls bound to a DataView: Problems inserting new line/record

IvanHowarth
IvanHowarth asked
on
Medium Priority
267 Views
Last Modified: 2011-09-20
I have a form in my VB.net application (built using Visual Studio 2003) that has a listbox control (its DataSource set to MyDataView and it’s DisplayMember set to a MyDataView column). Several textfields also exist and all bound to the same MyDataView.

How do I successfully insert a new record (datarow) into the DataView with the data from the respective textboxs and then list the respective column in the ListBox with the rest, ready to update the datasource (SQL 2000 table) when the adapter’s update method is called. The adapter, dataset, SQLConnection and dataView were generated using VS 2003 wizards. I can’t get it to do the insert. If I hard code the update, the record gets added twice then throws a constraint exception (duplication of the PK). If I just call the update method when the save button is clicked, nothing happens or things start to go horribly wrong. The other select, delete, updates all work ok.

Big thanks in advance!

Break down of what I have done:
===========================================================
On load (Select):      - WORKS

sqlDataAdapter1.MyTable.SelectCommand.Parameters("@MyRangeColumn").Value = “Range”
               
sqlDataAdapter1.Fill(MyDataSet)                      ‘see above on how the dv is linked

============================================================

Delete a record based on the selected ListBox value - WORKS

Dim i As Integer = myDataView.Find(CType(myListBox.SelectedValue, DataRowView)_(myListBox.DisplayMember.ToString).ToString())

myDataView.Delete(i)

============================================================

Saving data to source (Update) - WORKS

sqlDataAdapter1.Update(MyDataSet)

============================================================

Insert (add new record)                 - DOESN’T WORK

'Upon pressing a button:
Set all textBoxs.text = “”

‘the following duplicates the record throwing the unique constraint exception
Dim drvNew As DataRowView = myDataView.AddNew
drvNew("MyRangeColumn") = “Range”                
drvNew("MyColumn2") = txtBox2.Text
drvNew("MyColumn3") = txtBox3.Tex
‘…and so on

drvNew.EndEdit()
Comment
Watch Question

Commented:
Use this

        Me.BindingContext(myDataView).EndCurrentEdit()
       sqlDataAdapter1.Update(MyDataSet)

for your insert code.  The problem you are facing with your present approach is that the changes that have been made to the controls have not been committed to the datatable when you are trying to do the update because the user is moving directly from those controls to the button.  If you call .EndCurrentEdit explicitly, it should overcome that problem.

Roger

Not the solution you were looking for? Getting a personalized solution is easy.

Ask the Experts

Author

Commented:
Thanks Roger - perfect!

One note to add for those following: Although Roger's answer is 100% right, don't then hard code anything in the insert code like I have, otherwise it still gets duplicated. Keep it simple!

Commented:
Yes, perhaps I should have added that the reason that you were getting duplication when you did have that extra code was because the .EndCurrentEdit that was NOT being automatically called when users moved direct from editing a control to the button WAS being automatically called as soon as it met

    Dim drvNew As DataRowView = myDataView.AddNew

Anyway, glad it's sorted.

Roger
Access more of Experts Exchange with a free account
Thanks for using Experts Exchange.

Create a free account to continue.

Limited access with a free account allows you to:

  • View three pieces of content (articles, solutions, posts, and videos)
  • Ask the experts questions (counted toward content limit)
  • Customize your dashboard and profile

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.