VB2005 Express "Function does not return a value"?
Hello Experts, I need help fixing a apperantly harmless error.....the app still runs but I get this warning on two functions
Function 'GetString' doesn't return a value on all code paths. A null reference exception could occur at run time when the result is used.
CODE
************************
Public Function GetString(ByVal Section As String, _
ByVal Key As String, ByVal [Default] As String) As String
' Returns a string from your INI file
Dim intCharCount As Integer
Dim objResult As New System.Text.StringBuilder(
intCharCount = GetPrivateProfileString(Se
[Default], objResult, objResult.Capacity, strFilename)
If intCharCount > 0 Then GetString = _
Left(objResult.ToString, intCharCount)
End Function
**************************
thanks all for your assistance
Function 'GetString' doesn't return a value on all code paths. A null reference exception could occur at run time when the result is used.
CODE
************************
Public Function GetString(ByVal Section As String, _
ByVal Key As String, ByVal [Default] As String) As String
' Returns a string from your INI file
Dim intCharCount As Integer
Dim objResult As New System.Text.StringBuilder(
intCharCount = GetPrivateProfileString(Se
[Default], objResult, objResult.Capacity, strFilename)
If intCharCount > 0 Then GetString = _
Left(objResult.ToString, intCharCount)
End Function
**************************
thanks all for your assistance
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Because your return statement only occurs if intCharCount > 0..... Add an else with a different return value.... Otherwise if intCharCount is not > 0, you could get a null exception error.
If intCharCount > 0 Then
Return Left(objResult.ToString, intCharCount)
else
Return ""
end if
If intCharCount > 0 Then
Return Left(objResult.ToString, intCharCount)
else
Return ""
end if
Sometimes its nice to declare a variable specifically for the return and then return that variable:
Public Function GetString(ByVal Section As String, _
ByVal Key As String, ByVal [Default] As String) As String
Dim retString As String = "" ' or use Nothing instead of ""
' Returns a string from your INI file
Dim intCharCount As Integer
Dim objResult As New System.Text.StringBuilder(
intCharCount = GetPrivateProfileString(Se
[Default], objResult, objResult.Capacity, strFilename)
If intCharCount > 0 Then
retString = Left(objResult.ToString, intCharCount)
End If
Return retString
End Function
Public Function GetString(ByVal Section As String, _
ByVal Key As String, ByVal [Default] As String) As String
Dim retString As String = "" ' or use Nothing instead of ""
' Returns a string from your INI file
Dim intCharCount As Integer
Dim objResult As New System.Text.StringBuilder(
intCharCount = GetPrivateProfileString(Se
[Default], objResult, objResult.Capacity, strFilename)
If intCharCount > 0 Then
retString = Left(objResult.ToString, intCharCount)
End If
Return retString
End Function
ASKER
thanks to everyone for their assistance on this post !!!
Dave
Dave
ByVal Key As String, ByVal [Default] As String) As String
' Returns a string from your INI file
Dim intCharCount As Integer
Dim objResult As New System.Text.StringBuilder(
intCharCount = GetPrivateProfileString(Se
[Default], objResult, objResult.Capacity, strFilename)
If intCharCount > 0 Then
Return Left(objResult.ToString, intCharCount)
else return "something"
End Function