Solved

Using joins with a C# DataReader - getting IndexOutOfRangeExceptions

Posted on 2006-06-25
3
381 Views
Last Modified: 2008-03-10
Hi all,

I am having some issues with trying to retrieve the results of a Join using a DataReader.  The syntax seems to work ok as a record is returned but I want to access one column from the table i'm joining to and it won't let me for some reason.

Here is the relevant code (I have commented out sections to just try to debug the one column).

try
            {

                //this.mstrSQL = "SELECT ProjectID FROM Projects WHERE (ProjectID =@@IDENTITY)";
                this.mstrSQL = "SELECT Customers.CompanyName FROM Customers, Projects WHERE ProjectID = " + this.mintProjectID + " AND Projects.CustomerID=Customers.CustomerID";
                //this.mstrSQL = "SELECT * FROM Projects, Customers WHERE ProjectID = " + this.mintProjectID + " AND Projects.CustomerID=Customers.CustomerID";
                this.openDatabase();
                OleDbCommand myCmd = new OleDbCommand(this.mstrSQL, this.dbConnect);
                OleDbDataReader myReader = myCmd.ExecuteReader();
               
                if (myReader.HasRows)
                {
                    while (myReader.Read())
                    {
                        //we found a value, grab the ProjectID
                        /*
                        this.txtProjectTitle.Text = (String)myReader["ProjectTitle"];                        
                        this.txtProjectNotes.Text = (String)myReader["ProjectNotes"];
                        this.txtStartDate.Text = System.Convert.ToString(myReader["StartDate"]);
                        this.txtDueDate.Text = System.Convert.ToString(myReader["DueDate"]);
                        this.mintProjectID = (int)myReader["ProjectID"];                        
                        this.txtRender1Loc.Text = System.Convert.ToString(myReader["RenderLocation1"]);
                        this.txtRender1Desc.Text = System.Convert.ToString(myReader["RenderDescription1"]);
                        this.txtRender2Loc.Text = System.Convert.ToString(myReader["RenderLocation2"]);
                        this.txtRender2Desc.Text = System.Convert.ToString(myReader["RenderDescription2"]);
                        this.txtRender3Loc.Text = System.Convert.ToString(myReader["RenderLocation3"]);
                        this.txtRender3Desc.Text = System.Convert.ToString(myReader["RenderDescription3"]);
                        this.txtRender4Loc.Text = System.Convert.ToString(myReader["RenderLocation4"]);
                        this.txtRender4Desc.Text = System.Convert.ToString(myReader["RenderDescription4"]);
                        this.txtRender5Loc.Text = System.Convert.ToString(myReader["RenderLocation5"]);
                        this.txtRender5Desc.Text = System.Convert.ToString(myReader["RenderDescription5"]);                        
                        */
                        this.cboCustomers.Text = System.Convert.ToString(myReader["Customers.CompanyName"]);  //LINE I AM THROWING EXCEPTION ON
                       
                        break;
                    }
                }
                else
                {
                    //we didnt find any values, this is an issue, abort
                    MessageBox.Show("Unable to locate any valid data in this project!", "Data Value Error");
                    myReader.Close();
                    return;
                }
                myReader.Close();
                this.closeDatabase();
            }
            catch (Exception exp)
            {
                //something went wrong, abort  
                string tempmsg = exp.Message;
                string tempmsg2 = exp.ToString();  //<-- This shows that it is an IndexOutOfRangeException on "Customers.CompanyName"              
                this.closeDatabase();
                //MessageBox.Show("Exception thrown during attempt to obtain ProjectID, aborting.", "Fatal Data Error");
               
            }

I know my two SQL statements are a bit different, but neither one works and switching the ordering of Customers, Projects to Projects,Customers seems to make no difference either.  It is possible what I am doing is no longer allowed as the way I am doing the Join doesnt use the JOIN keyword itself and worked great under ADO and DAO back in my VB6 days but perhaps I need some different syntax to accomplish the same thing now.

Thanks,
Nathan
0
Comment
Question by:ironwill96
3 Comments
 
LVL 142

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 16979920
don't use the tablename, only the column name:
                        this.cboCustomers.Text = System.Convert.ToString(myReader["CompanyName"]);  

if you find the same column name in both tables, you have to give the column an alias in the query.
anyhow, you should avoid using "SELECT * ", but specify the column list of only those columns that you really need.
0
 

Expert Comment

by:mattbelfast23
ID: 16993332
The code you have shown looks like its doing 3 separate queries which would return 3 separate result sets.  You need to use myReader.NextResult() to advance to the next available result set.

do
{
                    while (myReader.Read())
                    {
                    }
}
while(myReader.NextResult())
}
0
 
LVL 2

Author Comment

by:ironwill96
ID: 16995870
Bah, you'd think I would have tried dropping the table prefix.  Thanks angelIII!

Nathan
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

Extention Methods in C# 3.0 by Ivo Stoykov C# 3.0 offers extension methods. They allow extending existing classes without changing the class's source code or relying on inheritance. These are static methods invoked as instance method. This…
In order to hide the "ugly" records selectors (triangles) in the rowheaders, here are some suggestions. Microsoft doesn't have a direct method/property to do it. You can only hide the rowheader column. First solution, the easy way The first sol…
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…
This video explains how to create simple products associated to Magento configurable product and offers fast way of their generation with Store Manager for Magento tool.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now