[Okta Webinar] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 631
  • Last Modified:

Excel VBA IF function question.

Hello Experts,

My question is this:

I need to know the correct function for matching multiple criteria before an event takes place.  I have the following code:

'   =============================================================
'   If the User name and Password are a manager's Login Then
'   Open the Options Label AND include the Add/Remove User Option
'   =============================================================

    If txtLoginID.Value = "Manager" Then
    If txtLoginPW.Value = "Password" Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else If
.....

Obviously the line -- If txtLoginID.Value = "Manager" Then -- will cause an error with the line that follows.  How do I get those two criteria to be considered before the visible options below it are allowed??
0
neelyjer
Asked:
neelyjer
  • 13
  • 10
  • 6
  • +1
4 Solutions
 
Harisha M GCommented:
Hi,

    If txtLoginID.Value = "Manager" And txtLoginPW.Value = "Password" Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else If
---
Harish
0
 
neelyjerAuthor Commented:
I will increase the points to 500 if someone can tell me how to get this code to look at a worksheet for individual user names instead of the hardcoded values given above.
0
 
Harisha M GCommented:
neelyjer, assuming you have username in A1 and password in B1..

    If txtLoginID.Value = Sheets("SheetName").[A1] And txtLoginPW.Value = Sheets("SheetName").[B1] Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else If
0
VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

 
rockiroadsCommented:
Harish has done the right IF statement join for u

or u could just take your existing code and add the END IF in the right place


 If txtLoginID.Value = "Manager" Then
    If txtLoginPW.Value = "Password" Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    End If  'end here
 Else If  'this else if loginid not = Manager
0
 
rockiroadsCommented:
To look at sheet values

I suggest u place them in variables

Dim sUserID as String
dim sPswd as String

sUserID = Sheets("nameofsheet").Range("A1")
'or
sUserID = Sheets("nameofsheet").Cells(1,1)

same for password

sPassword = Sheets("nameofsheet").Range("A2")
'or
sPassword = Sheets("nameofsheet").Cells(1,2)

Now use sUserID and sPassword in your code checks

0
 
neelyjerAuthor Commented:
mgh_mgharish ,

>    If txtLoginID.Value = "Manager" And txtLoginPW.Value = "Password" Then
>        frmDataOptions.Visible = True
>        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
>    Else If

The Else If portion of the code is returning the error -

              Compile Error:
              Expected: expression

When the code i ran I receive a syntax error.
0
 
Harisha M GCommented:
Remove "If"

    If txtLoginID.Value = Sheets("SheetName").[A1] And txtLoginPW.Value = Sheets("SheetName").[B1] Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else
        ' Do whatever you want
    End If
0
 
neelyjerAuthor Commented:
Starting to feel like a dumb a$$ here....

Used the following --

    If txtLoginID.Value = Sheets("Manager").[A1] And txtLoginPW.Value = Sheets("Manager").[B1] Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else
        If txtLoginID.Value = Sheets("Users").[A1] And txtLoginPW.Value = Sheets("Users").[B1] Then
            frmDataOptions.Visible = True
            ckbUserAddRemove.Visible = False
            frmSubmit.Visible = True
        End If

Got an error stating Block If without End If.  So I added another End If.

    If txtLoginID.Value = Sheets("Manager").[A1] And txtLoginPW.Value = Sheets("Manager").[B1] Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
    Else
        If txtLoginID.Value = Sheets("Users").[A1] And txtLoginPW.Value = Sheets("Users").[B1] Then
            frmDataOptions.Visible = True
            ckbUserAddRemove.Visible = False
            frmSubmit.Visible = True
        End If
    End If

Then got error stating --

     Runtime error 424 -- Object Required and

If txtLoginID.Value = Sheets("Manager").[A1] And txtLoginPW.Value = Sheets("Manager").[B1] Then

Is highlighted.

Any Ideas?
0
 
Harisha M GCommented:
Do you have a sheet named Manager and Users ?

If yes, this should work:

  If txtLoginID.Value = Sheets("Manager").[A1] And txtLoginPW.Value = Sheets("Manager").[B1] Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
  ElseIf txtLoginID.Value = Sheets("Users").[A1] And txtLoginPW.Value = Sheets("Users").[B1] Then
            frmDataOptions.Visible = True
            ckbUserAddRemove.Visible = False
            frmSubmit.Visible = True
  End If
0
 
neelyjerAuthor Commented:
yes i do
0
 
Harisha M GCommented:
Can you send the workbook ? (Click my name, you'll get my email id)
Or put it in http://www11.rapidupload.com/ and post the link here
0
 
neelyjerAuthor Commented:
if I remove the And txtLogin.....  the error does not occur
0
 
Harisha M GCommented:
txtLoginID or txtLoginPW ?

Try putting brackets:

If((txtLoginID.Value = Sheets("Manager").[A1]) And (txtLoginPW.Value = Sheets("Manager").[B1])) Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = True
        frmSubmit.Visible = True
ElseIf((txtLoginID.Value = Sheets("Users").[A1]) And (txtLoginPW.Value = Sheets("Users").[B1])) Then
        frmDataOptions.Visible = True
        ckbUserAddRemove.Visible = False
        frmSubmit.Visible = True
End If
0
 
rockiroadsCommented:
Harish, EE (unsupported) now have this

http://www.ee-stuff.com

I suggest u use that for requests. Its quite handy!


As debugging, can I suggest u put in variables like I said

then do a debug.print or msgbox so u can confirm what is there


msgbox "UserID in sheet is >" & sUseriD & "<" & vbcrlf & "UserID in txtbox is >" & txtLoginID.Value & "<"
msgbox "Pswd in sheet is ">" & sPassword & "<" & vbcrlf & "Pswd in txtbox is >" & txtLoginPW.Value & "<"



0
 
Harisha M GCommented:
rockiroads, thanks for the interest, but I disagree with "Its quite handy!"
0
 
rockiroadsCommented:
No probs Harish. The MS Access lot find it useful. Even the page editor has suggested using that. For small minor things that help EE, its useful I think.
Each to their own I guess
0
 
neelyjerAuthor Commented:
mgh_mgharish

I EMAILED THE FILE TO YOUR GMAIL ACCOUNT.  I tried the link you provided but the site is having issues.  Won;t accept my upload.
0
 
rockiroadsCommented:
neelyjer
have u tried uploading via http://ee-stuff.com
I know you are working with Harish but for other experts who want to help or for other people who want to read, its only fair that you place in a common area.
0
 
cj_1969Commented:
Try using .Text instead of .Value ...
i.e. txtLoginID.Text and txtPassword.Text
0
 
neelyjerAuthor Commented:
rockiroads,

Although all of my correspondents have been directed towards Harish, I amlook at the other responses as well. I will try the site you recommended.

Thanks
0
 
neelyjerAuthor Commented:
cj_1969,

Attempted your suggestion and got the same error message as above.
0
 
neelyjerAuthor Commented:
ALL EXPERTS,

Here is the link to file I have uploaded <a href="https://filedb.experts-exchange.com/incoming/ee-stuff/282-Book1--version-1-.zip">!!!</a>
0
 
neelyjerAuthor Commented:
guess I didn't need to code the html huh???
0
 
neelyjerAuthor Commented:
ROCKIROADS,

I haven't tried your suggestion of adding variables because I am very new to VBA.  I have a good general understanding of the structure and format of a few VBA items, but when it comes to adding variables, I haven't got a clue.  If you'd be willing to explain more on how to use the variables, I will gladly give them a try.  Please keep in mind, I am trying to learn VBA, although your direct coding would be appreciated I would rather code myself.  So if you can provide a sample code then a breakdown of what the code does and what the code is suggesting, I think that would be more advantageous to me.

0
 
cj_1969Commented:
Ok, I hope you don't feel too silly about this ...
I looked at your document and got it working ...
the .Value paramter does work ...
you need to reference the password field with the correct name ... you are calling txtLoginPW but the field is named txtPW
0
 
cj_1969Commented:
Sorry about the comment above ... in reading over it, I don't mean to be or sound demeaning ... its a very common mistake that all of us make  ... I alway need a second pair of eyes when coding to find little things like that  :)
0
 
Harisha M GCommented:
The names of your textboxes are txtUserID and txtUserPW

But you have coded them as txtLoginID and txtLoginPW

Change one of them, and it'll be okay
0
 
neelyjerAuthor Commented:
OOPS & Excellent!!!  One last thing and we'll call this question complete.  How do I get the password to not be displayed in the text box?  I don't think I'd like to have someone looking over my shoulder when I login and see my PW in plain site.
0
 
Harisha M GCommented:
Select your "txtUserPW" on the form and set it "PasswordChar" property to "*"
0
 
Harisha M GCommented:
Since your txtUserPW is hidden behind the frame, you may follow this procedure:

In the Properties window, select txtUserPW in the combobox. Then set the PasswordChar property to *
0
 
neelyjerAuthor Commented:
Thank you guys so much.

rockiroads - 50 for suggesting upload spot for my file
cj_1969  - 50 for catching the error
mgh_mgharish - 400 for fixing initial code and supply how to display password as '*'

Thanks again for all your help!!!

NEXT QUESTION

http://www.experts-exchange.com/Applications/Q_21901132.html
0
 
rockiroadsCommented:
Hi neelyjer, glad its sorted. Im just looking at my EE Notifications and saw this
Already sorted.
0

Featured Post

Hire Technology Freelancers with Gigs

Work with freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely, and get projects done right.

  • 13
  • 10
  • 6
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now