asked on

File in use after email as attachment

I made a form where the user can fill it out, browser for a file, and then click submit. I have it setup so the form data is emailed to me along with the attachment. It works except I can not delete the attachment from the server because it is still in use. Why is the file still in use after emailing it out? If I remove this line (upload the attachment but dont send it in the email) then the file is not in use and I can delete it after.) Why when I add the following line is the file in use after and can not be deleted??

message.Attachments.Add(new Attachment(strdir + strfilename));

Bob Learned

.NET version? 2002, 2003, or 2005?

Bob

Bob Learned

Should it be MailAttachment, instead of Attachment?

Bob

Kurt4949

ASKER

For example if I tell asp.net to delete the file after then I get this error

Exception Details: System.IO.IOException: The process cannot access the file 'D:\wwwTesting\promessInc\upload\forms.css' because it is being used by another process.

Source Error:

Line 114:
Line 115: //Uploaded file deleted after sending e-mail
Line 116: File.Delete(strdir + strfilename);
Line 117:
Line 118:

Kurt4949

ASKER

asp.net 2.0 with C#

Kurt4949

ASKER

I believe that line is correct. I"m using System.Net.Mail

example here http://www.systemnetmail.com/faq/2.3.aspx

davehunt00

Here's a similar set of code I use. r2("Attachment") is a field with the file name. You might want to add the Try Catch stuff in case you ever hit an exception.

If (r2("Attachment").ToString <> "") Then
Dim MsgAttachmentPath As String = Server.MapPath(r2("Attachment").ToString)
Dim attachment As System.Web.Mail.MailAttachment
Try
attachment = New System.Web.Mail.MailAttachment(MsgAttachmentPath)
emailMessage.Attachments.Add(attachment)
Catch ex As Exception
Dim sb As New System.Text.StringBuilder
sb.Append("my note about where this occurs")
sb.Append("Message: " & ex.Message.ToString)
sb.Append("InnerException: " & ex.InnerException.ToString)
sb.Append("Target site: " & ex.TargetSite.Name.ToString)
sb.Append("Stack Trace: " & ex.StackTrace.ToString)
exString = sb.ToString
SendErrorEmail(exString)
End Try
End If

Hope that helps.
Dave

Bob Learned

Yeah, what happens if you use System.Web.Mail, instead of System.Net.Mail?

Bob

Kurt4949

ASKER

Here is my code. It works perfect execpt that I can not delete the attachement after. I even get the email with the attachment.

void submitForm(Object s, EventArgs e)
{
if (Page.IsValid == true)
{

string fromEmail;
string toEmail;
string userHostAddress = "";

string strdir = "D:\\wwwTesting\\files\\upload\\";
string strfilename = Path.GetFileName(txtFile.PostedFile.FileName);
txtFile.PostedFile.SaveAs(strdir + strfilename);

fromEmail = "webmaster@me.com";
toEmail = "kurt@me.com";
//get IP Address
userHostAddress = Request.UserHostAddress;

// System.Net.Mail.SmtpClient is the new class in 2.0
SmtpClient smtpClient = new SmtpClient();
MailMessage message = new MailMessage();

try
{
smtpClient.Host = "localhost";
smtpClient.Port = 25;
message.From = new MailAddress(fromEmail);

message.To.Add(toEmail);
message.Subject = " Form Submission";

//Begin - Message body content
message.IsBodyHtml = true;

//html message body
message.Body = "<html>" +
"<head>" +
"<title>Form Submission</title>" +
"</head>" +

"<body>" +
"" +
"Form Submission " +
"Salutation: " + salutation.Text +
" First name: " + fName.Text +
" Last name: " + lName.Text +
" Comments: " + comments.Text +
"</body></html>";

//End - Message body content

//Attach File
message.Attachments.Add(new Attachment(strdir + strfilename));

// Send SMTP mail
smtpClient.Send(message);

// on success hide / show panels
lblStatus.Text = "Email successfully sent.";
panelContactForm.Visible = false;
panelThankYou.Visible = true;

}
catch (Exception ex)
{
lblStatus.Text = "Send Email Failed. " + ex.Message;

}

//Uploaded file deleted after sending e-mail
File.Delete(strdir + strfilename);

}//end if Page.IsValid

}

</script>

davehunt00

More as a guess than anything, try clearing the attachments.

So, before File.Delete, try Message.Attachments.Clear

ASKER CERTIFIED SOLUTION

Bob Learned

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

Kurt4949

ASKER

Hi Bob,

The using blocked did the trick. Thanks!

using (MailMessage message = new MailMessage())
{
}

Kurt