Solved

File in use after email as attachment

Posted on 2006-06-26
11
309 Views
Last Modified: 2008-01-09
I made a form where the user can fill it out, browser for a file, and then click submit.  I have it setup so the form data is emailed to me along with the attachment.  It works except I can not delete the attachment from the server because it is still in use.  Why is the file still in use after emailing it out?  If I remove this line   (upload the attachment but dont send it in the email)  then the file is not in use and I can delete it after.)  Why when I add the following line is the file in use after and can not be deleted??

message.Attachments.Add(new Attachment(strdir + strfilename));
0
Comment
Question by:Kurt4949
  • 5
  • 4
  • 2
11 Comments
 
LVL 96

Expert Comment

by:Bob Learned
ID: 16987756
.NET version?  2002, 2003, or 2005?

Bob
0
 
LVL 96

Expert Comment

by:Bob Learned
ID: 16987796
Should it be MailAttachment, instead of Attachment?

Bob
0
 
LVL 7

Author Comment

by:Kurt4949
ID: 16987813
For example if I tell asp.net to delete the file after then I get this error


 Exception Details: System.IO.IOException: The process cannot access the file 'D:\wwwTesting\promessInc\upload\forms.css' because it is being used by another process.

Source Error:

Line 114:
Line 115:            //Uploaded file deleted after sending e-mail
Line 116:                File.Delete(strdir + strfilename);
Line 117:      
Line 118:            
0
 
LVL 7

Author Comment

by:Kurt4949
ID: 16987824
asp.net 2.0 with C#
0
 
LVL 7

Author Comment

by:Kurt4949
ID: 16987877
I believe that line is correct.  I"m using System.Net.Mail

example here http://www.systemnetmail.com/faq/2.3.aspx 
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 4

Expert Comment

by:davehunt00
ID: 16987998
Here's a similar set of code I use. r2("Attachment") is a field with the file name.  You might want to add the Try Catch stuff in case you ever hit an exception.

        If (r2("Attachment").ToString <> "") Then
            Dim MsgAttachmentPath As String = Server.MapPath(r2("Attachment").ToString)
            Dim attachment As System.Web.Mail.MailAttachment                  
            Try
                attachment = New System.Web.Mail.MailAttachment(MsgAttachmentPath)
                emailMessage.Attachments.Add(attachment)
            Catch ex As Exception
                Dim sb As New System.Text.StringBuilder
                sb.Append("my note about where this occurs")
                sb.Append("Message: " & ex.Message.ToString)
                sb.Append("InnerException: " & ex.InnerException.ToString)
                sb.Append("Target site: " & ex.TargetSite.Name.ToString)
                sb.Append("Stack Trace: " & ex.StackTrace.ToString)
                exString = sb.ToString
                SendErrorEmail(exString)
            End Try
        End If

Hope that helps.  
Dave
0
 
LVL 96

Expert Comment

by:Bob Learned
ID: 16988055
Yeah, what happens if you use System.Web.Mail, instead of System.Net.Mail?

Bob
0
 
LVL 7

Author Comment

by:Kurt4949
ID: 16988109
Here is my code.  It works perfect execpt that I can not delete the attachement after.  I even get the email with the attachment.    


void submitForm(Object s, EventArgs e)
    {
        if (Page.IsValid == true)
        {

            string fromEmail;
            string toEmail;
            string userHostAddress = "";


            string strdir = "D:\\wwwTesting\\files\\upload\\";
            string strfilename = Path.GetFileName(txtFile.PostedFile.FileName);
            txtFile.PostedFile.SaveAs(strdir + strfilename);
           

            fromEmail = "webmaster@me.com";
            toEmail = "kurt@me.com";
            //get IP Address
            userHostAddress = Request.UserHostAddress;


            // System.Net.Mail.SmtpClient is the new class in 2.0
            SmtpClient smtpClient = new SmtpClient();
            MailMessage message = new MailMessage();
           
           
            try
            {
              smtpClient.Host = "localhost";
            smtpClient.Port = 25;
            message.From = new MailAddress(fromEmail);

            message.To.Add(toEmail);
            message.Subject = " Form Submission";
 
            //Begin - Message body content
            message.IsBodyHtml = true;

            //html message body
            message.Body = "<html>" +
                           "<head>" +
                           "<title>Form Submission</title>" +
                           "</head>" +

                           "<body>" +
                           "<font face=\"Arial, Helvetica, sans-serif\" size=\"2\">" +
                           "<b>Form Submission</b><br /><br />" +
                           "<b>Salutation:</b>    " + salutation.Text +
                            "<br /><b>First name:</b>   " + fName.Text +
                            "<br /><b>Last name:</b>     " + lName.Text +
                            "<br /><br /><b>Comments:</b><br /> " + comments.Text +
                            "</font></body></html>";

            //End - Message body content
       
            //Attach File
            message.Attachments.Add(new Attachment(strdir + strfilename));


            // Send SMTP mail
            smtpClient.Send(message);

            // on success hide / show panels
            lblStatus.Text = "Email successfully sent.";
            panelContactForm.Visible = false;
            panelThankYou.Visible = true;

            }
            catch (Exception ex)
            {
                lblStatus.Text = "Send Email Failed.<br>" + ex.Message;

            }


            //Uploaded file deleted after sending e-mail
                File.Delete(strdir + strfilename);
     
           
        }//end if Page.IsValid

    }

</script>
0
 
LVL 4

Expert Comment

by:davehunt00
ID: 16988183
More as a guess than anything, try clearing the attachments.

So, before File.Delete, try Message.Attachments.Clear


0
 
LVL 96

Accepted Solution

by:
Bob Learned earned 500 total points
ID: 16988333
If you create a 'using' block, the message should be disposed upon completion.  If you force garbage collection (used judiciously), then it should release the resources immediately.

void submitForm(Object s, EventArgs e)
    {
        if (Page.IsValid == true)
        {

            string fromEmail;
            string toEmail;
            string userHostAddress = "";


            string strdir = "D:\\wwwTesting\\files\\upload\\";
            string strfilename = Path.GetFileName(txtFile.PostedFile.FileName);
            txtFile.PostedFile.SaveAs(strdir + strfilename);
           

            fromEmail = "webmaster@me.com";
            toEmail = "kurt@me.com";
            //get IP Address
            userHostAddress = Request.UserHostAddress;

            // System.Net.Mail.SmtpClient is the new class in 2.0
            SmtpClient smtpClient = new SmtpClient();
            using (MailMessage message = new MailMessage())
            {
                       
               try
              {
                 smtpClient.Host = "localhost";
                 smtpClient.Port = 25;
                 message.From = new MailAddress(fromEmail);

                 message.To.Add(toEmail);
                 message.Subject = " Form Submission";
 
                //Begin - Message body content
                message.IsBodyHtml = true;

            //html message body
            message.Body = "<html>" +
                           "<head>" +
                           "<title>Form Submission</title>" +
                           "</head>" +

                           "<body>" +
                           "<font face=\"Arial, Helvetica, sans-serif\" size=\"2\">" +
                           "<b>Form Submission</b><br /><br />" +
                           "<b>Salutation:</b>    " + salutation.Text +
                            "<br /><b>First name:</b>   " + fName.Text +
                            "<br /><b>Last name:</b>     " + lName.Text +
                            "<br /><br /><b>Comments:</b><br /> " + comments.Text +
                            "</font></body></html>";

            //End - Message body content
       
            //Attach File
            message.Attachments.Add(new Attachment(strdir + strfilename));


            // Send SMTP mail
            smtpClient.Send(message);

            // on success hide / show panels
            lblStatus.Text = "Email successfully sent.";
            panelContactForm.Visible = false;
            panelThankYou.Visible = true;

            }
            catch (Exception ex)
            {
                lblStatus.Text = "Send Email Failed.<br>" + ex.Message;

            }


            }// end using      

            // Force garbage collection to close the message immediately.
            GC.Collect();
           
            //Uploaded file deleted after sending e-mail
                File.Delete(strdir + strfilename);

        }//end if Page.IsValid

    }

Bob
0
 
LVL 7

Author Comment

by:Kurt4949
ID: 16993047
Hi Bob,

The using blocked did the trick. Thanks!

using (MailMessage message = new MailMessage())
            {
}


Kurt
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In .NET 2.0, Microsoft introduced the Web Site.  This was the default way to create a web Project in Visual Studio 2005.  In Visual Studio 2008, the Web Application has been restored as the default web Project in Visual Studio/.NET 3.x The Web Si…
ASP.Net to Oracle Connectivity Recently I had to develop an ASP.NET application connecting to an Oracle database.As I am doing it first time ,I had to solve several problems. This article will help to such developers  to develop an ASP.NET client…
This Micro Tutorial hows how you can integrate  Mac OSX to a Windows Active Directory Domain. Apple has made it easy to allow users to bind their macs to a windows domain with relative ease. The following video show how to bind OSX Mavericks to …
This is used to tweak the memory usage for your computer, it is used for servers more so than workstations but just be careful editing registry settings as it may cause irreversible results. I hold no responsibility for anything you do to the regist…

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now