Secure Login

I am pretty new to Cold Fusion and I want to use the application.cfm to check if the user logged in.  I've been trying to figure it out and I just can't.  Here is the code to my login page.  The user login and password is in a table called tbl_QA_staff.  The fields are strUserID and strPassword.

            <cfform name="loginform" action="QAQ_home.cfm" method="post">
              <table width="80%" cellspacing="2" cellpadding="2" align="center" bgcolor="#C0C0C0">
                <tr>
                  <td colspan="2" align="center" class="small"> Please enter your
                    Employee login and password.<br> <img src="../images/dot_clear.gif" width="1" height="10">
                  </td>
                </tr>
                <tr>
                  <th align="right" class="normal"><b>Login:</b></th>
                 
                    <td><cfinput type="text"
                        required="Yes"
                        size="15"
                        maxlength="17"
                        name="UserName"
                        value=""
                        class="smallblue">
                    </td>
                 
                </tr>
                <tr>
                  <th align="right" class="normal"><b>Password:</b></th>
                  <td><cfinput type="password"
                        required="Yes"
                        size="15"
                        maxlength="8"
                        name="password"
                        value=""
                        class="smallblue">      
                  </td>
                </tr>
                <tr>
                  <td colspan="2"><img src="../images/dot_clear.gif" width="1" height="15"></td>
                </tr>
                <tr>
                  <td colspan="2" align="right"><input type="Image" src="../images/go.gif" name="login_user" value="Log In"></td>
                </tr>
              </table>
            </cfform> </td>


At this point once they hit the button and go to QAQ_home.cfm.  I use a simple query and recordcount to check if the user exists.  Here is the code for that

      <!-- BEGIN VERIFICATION QUERY SECTION -->

      <CFQUERY name="getUser" datasource="QAQ">
      SELECT *
      FROM TBL_QA_Staff
      WHERE strUserID = '#form.username#'
      AND   strPassword = '#form.password#'      
      </CFQUERY>
      <!-- END VERIFICATION QUERY SECTION -->


      <!-- Verify User and set up sessions -->
      <CFIF getUser.RecordCount gt 0>
            <cfset dt = #dateformat(CreateODBCDate(now()),"mm/dd/yyyy")#+1>
            <cfset Session.UserName = getUser.strQA_name>
            <cfset Session.UserID = getUser.QA_ID>
            <cfset Session.UserLogin = getUser.strUserID>
            <cfset Session.UserLoc = getUser.StrQA_loc>
      <CFELSE>
      <!--- BEGIN User does not exist --->
      <cflocation url="#loginpage#">
      </CFIF>

I was told that this is not the most secure way to do things and that I should authenticate the user in the application.cfm.  My question is how do I do that?
LVL 5
trifecta2kAsked:
Who is Participating?

[Webinar] Streamline your web hosting managementRegister Today

x
 
usachrisk1983Connect With a Mentor Commented:
Inside your application.cfm file, do something like this:

<cfif not isDefined('session.UserName') and ListLast(cgi.script_name,'/') neq 'login.cfm'>
   <cflocation url="login.cfm">
   <cfabort>
</cfif>

This will cause login.cfm to load if session.username doesn't exist.  Use login.cfm to authenticate the user (you can use it as both the form page and the action page), and set session.username when you've authenticated them.  Now each page of your site will make sure the user is logged in before allowing them to view the page.
0
 
trifecta2kAuthor Commented:
How do I use the login.cfm as teh form and the action page?  I'm sorry I'm just new to this and I don't know how to do that.  
0
 
usachrisk1983Commented:
No problem :)  Something like this should work for you:

<cfif isDefined('form.username')>

  <!--- The user has submitted the form --->
  <cfquery name="x" datasource="y">
    select something from somewhere
  </cfquery>
  <!--- Verify the user has access to login, and set your session variable>

<cfelse>

  <!--- Show the form here, either exclude the ACTION or set it back to the same page. --->

</cfif>
0
 
trifecta2kAuthor Commented:
Seems like everything works.  Before the <CFELSE>  I added a <CFLOCATION> to move the application along and it works just fine.   I have one last question.  This is something new that I just noticed.  How so I get rid of the session variables.  They seem to never delete.
0
 
trifecta2kAuthor Commented:
Nevermind, I got it. Thanks for all your help.
0
All Courses

From novice to tech pro — start learning today.