Multithreading, how to access property on the new form

Hi experts

i have a main form that launch many other forms

so i do that :

on click button to launch a new form

Dim nThread As New Thread(AddressOf newThread)
        nThread.Name = Me.txtBxComputerName.Text & "_" & Me.TreeView.SelectedNode.Text
        MyThreads.Add(nThread) 'arraylist
        nThread.Start()

the sub :

Private Sub newThread()
        Dim frm As New MainReader 'the form to load

        frm.setComputerName = Me.txtBxComputerName.Text.Trim

        frm.setSelectedQueue = Me.TreeView.SelectedNode.Text

        Try
            Application.Run(frm)
        Catch ex As System.InvalidOperationException
            ' description :A main message loop is already running on this thread.
            MsgBox("Cannot open the reader : " & ex.Message)
        End Try
    End Sub

i have an exception on these lines :

 frm.setComputerName = Me.txtBxComputerName.Text.Trim

        frm.setSelectedQueue = Me.TreeView.SelectedNode.Text

illegal cross...

so i set Control.CheckForIllegalCrossThreadCalls on False

but i'm sure that theres is a better solution to access property of a new form

can you help me please?

kind regards
LVL 2
Dnx_7Asked:
Who is Participating?
 
Nandakumar SakthivelTechnology LeadCommented:

I think that the problem is for some operations we cannot access the particular control from the thread other that the created thread

for that declare a delegate and a function like this in the main thread (Not in the newthread() function)

Private Delegate Sub UpdateSelectedQueue(ByVal classname As object)

Private sub UpdateQueue(byval classname as object)
   ctype(classname ,MainReader ).MyComputerName= Me.TreeView.SelectedNode.Text
end sub

In the newthread() function just replace the code like this

Private Sub newThread()
        Dim frm As New MainReader 'the form to load
        frm.setComputerName = Me.txtBxComputerName.Text.Trim
       
         ====>  Dim UpdateQueueDlg As New UpdateSelectedQueue(AddressOf UpdateQueue)
         ====>  Me.Invoke(UpdateQueueDlg, New Object() {frm})
        Try
            Application.Run(frm)
        Catch ex As System.InvalidOperationException
            ' description :A main message loop is already running on this thread.
            MsgBox("Cannot open the reader : " & ex.Message)
        End Try
    End Sub

What i am doing is I am trying to access the value of the treeview in the main thread itself  by using the Invoke() method in the NewThread() by using delegates

Hope this helps
Thanks,
Nanda
0
 
Nandakumar SakthivelTechnology LeadCommented:

Can u post me the complete error message  with stack trace

Thanks,
Nanda
0
 
Dnx_7Author Commented:
System.InvalidOperationException was unhandled
  Message="Cross-thread operation not valid: Control 'TreeView' accessed from a thread other than the thread it was created on."
  Source="System.Windows.Forms"
  StackTrace:
       at System.Windows.Forms.Control.get_Handle()
       at System.Windows.Forms.Control.SendMessage(Int32 msg, Int32 wparam, Int32 lparam)
       at System.Windows.Forms.TreeView.get_SelectedNode()
       at AutomationReader.frmMain.newThread() in C:\Projet .NET\AutomationReader\AutomationReader\frmMain.vb:line 191
       at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       at System.Threading.ExecutionContext.runTryCode(Object userData)
       at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()

regards
0
Cloud Class® Course: Microsoft Exchange Server

The MCTS: Microsoft Exchange Server 2010 certification validates your skills in supporting the maintenance and administration of the Exchange servers in an enterprise environment. Learn everything you need to know with this course.

 
arif_eqbalCommented:
Hi Dnx_7
you can't access controls like this from a new thread, the Controls are in a separate UI thread and they are not directly accessible from outside the Thread boundary
you need to pass arguments to your Thread Function so that the Properties can be set

Try something like this

Public Class ThreadData
     Public ComputerName As String
     Public SelectedQueue As String

     Public Sub newThread()
        Dim frm As New MainReader
        frm.setComputerName = ComputerName
        frm.setSelectedQueue = SelectedQueue
        Try
            Application.Run(frm)
        Catch ex As System.InvalidOperationException
            ' description :A main message loop is already running on this thread.
            MsgBox("Cannot open the reader : " & ex.Message)
        End Try
    End Sub
End Class

Then to call it

    Dim ThData As New ThreadData
    ThData.ComputerName = Me.txtBxComputerName.Text.Trim
    ThData.setSelectedQueue = Me.TreeView.SelectedNode.Text

    Dim nThread As New Thread(AddressOf ThData.newThread)
    nThread.Name = Me.txtBxComputerName.Text & "_" & Me.TreeView.SelectedNode.Text
    MyThreads.Add(nThread)
    nThread.Start()


#I have typed out the code here so take care of some Typo or some silly mistake :-)
0
 
Jeff CertainCommented:
Okay... there are two options. If you're getting this error, it means that you are using Visual Studio 2005. Each control has a property called CheckForIllegalCrossThreadCalls. If you set this to false for the control you're trying to update, the issue will be resolved.

Alternately, you can use the Invoke approach (as Nanda indicated). Usually I take a slightly different approach than Nanda, however; I create a new routine to handle the control update, and check if the Invoke is actually required.

  Private Delegate Sub AddItemCallback(ByVal message As String)
  Private Sub AddItem(ByVal message As String)
    If Me.ListBox1.InvokeRequired Then
      Dim d As New AddItemCallback(AddressOf AddItem)
      Me.Invoke(d, New Object() {message})
    Else
      Me.ListBox1.Items.Add(message)
    End If
  End Sub
0
 
Jeff CertainCommented:
My two cents worth? 20/80 split between Nanda and Arif.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.