[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 252
  • Last Modified:

VB active directory logon script

Hi,

Please could someone take a look at this logon script for me.  It is basically a logon script to set a users printer based on active directory group membership.
The script seems to run fine but does not do the requested action by mapping a printer when I add my self to any of the groups.  No errors are reported at all.  I added a wscript.echo command to the beginning of the subroutine, however this comment is never echoed suggesting my subroutine sections are not working.
I know this is a big ask as you need to work this script out; I would very much appreciate the help so please could someone tell me where I have gone wrong?

See script bellow
------------------------------------------------------------------------------------------------------------------------------

Option explicit
'On error resume next
Dim wshNet
Dim ADSysInfo
Dim CurrentUser
Dim GroupMember
Dim strGroups
Dim a, b, c
Dim PCompPrinter
Dim PRoomPrinter
Dim ReceptionPrinter
Const PComp = "CN=Post Completion"
Const PRoom = "cn=Post Room"
Const Reception = "cn=Reception"

PCompPrinter = "\\Cs1\nclepostcomp"
PRoomPrinter = "\\Cs1\NCLE - Epson C3000 Colour Laser"
ReceptionPrinter = "\\Cs1\NCLE - RECEPTION HP LaserJet 1100"
Set wshNet = CreateObject("WScript.Network")
Set ADSysInfo = CreateObject("ADSystemInfo")
Set CurrentUser = GetObject("LDAP://" _
    & ADSysInfo.UserName)
strGroups = LCase(Join(CurrentUser.MemberOf))

Select Case GroupMember
        Case a = Instr(strGroups, PComp)
      PCompsub
        Case b = Instr(strGroups, PRoom)
      PRoomsub
        Case c = Instr(strGroups, Reception)
      Receptionsub
End Select

Sub PCompsub
wshNet.AddWindowsPrinterConnection PCompPrinter
wshNet.SetDefaultPrinter PCompPrinter
End Sub

Sub PRoomsub
wshNet.AddWindowsPrinterConnection PRoomPrinter
wshNet.SetDefaultPrinter PRoomPrinter
End Sub

Sub Receptionsub
wshNet.AddWindowsPrinterConnection ReceptionPrinter
wshNet.SetDefaultPrinter ReceptionPrinter
End Sub

-------------------------------------------------------------------------------------------------------------------------------------------------
0
Nael_Shahid
Asked:
Nael_Shahid
  • 3
  • 3
1 Solution
 
Chris DentPowerShell DeveloperCommented:

Your Case Statement is incorrect. It can't be used as you have it right now.

You would have to do:

If InStr(strGroups, PComp) Then
      PCompSub
ElseIf InStr(strGroups, PRoom) Then
      PRoomSub
ElseIf InStr(strGroups, Reception) Then
      ReceptionSub
End If

The Syntax for Case is as follows:

Select Case <Variant>
      Case "<Value 1>"
            <Statements>
      Case "<Value 2>"
            <Statements>
      Case Else
            <Statements>
End Select

In your original code you're expecting the Case statement to use a function to evaluate something as well so it'll never call the subroutines.

Chris
0
 
Nael_ShahidAuthor Commented:
Thanks Chris; I'll test this out and let you know.
0
 
Nael_ShahidAuthor Commented:
Hi Chris,

When I first amended this it still did not work; however when I removed "LCase" from "strGroups = LCase(Join(CurrentUser.MemberOf))" it did work.

I wrote this script with the aid of a book so I do not understand what "LCase" does etc...could you explain for me please?

Thanks,
Nael
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
Chris DentPowerShell DeveloperCommented:

LCase simply converts whatever you give it into lower case.

Instead of using LCase it would be better to change it a little like this:

If InStr(1, strGroups, PComp, VbTextCompare) Then
     PCompSub
ElseIf InStr(1, strGroups, PRoom, VbTextCompare) Then
     PRoomSub
ElseIf InStr(1, strGroups, Reception, VbTextCompare) Then
     ReceptionSub
End If

Then it would ignore the case of the letter when trying to do the match - by default it's case sensitive.

Chris
0
 
Nael_ShahidAuthor Commented:
Thanks
0
 
Chris DentPowerShell DeveloperCommented:

Pleasure.

Chris
0

Featured Post

New feature and membership benefit!

New feature! Upgrade and increase expert visibility of your issues with Priority Questions.

  • 3
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now