Solved

VB active directory logon script

Posted on 2006-07-20
6
247 Views
Last Modified: 2008-02-01
Hi,

Please could someone take a look at this logon script for me.  It is basically a logon script to set a users printer based on active directory group membership.
The script seems to run fine but does not do the requested action by mapping a printer when I add my self to any of the groups.  No errors are reported at all.  I added a wscript.echo command to the beginning of the subroutine, however this comment is never echoed suggesting my subroutine sections are not working.
I know this is a big ask as you need to work this script out; I would very much appreciate the help so please could someone tell me where I have gone wrong?

See script bellow
------------------------------------------------------------------------------------------------------------------------------

Option explicit
'On error resume next
Dim wshNet
Dim ADSysInfo
Dim CurrentUser
Dim GroupMember
Dim strGroups
Dim a, b, c
Dim PCompPrinter
Dim PRoomPrinter
Dim ReceptionPrinter
Const PComp = "CN=Post Completion"
Const PRoom = "cn=Post Room"
Const Reception = "cn=Reception"

PCompPrinter = "\\Cs1\nclepostcomp"
PRoomPrinter = "\\Cs1\NCLE - Epson C3000 Colour Laser"
ReceptionPrinter = "\\Cs1\NCLE - RECEPTION HP LaserJet 1100"
Set wshNet = CreateObject("WScript.Network")
Set ADSysInfo = CreateObject("ADSystemInfo")
Set CurrentUser = GetObject("LDAP://" _
    & ADSysInfo.UserName)
strGroups = LCase(Join(CurrentUser.MemberOf))

Select Case GroupMember
        Case a = Instr(strGroups, PComp)
      PCompsub
        Case b = Instr(strGroups, PRoom)
      PRoomsub
        Case c = Instr(strGroups, Reception)
      Receptionsub
End Select

Sub PCompsub
wshNet.AddWindowsPrinterConnection PCompPrinter
wshNet.SetDefaultPrinter PCompPrinter
End Sub

Sub PRoomsub
wshNet.AddWindowsPrinterConnection PRoomPrinter
wshNet.SetDefaultPrinter PRoomPrinter
End Sub

Sub Receptionsub
wshNet.AddWindowsPrinterConnection ReceptionPrinter
wshNet.SetDefaultPrinter ReceptionPrinter
End Sub

-------------------------------------------------------------------------------------------------------------------------------------------------
0
Comment
Question by:Nael_Shahid
  • 3
  • 3
6 Comments
 
LVL 70

Accepted Solution

by:
Chris Dent earned 500 total points
ID: 17147148

Your Case Statement is incorrect. It can't be used as you have it right now.

You would have to do:

If InStr(strGroups, PComp) Then
      PCompSub
ElseIf InStr(strGroups, PRoom) Then
      PRoomSub
ElseIf InStr(strGroups, Reception) Then
      ReceptionSub
End If

The Syntax for Case is as follows:

Select Case <Variant>
      Case "<Value 1>"
            <Statements>
      Case "<Value 2>"
            <Statements>
      Case Else
            <Statements>
End Select

In your original code you're expecting the Case statement to use a function to evaluate something as well so it'll never call the subroutines.

Chris
0
 

Author Comment

by:Nael_Shahid
ID: 17147323
Thanks Chris; I'll test this out and let you know.
0
 

Author Comment

by:Nael_Shahid
ID: 17147767
Hi Chris,

When I first amended this it still did not work; however when I removed "LCase" from "strGroups = LCase(Join(CurrentUser.MemberOf))" it did work.

I wrote this script with the aid of a book so I do not understand what "LCase" does etc...could you explain for me please?

Thanks,
Nael
0
Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
LVL 70

Expert Comment

by:Chris Dent
ID: 17152705

LCase simply converts whatever you give it into lower case.

Instead of using LCase it would be better to change it a little like this:

If InStr(1, strGroups, PComp, VbTextCompare) Then
     PCompSub
ElseIf InStr(1, strGroups, PRoom, VbTextCompare) Then
     PRoomSub
ElseIf InStr(1, strGroups, Reception, VbTextCompare) Then
     ReceptionSub
End If

Then it would ignore the case of the letter when trying to do the match - by default it's case sensitive.

Chris
0
 

Author Comment

by:Nael_Shahid
ID: 17152716
Thanks
0
 
LVL 70

Expert Comment

by:Chris Dent
ID: 17152762

Pleasure.

Chris
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

When designing a form there are several BorderStyles to choose from, all of which can be classified as either 'Fixed' or 'Sizable' and I'd guess that 'Fixed Single' or one of the other fixed types is the most popular choice. I assume it's the most p…
I was working on a PowerPoint add-in the other day and a client asked me "can you implement a feature which processes a chart when it's pasted into a slide from another deck?". It got me wondering how to hook into built-in ribbon events in Office.
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
Get people started with the process of using Access VBA to control Outlook using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Microsoft Outlook. Using automation, an Access applic…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question