Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

Solved

VBS script - help needed

Posted on 2006-07-20

1 solution

Medium Priority

887 Views

Last Modified: 2008-01-09

Hi,

Bit of a noob when it comes to this I'm afraid :-(

I have a script that pics up computer names (that are on the network) from a file (comps.txt) and creates another file with information (results.txt) about the PC's in the list.

What I want to end up with is a file with the computer name, followed by the serial number of the PC and the username of the person who's PC it is. I have found a script that will do most of this but I cannot integrate the code for finding the user name.

The script is as follows:

----------------------------------------------------------------------------------------------------------------

'START CODE
const FSO_READ_MODE = 1
const FSO_WRITE_MODE = 2
const COMPUTER_NAMES_FILE = "D:\comps.txt"
const RESULTS_FILE = "D:\results.txt" 'warning - will be overwritten each time script runs

Dim fso: Set fso = CreateObject("Scripting.FileSystemObject")

ReadFile(COMPUTER_NAMES_FILE)
Set fso = Nothing

function CheckSerial(ComputerName)
Dim System
Dim retVal
retVal=""
if Wscript.Arguments.Count > 0 then
sSystem=Wscript.Arguments(0)
end if
winmgmt1 = "winmgmts:{impersonationLevel=impersonate}!//"& ComputerName &""
Set SNSet = GetObject( winmgmt1 ).InstancesOf ("Win32_BIOS")
for each SN in SNSet
retVal = retVal & "The serial number for " & ComputerName & " is: " & SN.SerialNumber
Next
CheckSerial = retVal
end function

function ReadFile(sFilePath)
If fso.FileExists(sFilePath) then
'The file exists, so open it and output its contents
dim file: set file = fso.OpenTextFile(sFilePath, FSO_READ_MODE)
dim sLine
dim sResults: sResults = ""
Do While file.AtEndOfStream = False
sLine = file.ReadLine
sResults = sResults & CheckSerial(sLine) & vbcrlf
Loop
file.Close()
Set file = Nothing
WriteResults sResults
Else
'The file did not exist
msgbox sFilePath & " was not found."
End If
end function

sub WriteResults(sResults)
dim file: set file = fso.OpenTextFile(RESULTS_FILE, FSO_WRITE_MODE, true)
file.write(sResults)
file.Close()
Set file = Nothing
end sub
'END CODE

----------------------------------------------------------------------------------------------------------------

If anyone could shed any light on how I can get the user name into the text file as well I would be very greatful.

Thanks,

Giles

Comment

Question by:Gilesmp

[X]

Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

Help others & share knowledge
Earn cash & points
Learn & ask questions

Join The Community

11 Comments

LVL 7

Expert Comment

by:yotamsher

ID: 171491452006-07-20

what do you mean the user of this computer
currently logged on?
list of all users?

Yotam

LVL 5

Expert Comment

by:Dbergert

ID: 171494132006-07-20

http://www.computerperformance.co.uk/vbscript/wmi_who_logon.htm

LVL 5

Expert Comment

by:Isaac

ID: 171494162006-07-20

Do you have an example of what the contents of the file "comps.txt" looks like?

LVL 23

Expert Comment

by:gecko_au2003

ID: 171494222006-07-20

That just gets the currently logged on user ( how do you know if that user is the person who owns the pc or not ? ) I mean you can have more then one user per pc and just because you get a username at the time you run the script, doesnt mean to say that the person who is logged on there and then owns it, unless I am missing something.

You can enumerate all the user accounts on each machine but then how do you know who owns the machine ?

LVL 7

Expert Comment

by:yotamsher

ID: 171494392006-07-20

'the following will give you all the users of the machine

'START CODE
const FSO_READ_MODE = 1
const FSO_WRITE_MODE = 2
const COMPUTER_NAMES_FILE = "c:\comps.txt"
const RESULTS_FILE = "c:\results.txt" 'warning - will be overwritten each time script runs

Dim fso: Set fso = CreateObject("Scripting.FileSystemObject")

ReadFile(COMPUTER_NAMES_FILE)
Set fso = Nothing

function CheckSerial(ComputerName)
Dim System
Dim retVal
retVal=""
if Wscript.Arguments.Count > 0 then
sSystem=Wscript.Arguments(0)
end if
winmgmt1 = "winmgmts:{impersonationLevel=impersonate}!//"& ComputerName &""
Set SNSet = GetObject( winmgmt1 ).InstancesOf ("Win32_BIOS")
for each SN in SNSet
retVal = retVal & "The serial number for " & ComputerName & " is: " & SN.SerialNumber
Next
CheckSerial = retVal
end function

function CheckUsers(ComputerName)
Dim retVal
retVal=""
if Wscript.Arguments.Count > 0 then
sSystem=Wscript.Arguments(0)
end if
      Set objWMIService = GetObject("winmgmts:\\" & ComputerName & "\root\cimv2")
      Set colItems = objWMIService.ExecQuery("Select * from Win32_Account",,48)
      retVal = retVal & "The users of " & ComputerName & " are: "
      For Each objItem in colItems
            if objItem.SIDType = 1 then
              retVal = retVal & " , "& objItem.Name
            end if
      Next
      CheckSerial = retVal
end function

function ReadFile(sFilePath)
If fso.FileExists(sFilePath) then
'The file exists, so open it and output its contents
dim file: set file = fso.OpenTextFile(sFilePath, FSO_READ_MODE)
dim sLine
dim sResults: sResults = ""
Do While file.AtEndOfStream = False
sLine = file.ReadLine
sResults = sResults & CheckSerial(sLine) & CheckUsers(sLine) & vbcrlf
Loop
file.Close()
Set file = Nothing
WriteResults sResults
Else
'The file did not exist
msgbox sFilePath & " was not found."
End If
end function

sub WriteResults(sResults)
dim file: set file = fso.OpenTextFile(RESULTS_FILE, FSO_WRITE_MODE, true)
file.write(sResults)
file.Close()
Set file = Nothing
end sub
'END CODE

LVL 7

Expert Comment

by:yotamsher

ID: 171494562006-07-20

if you want to know who "owns" the machine, I guess you will have to create some methodology of your own:
something like a file called owner.txt which resides in some directory.

good luck Yotam

LVL 3

Author Comment

by:Gilesmp

ID: 171523362006-07-21

Yes, the username of the user currently logged on ... am I correct in saying this is what this script would give you?

------------------------
strComputer = "."
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2")
Set colCSItems = objWMIService.ExecQuery("SELECT * FROM Win32_ComputerSystem")
For Each objCSItem In colCSItems
WScript.Echo "User Name: " & objCSItem.UserName
Next
------------------------

The comps.txt file is just the name of each PC per line i.e.

computername1
computername2
computername3
etc.

------------------------

Thanks Yotam,

I tried that script, however, it came back with error:

Line: 41
Char: 6
Error: Illegal assignment: 'CheckSerial'
Code: 800A01F5
Source: Microsoft VBScript runtime error

Any ideas?

Thanks for all your help so far guys,

Giles

LVL 7

Expert Comment

by:yotamsher

ID: 171523872006-07-21

sorry my mistake
I had moved this between vbscript and jscript, and then mad a mistake in the returning from the function
line 41 which now shows:
CheckSerial = retVal
should be:
CheckUsers = retVal

Yotam

but I see that you want the currently logged on user, I'll post it soon

LVL 3

Author Comment

by:Gilesmp

ID: 171532322006-07-21

Great, that ammendment has made the script run fine now.

I eagerly await your next post :-)

Many thanks,

Giles

LVL 7

Accepted Solution

by:yotamsher

yotamsher earned 2000 total points

ID: 171564552006-07-21

'I hope this is what you need:

'Yotam
'START CODE
const FSO_READ_MODE = 1
const FSO_WRITE_MODE = 2
const COMPUTER_NAMES_FILE = "c:\comps.txt"
const RESULTS_FILE = "c:\results.txt" 'warning - will be overwritten each time script runs

Dim fso: Set fso = CreateObject("Scripting.FileSystemObject")

ReadFile(COMPUTER_NAMES_FILE)
Set fso = Nothing

function CheckSerial(ComputerName)
Dim System
Dim retVal
retVal=""
if Wscript.Arguments.Count > 0 then
sSystem=Wscript.Arguments(0)
end if

winmgmt1 = "winmgmts:{impersonationLevel=impersonate}!//"& ComputerName &""

Set SNSet = GetObject( winmgmt1 ).InstancesOf ("Win32_BIOS")
for each SN in SNSet
retVal = retVal & "The serial number for " & ComputerName & " is: " & SN.SerialNumber
Next
CheckSerial = retVal
end function

function CheckLoggedOn(ComputerName)
Dim retVal

retVal=""
if Wscript.Arguments.Count > 0 then
sSystem=Wscript.Arguments(0)
end if
winmgmt1 = "winmgmts:{impersonationLevel=impersonate}!//"& ComputerName &"\root\cimv2"
Set objWMIService = GetObject(winmgmt1)

Set colComputer = objWMIService.ExecQuery _
("Select * from Win32_ComputerSystem")
retVal = retVal & "Loggedon users of " & ComputerName & " are: "
For Each objComputer in colComputer
retVal = retVal & CRLF & objComputer.UserName
Next

CheckLoggedOn = retVal
end function

function ReadFile(sFilePath)
If fso.FileExists(sFilePath) then
'The file exists, so open it and output its contents
dim file: set file = fso.OpenTextFile(sFilePath, FSO_READ_MODE)
dim sLine
dim sResults: sResults = ""
Do While file.AtEndOfStream = False
sLine = file.ReadLine
sResults = sResults & CheckSerial(sLine) & vbcrlf & CheckLoggedOn(sLine) & vbcrlf
Loop
file.Close()
Set file = Nothing
WriteResults sResults
Else
'The file did not exist
msgbox sFilePath & " was not found."
End If
end function

sub WriteResults(sResults)
dim file: set file = fso.OpenTextFile(RESULTS_FILE, FSO_WRITE_MODE, true)
file.write(sResults)
file.Close()
Set file = Nothing
end sub
'END CODE

LVL 3

Author Comment

by:Gilesmp

ID: 171660172006-07-24

Brilliant - that works a charm

Thank you very much

Giles

Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Basics of an Android App – Activity and Layout

Article by: Navneet

In this post we will learn different types of Android Layout and some basics of an Android App.

Sign Language Translation Glove

Article by: Barjaa

The SignAloud Glove is capable of translating American Sign Language signs into text and audio.

Course summary and where to go from here

Video by: Dan

With the power of JIRA, there's an unlimited number of ways you can customize it, use it and benefit from it. With that in mind, there's bound to be things that I wasn't able to cover in this course. With this summary we'll look at some places to go…