Programming Practice adivce -- Tight Loops and New
Posted on 2006-10-24
Is this code inherently bad?
The datareader has about 30,000 rows. At this point, the Cls1 and Cls2 classes perform no operation other than Get and Set values. Ultimately SQL database updates will be done based upon Cls2Instance values.
The reason that I ask is that VS2005 truly yelled at me while running this in test mode. I didn't write down the error at the time but, in essence, it had to do with MDAs and running dangerously close to being out of memory. I watched the Task Manager while the app ran and, indeed, the available workstiaton memory shrunk at a good clip.
These instantiations are done in a very tight loop. But will loosen up after the complete code is in place. I'm assuming that the garbage collector can't keep up right now.
So the questions:
1. Should class instantiations be done like this?
2. Is there a way to programmaticly (spelling) dispose of the Class at the end of each loop?
I could just variables and update them upon each loop iteration but.... that seems inelegant. Each of the two classes has about 45 elements.
Dim Cls1Instance As New Cls1
' Assign Values
Dim Cls2Instance As New Cls2
' Assign Values from Cls1Instance
' Update SQL database with Cls2Instance values