Solved

Multiple constructors ? (exercise from Deitel's C++ Book)

Posted on 2006-10-25
12
564 Views
Last Modified: 2012-08-14

Hi,

I'm a novice working through the Deitel, C++ How to Program book.

I just finished reviewing the chapter on classes and I'm stuck on the following exercise:

 (Modifying Class GradeBook) Modify class GradeBook (Fig. 3.11–Fig. 3.12) as follows:
 a) Include a second string data member that represents the course instructor’s name.
 b) Provide a set function to change the instructor’s name and a get function to retrieve it.
 c) Modify the constructor to specify two parameters—one for the course name and one for the instructor’s name.
 d) Modify member function displayMessage such that it first outputs the welcome message and course name, then outputs “This course is presented by:” followed by the instructor’s name.
 Use your modified class in a test program that demonstrates the class’s new capabilities.
-----------------------------------------------------------------------------------------------------------------

I had success in (a) (b) but (c) is not working as expected.  I think its a syntax error in the constructor, any how here is the code I have:

gradebook.h

#include <string>
using std::string;

// GradeBook class definition
class GradeBook
{
public:
      GradeBook( string ); // constructor that initializes courseName
      void setCourseName( string ); // function that sets the course name
      string getCourseName(); // function that gets the course name
      void displayMessage(); // function that displays a welcome message

      void setInstructorName( string );
      string getInstructorName();

private:
      string courseName; // course name for this gradebook
      string instructorName;
};


gradebook.cpp

#include <iostream>
using std::cout;
using std::endl;

#include "gradebook.h"

// constructor initializes courseName with string supplied as argument
GradeBook::GradeBook( string name )
{
      setCourseName( name );
      setInstructorName (name );

}

// function to set the course name
void GradeBook::setCourseName( string name )
{
      if (name.length() <= 5)
            courseName = name;

      if (name.length() > 5)
      {
            courseName = name.substr(0, 5);

            cout << "Name \ " << name << "\ exceeds maximum length (5).\n"
             << "Limiting courseName to first 5 characters.\n" << endl;
      } //end if statement
}

// function to get the course name
string GradeBook::getCourseName()
{
      return courseName;
}

//display a welcome message to the gradebook user
void GradeBook::displayMessage()
{
      // call getCourseName to get the courseName
      cout << "Welcome to the grade book for\n" << getCourseName()
            << "!" << endl;
}

void GradeBook::setInstructorName( string name )
{
      instructorName = name;
}

string GradeBook::getInstructorName()
{
      return instructorName;
}

lesson03.cpp

#include <iostream>
using std::cout;
using std::endl;

#include "GradeBook.h"

int main()
{
      GradeBook gradebook1( "12345" );
      GradeBook gradebook2( "654321" "bob" );


      cout << "gradebook1 created for course: " << gradebook1.getCourseName()
            << "\ngradebook2 created for course: " << gradebook2.getCourseName()
            << " and the instructor is called " << gradebook2.getInstructorName()
            << endl;

      return 0;
}

Thanks for any guidance.
0
Comment
Question by:andyw27
  • 5
  • 3
12 Comments
 
LVL 30

Accepted Solution

by:
Axter earned 250 total points
ID: 17807319
Hi andyw27,
>  GradeBook gradebook2( "654321" "bob" );

The above line should have a comma between the two arguments:
GradeBook gradebook2( "654321", "bob" );


David Maisonave (Axter)
Cheers!
0
 
LVL 30

Expert Comment

by:Axter
ID: 17807334
andyw27,
> GradeBook::GradeBook( string name )

The above constructor needs to be given two arguments.
GradeBook::GradeBook( string CourseName, string InstructorName ) //Always give a well descriptive name for your arguments.  Name really doesn't say much about an argument.


David Maisonave (Axter)
0
 
LVL 30

Expert Comment

by:Axter
ID: 17807344
andyw27,
> class GradeBook
> {
> public:
>      GradeBook( string );

Don't forget to also change your head (class declaration.
class GradeBook
{
public:
     GradeBook(  string CourseName, string InstructorName );

Argument names are not required in function declaration, but it's good practice to always give argument names, because it's easier for other developers to determine what type of argument they need to pass.    

David Maisonave (Axter)
0
 
LVL 30

Expert Comment

by:Axter
ID: 17807358
andyw27,
> using std::string;

You should avoid putting using clause in a header.
Instead, use fully qualified names for all std objects in the header.

David Maisonave (Axter)
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 

Author Comment

by:andyw27
ID: 17807363

David - thanks for response.

I changed as suggested, still getting an error.  What should the variables name by for the get and set for instructor, at the moment they are:

void GradeBook::setInstructorName( string iname )
{
      instructorName = iname;
}

string GradeBook::getInstructorName()
{
      return instructorName;
}

-------------------------

// constructor initializes courseName with string supplied as argument
GradeBook::GradeBook( string name, string iname )
{
      setCourseName( name );
      setInstructorName (iname );

}
0
 

Author Comment

by:andyw27
ID: 17807378

ah, you third post solved the problem I was getting.
0
 
LVL 30

Expert Comment

by:Axter
ID: 17807384
>>What should the variables name by for the get and set for instructor, at the moment they are:
If you made your member variables have an m_ prefix (as in hungarian notation), then you could do the following:

void GradeBook::setInstructorName( string instructorName)
{
     m_instructorName = instructorName;
}

>>I changed as suggested, still getting an error.
Please post the exact error you're getting.
0
 

Author Comment

by:andyw27
ID: 17807388

One other thing I noticed.

If I have a constructor that contains two parameters, in this case:
      setCourseName( name );
      setInstructorName (iname );

When I create an object do I have to always set both of these, for example I tried the following:

      cout << "gradebook1 created for course: " << gradebook1.getCourseName()
            << "\ngradebook2 created for course: " << gradebook2.getCourseName()
            << " and the instructor is called " << gradebook2.getInstructorName()

I didn't want to define a value for instructorName for the object gradebook1?
0
 
LVL 17

Assisted Solution

by:rstaveley
rstaveley earned 250 total points
ID: 17807575
You can have a default value for a constructor parameter just like any function.

class GradeBook {
    const string courseName;
    const string instructorName;
public:
    GradeBook(const string& courseName,const string& instructorName = "");
    // ..
};

GradeBook::GradeBook(const string& courseName,const string& instructorName) : courseName(courseName),instructorName(instructorName)
{
}

int main()
{
    GradeBook latin("Latin","Mr Chips");
    GradeBook biology("Biology");
}
0

Featured Post

6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

Join & Write a Comment

When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generat…
Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now