Solved

C++ For Loop

Posted on 2006-10-26
6
201 Views
Last Modified: 2010-04-01
Hi experts,


I have a vector, vectorOfRadios of Radio objects with each object containing one boolean member variable, called IsRadioOn. I loop through each Radio in vectorOfRadios starting at the first Radio and looking ahead to the next radio i.e. vectorOfRadios.at(n+1) and check if the radios are either of the following options and based on those options call different functions:

for (int n = 0; n < vectorOfRadios.size()-1; n++)
{
        bool bFirstIsOn = vectorOfRadios.at(n).IsRadioOn;
        bool bSecondIsOn = vectorOfRadios.at(n+1).IsRadioOn;

        for (int j = 0; j < size; ++j)
        {
            int x = 0;
            int y = 0;
            if ((bFirstIsOn == true) && (bSecondIsOn == true))
            {
              // A, B, C, D and E are functions that return an integer.
                 x = A();
                 y = B();
            }
            else if  ((bFirstIsOn == true && (bSecondIsOn == false))
            {
                x = A();
                y = D();
            }
            else if  ((bFirstIsOn == false) && (bSecondIsOn == true))
           {
               x = B();
               y = C();
            }
           else if  ((bFirstIsOn == false) && (bSecondIsOn == false))
           {
               x = B();
               y = D();
           }
        
            // Do other stuff here using variables x and y
            // ...
      }
}

Is there a more elegant method for doing the above?

Thank you,
j.
0
Comment
Question by:XPUSR
  • 3
6 Comments
 
LVL 19

Accepted Solution

by:
BrianGEFF719 earned 23 total points
ID: 17815878
if (bFirstIsOn == true)
 x = A();
else
 x = B();

if (bSecondIsOn == false)
 y = D();
else
{
 if(bFirstIsOn == true)
  y = B();
 else
  y = C();
}
0
 
LVL 19

Expert Comment

by:BrianGEFF719
ID: 17815888
or you could try with the conditional iif.

x = (bFirstIsOn) ? A() : B();
y = (!bSecondIsOn) ? D() :;
y = (!bSecondIsOn && bFirstIsOn) ? B() : C();

0
 
LVL 19

Expert Comment

by:BrianGEFF719
ID: 17815899
Sorry try this:


x = (bFirstIsOn) ? A() : B();
y = (!bSecondIsOn) ? D() : 0;
y = (bSecondIsOn && bFirstIsOn) ? B() : C();


-Brian
0
 
LVL 4

Assisted Solution

by:Raymun
Raymun earned 22 total points
ID: 17953688
An alternative:

if( bSecondIsOn ) {
      if( bFirstIsOn ) {
            x = A();
            y = B();
      }
      else {
            x = B();
            y = C();
      }
}
else {
      y = D();
}

Both are correct. BrianGeFF719's is more concise but mine is more versatile.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
In days of old, returning something by value from a function in C++ was necessarily avoided because it would, invariably, involve one or even two copies of the object being created and potentially costly calls to a copy-constructor and destructor. A…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

863 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now