Solved

C++ For Loop

Posted on 2006-10-26
6
204 Views
Last Modified: 2010-04-01
Hi experts,


I have a vector, vectorOfRadios of Radio objects with each object containing one boolean member variable, called IsRadioOn. I loop through each Radio in vectorOfRadios starting at the first Radio and looking ahead to the next radio i.e. vectorOfRadios.at(n+1) and check if the radios are either of the following options and based on those options call different functions:

for (int n = 0; n < vectorOfRadios.size()-1; n++)
{
        bool bFirstIsOn = vectorOfRadios.at(n).IsRadioOn;
        bool bSecondIsOn = vectorOfRadios.at(n+1).IsRadioOn;

        for (int j = 0; j < size; ++j)
        {
            int x = 0;
            int y = 0;
            if ((bFirstIsOn == true) && (bSecondIsOn == true))
            {
              // A, B, C, D and E are functions that return an integer.
                 x = A();
                 y = B();
            }
            else if  ((bFirstIsOn == true && (bSecondIsOn == false))
            {
                x = A();
                y = D();
            }
            else if  ((bFirstIsOn == false) && (bSecondIsOn == true))
           {
               x = B();
               y = C();
            }
           else if  ((bFirstIsOn == false) && (bSecondIsOn == false))
           {
               x = B();
               y = D();
           }
        
            // Do other stuff here using variables x and y
            // ...
      }
}

Is there a more elegant method for doing the above?

Thank you,
j.
0
Comment
Question by:XPUSR
  • 3
6 Comments
 
LVL 19

Accepted Solution

by:
BrianGEFF719 earned 23 total points
ID: 17815878
if (bFirstIsOn == true)
 x = A();
else
 x = B();

if (bSecondIsOn == false)
 y = D();
else
{
 if(bFirstIsOn == true)
  y = B();
 else
  y = C();
}
0
 
LVL 19

Expert Comment

by:BrianGEFF719
ID: 17815888
or you could try with the conditional iif.

x = (bFirstIsOn) ? A() : B();
y = (!bSecondIsOn) ? D() :;
y = (!bSecondIsOn && bFirstIsOn) ? B() : C();

0
 
LVL 19

Expert Comment

by:BrianGEFF719
ID: 17815899
Sorry try this:


x = (bFirstIsOn) ? A() : B();
y = (!bSecondIsOn) ? D() : 0;
y = (bSecondIsOn && bFirstIsOn) ? B() : C();


-Brian
0
 
LVL 4

Assisted Solution

by:Raymun
Raymun earned 22 total points
ID: 17953688
An alternative:

if( bSecondIsOn ) {
      if( bFirstIsOn ) {
            x = A();
            y = B();
      }
      else {
            x = B();
            y = C();
      }
}
else {
      y = D();
}

Both are correct. BrianGeFF719's is more concise but mine is more versatile.
0

Featured Post

Secure Your Active Directory - April 20, 2017

Active Directory plays a critical role in your company’s IT infrastructure and keeping it secure in today’s hacker-infested world is a must.
Microsoft published 300+ pages of guidance, but who has the time, money, and resources to implement? Register now to find an easier way.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generat…
What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. …
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

735 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question