Solved

C++ - Why does my class constructor cause this error?  'Point3' : no copy constructor available or copy constructor is declared 'explicit'

Posted on 2006-10-29
4
259 Views
Last Modified: 2010-04-01
Hi,

I got this strange error the other day. When I isolated it, (made an empty project with nothing else in it), I found out that it only comes when using the following (Point3) class constructor.

a) If I comment out the constructor "Point3(Point3 &b) {...}" , then "myVector.push_back(p3);" works fine. Otherwise I get this error.

Im very puzzled why this is happening. Any ideas?

Thank you.

************ Main.cpp***********
#include <iostream>
#include <vector>
#include "Point3.h"

using namespace std;

void main(int argc, char** argv)
{
      vector<Point3> myVector;
      Point3 p3;
      myVector.push_back(p3);  
}
******************************
************ Point3.cpp***********
#ifndef      point3_h
#define point3_h

class Point3
{
      public:
            Point3(){ x = 0.0f;y = 0.0f;z = 0.0f;}                    // constructor 1
            // Point3(Point3 &b) {x = b.x; y=b.y; z=b.z;}    // constructor 2 - ONLY COMPILES IF THIS LINE IS COMMENTED OUT !!
            float x,y,z;
};

#endif
******************************
0
Comment
Question by:Gsteingr
  • 2
  • 2
4 Comments
 

Author Comment

by:Gsteingr
Comment Utility

Sorry,

************ Point3.cpp***********

should be

************ Point3.h***********
0
 
LVL 48

Expert Comment

by:AlexFM
Comment Utility
vector class internally uses copy constructor to create it's own copy of class instance. I confess that I don't understand completely C++ explicit constructors mumbo-jumbo, but at least I know simple fix for this problem:

    Point3(const Point3 &b)            // add const keyword
    {x = b.x; y=b.y; z=b.z;}

I know what to do, but I don't know why does this happen. Hopefully, somebody else can explain this :)
0
 

Author Comment

by:Gsteingr
Comment Utility

Wow, it worked. Thanks a lot.

Does anybody know how the Vector is stored in memory. Would the Vector stored these two the same way:

Point3 p1;                                // Created on the Stack
Point3 *p2 = new Point3();       // Created on the Heap

myVector.push_back(p1);
myVector.push_back(*p3);
0
 
LVL 48

Accepted Solution

by:
AlexFM earned 500 total points
Comment Utility
vector<T> stores objects of type T in continous memory block, like plain array. When new element is added and currect vector capacity is not enough, new array is allocated, all existing elements are copied to it, and new element is added. Old array is released.
vector creates it's own copy of T class, using copy constructor for this. In your sample, both for p1 and p2, vector creates new Point3 object - this is the same case for vector.
Simple types like int, char and simple structures like Point3 are usually kept in vector by value. Complex classes are usually kept by reference:

vector<ComplexClass*> v;
ComplexClass* p = new ComplexClass();
v.Add(p);

In this case, allocating and releasing of class instances is caller's responsibility. Vector only keeps class pointers which are actually 32-bit numbers. Caller allocates class instances on the heap, and releases them when element is removed from vector, or vector is cleared - vector doesn't do this itself.
0

Featured Post

Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

Join & Write a Comment

Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
Introduction This article is the first in a series of articles about the C/C++ Visual Studio Express debugger.  It provides a quick start guide in using the debugger. Part 2 focuses on additional topics in breakpoints.  Lastly, Part 3 focuses on th…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

9 Experts available now in Live!

Get 1:1 Help Now