Solved

more php reference problems

Posted on 2006-10-30
9
185 Views
Last Modified: 2008-03-04
The values in a custom object i have dont seem to be being accessed correctly and i think it is because i am not using references correctly in php (I am new to php).  Below is my code with comments showing the odd output.  Below the code is the output (read the description above the output to see what is wrong with it).

    function controlOutput(){
        //pull all the unique key/display values from tablename
        $output="";
        $controlName=$this->parentColumn->getControlName();
       
        $output=$output."<select name=\"".$controlName."\" id=\"".$controlName."\">";
       
        if($this->strKeyColumn!=""){
            $result=$this->queryDatabase();
            while($row = mysql_fetch_row($result))
            {
                $id = $row[0];
                $display = $row[1];
                $output=$output."<option value=\"$id\"";
                echo "Test2? - \$this->parentColumn->strCurValue={$this->parentColumn->strCurValue}<br>\n"; // <-this prints out blank
                //echo "\$id=$id\n";
                if($this->parentColumn->strCurValue==$id) $output=$output." selected";
                $output=$output.">$display</option>\n";
            }
            $output=$output."</select>";
        }
        return $output;
    } //end  function controlOutput()

function editOutput(){
        //pull all the unique key/display values from tablename
        $output="";
        $controlName="frm_".$this->strTableName;
       
        $output=$output."<form name=\"".$controlName."\" id=\"".$controlName."\" action=\"".$_SERVER['SCRIPT_NAME']."\" method=\"POST\">";
        $output=$output."<table cellpadding=0 cellspacing=0 border=0 align=left>";
       
        foreach ($this->arrColumns as $i => $value){
            $output=$output."<tr>";
            $output=$output."<td nowrap style=\"padding-bottom:3px\">".$value->descriptionOutput() . "</td>";
            $output=$output."<td nowrap style=\"padding-left:5px;padding-bottom:3px\">".$value->controlOutput() . "</td>";
            $output=$output."</td></tr>\n";
        }
       
        $output=$output."</table><br clear=\"left\" />";
       
        foreach ($this->arrHiddenFormVariables as $i => $value){
            $output=$output."<input type=\"hidden\" name=\"{$value[0]}\" id=\"{$value[0]}\" value=\"{$value[1]}\">";
        }
        $output=$output."<br /><input type=\"submit\" value=\"Save Changes\">";
        $output=$output."</form>";
       
        return $output;
    } // end function editOutput

      $objCurTable->strIdColumnValue=$curID;
      if(strtolower($curAction=="edit")){
           
        $objCurTable->updateFromDatabase();
         
        foreach($objCurTable->arrColumns as $foreachCurColumn){
            echo "Test? - \$foreachCurColumn->strCurValue{$foreachCurColumn->strDisplayText}={$foreachCurColumn->strCurValue}<br />\n";  <--actually holds the value
        }
      }

echo $objCurTable->editOutput();
---------------------------------------------------------------------------
The following is output generated from the code above.  Notice that during "Test2" the columns have values but during "Test" they do not:

Test? - $foreachCurColumn->strCurValueProgram Name=Example Entry
Test? - $foreachCurColumn->strCurValueProgram Description=
Test? - $foreachCurColumn->strCurValueProgram Website=
Test? - $foreachCurColumn->strCurValueThis program is also an instition=1
Test? - $foreachCurColumn->strCurValueProgram institution=376

Test2? - $this->parentColumn->strCurValue=
^^ The above line is repeated for each record in $result (in the controlOutput function)^^

Does anyone know why I am seeing this output and what changes to make so it see the strCurValues when it runs Test2 (in addition to "Test?")?
0
Comment
Question by:dave4dl
  • 5
  • 4
9 Comments
 
LVL 49

Expert Comment

by:Roonaan
ID: 17835909
Where do you set the $this->parentColumn property?

-r-
0
 
LVL 15

Author Comment

by:dave4dl
ID: 17835962
Woops, i forgot to tell you where the parentColumn come from:

$this->objLink=&new clsLink($this);

    function clsLink(&$inputParent,$inputDisplayColumn=null,$inputKeyColumn=null, $inputTableName=null) {
        $this->strDisplayColumn=$inputDisplayColumn;
        $this->strKeyColumn=$inputKeyColumn;
        $this->strTableName=$inputTableName;
        $this->parentColumn=$inputParent;
    }
0
 
LVL 15

Author Comment

by:dave4dl
ID: 17835968
Man you reply fast!
0
 
LVL 49

Expert Comment

by:Roonaan
ID: 17836015
Try:

    function clsLink(&$inputParent,$inputDisplayColumn=null,$inputKeyColumn=null, $inputTableName=null) {
        $this->strDisplayColumn=$inputDisplayColumn;
        $this->strKeyColumn=$inputKeyColumn;
        $this->strTableName=$inputTableName;
        $this->parentColumn=&$inputParent;
    }

-r-
0
Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

 
LVL 15

Author Comment

by:dave4dl
ID: 17836073
Thanks for the replies Roonaan,  I really appreciate your help today!

I changed the line that says "$this->parentColumn=$inputParent;" to "$this->parentColumn=&$inputParent;"
but it still prints out "Test2? - $this->parentColumn->strCurValue=" a number of times.
0
 
LVL 49

Accepted Solution

by:
Roonaan earned 500 total points
ID: 17836117
Try changing the foreach in editOutput from
        foreach ($this->arrColumns as $i => $value){
            $output=$output."<tr>";
            $output=$output."<td nowrap style=\"padding-bottom:3px\">".$value->descriptionOutput() . "</td>";
            $output=$output."<td nowrap style=\"padding-left:5px;padding-bottom:3px\">".$value->controlOutput() . "</td>";
            $output=$output."</td></tr>\n";
        }

To:

        foreach ($this->arrColumns as $i => $value){
            $value = &$this->arrColumns[$i]; // Foreach makes a copy, so we need to get a proper reference
            $output=$output."<tr>";
            $output=$output."<td nowrap style=\"padding-bottom:3px\">".$value->descriptionOutput() . "</td>";
            $output=$output."<td nowrap style=\"padding-left:5px;padding-bottom:3px\">".$value->controlOutput() . "</td>";
            $output=$output."</td></tr>\n";
        }


Or an alternative code:

reset($this->arrColumns);
while(list($i, $value) = each($this->arrColumns)) {
            $output=$output."<tr>";
            $output=$output."<td nowrap style=\"padding-bottom:3px\">".$value->descriptionOutput() . "</td>";
            $output=$output."<td nowrap style=\"padding-left:5px;padding-bottom:3px\">".$value->controlOutput() . "</td>";
            $output=$output."</td></tr>\n";
}

Foreach copies an array before iterating. while/each uses the actual array.

-r-
0
 
LVL 15

Author Comment

by:dave4dl
ID: 17836574
I tried the "while" loop since i didn't know how those behaved differently before but I had no luck.  I expect I am probably not giving you some critical piece of info so i uploaded my php files to https://filedb.experts-exchange.com/incoming/ee-stuff/1278-phpFiles.zip if you dont mind taking a look at the real thing (instead of the snippets on EE).

AddEditItem.php creates a table object (defined in clsTable.php) which has an array of column objects (defined in clsColumn.php) which contains a link object (defined in clsLink.php).

The values stored in the column object seem to persist but accessing it from the (child) link seems to be failing.

So i think the references in one direction and/or the other from the link are not working right.

What do you think?
0
 
LVL 49

Expert Comment

by:Roonaan
ID: 17836738
Final resort might be to implement an explicit reference:

$this->objLink->parentColumn = &$this;

-r-
0
 
LVL 15

Author Comment

by:dave4dl
ID: 17903129
Thanks for your help roonaan.  I ended up just declaring another variable in the child class so that i wouldnt need a reference to the parent (even though it creates a duplicate).
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Suggested Solutions

Introduction HTML checkboxes provide the perfect way for a web developer to receive client input when the client's options might be none, one or many.  But the PHP code for processing the checkboxes can be confusing at first.  What if a checkbox is…
Developers of all skill levels should learn to use current best practices when developing websites. However many developers, new and old, fall into the trap of using deprecated features because this is what so many tutorials and books tell them to u…
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now