Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

Access violation when deleting CFrameWnd

Posted on 2006-11-02
9
Medium Priority
?
686 Views
Last Modified: 2013-11-20
Ah hello.

I have the following code in a handler for a button on a dialog:

void CDialogAppDlg::OnBnClickedButton1()
{
      if ( m_pFrameWnd )
      {
            m_pFrameWnd->DestroyWindow();
            delete m_pFrameWnd;
      }

      m_pFrameWnd = new CFrameWnd();
      m_pFrameWnd->Create ( NULL, _T("Frame Window") );
      m_pFrameWnd->UpdateWindow();
      m_pFrameWnd->ShowWindow ( SW_SHOW );

}

Assume

CFrameWnd* m_pFrameWnd;

Now, I can click the button once and create the window, but if I click it again I get access violation when calling

m_pFrameWnd->DestroyWindow()

Strangely enough, if I just create the window once, then close the app, I get no memory leaks, which I would expect from

      m_pFrameWnd = new CFrameWnd();

What is going on ?

TIA
0
Comment
Question by:mrwad99
  • 5
  • 4
9 Comments
 
LVL 48

Accepted Solution

by:
AlexFM earned 500 total points
ID: 17857559
CFrameWnd detetes itself in PostNCDestroy, it is enough to call DestroyWindow.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857571
>> CFrameWnd detetes itself in PostNCDestroy

OK so that explains why I get no memory leaks

>> it is enough to call DestroyWindow.

I cannot call DestroyWindow, that is what crashes.  Or are you saying I don't need to ?

Thanks.
0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857611
How exactly does it crash?
Try this:

m_pFrameWnd->SendMessage(WM_CLOSE, 0, 0);
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 19

Author Comment

by:mrwad99
ID: 17857635
Thanks.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857638
>> How exactly does it crash?

Not sure what you were getting at there.  Can you elaborate ?

0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857724
Code line, message etc. - as usual. But I think it is enough to remove delete m_pFrameWnd line.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857825
>> But I think it is enough to remove delete m_pFrameWnd line.

I have stepped though the code and found that I don't even need the

m_pFrameWnd->DestroyWindow(), as this gets called when I close the window via the 'X' button.  But I would need to call this if the user closes the dialog before the main window, otherwise I would get leaks.

Interestingly so, when I do close the dialog with the frame window still active, the frame window does go away, and I get the leak on

m_pFrameWnd = new CFrameWnd();

detected.

I assume the OS destroys the CFrameWnd, but still, I only get one call into

CWnd::DestroyWindow()

which is called for the modal dialog.  Not for the CFrameWnd...

Do you know why this is ?

(Sorry to go on after I have closed this, but I read your last comment a bit late)
0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857959
When you close dialog, application exits immediately. In this case possibly CFrameWnd is not deleted properly, because OnNCDestroy is not called, and there is memory leak. It is possible to debug this or read MFC code, but closing frame when dialog is closed fixes this problem in any case.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17858057
Thanks again :o)
0

Featured Post

[Webinar] Cloud and Mobile-First Strategy

Maybe you’ve fully adopted the cloud since the beginning. Or maybe you started with on-prem resources but are pursuing a “cloud and mobile first” strategy. Getting to that end state has its challenges. Discover how to build out a 100% cloud and mobile IT strategy in this webinar.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: Finishing the grid – keyboard support for arrow keys to manoeuvre, entering the numbers.  The PreTranslateMessage function is to be used to intercept and respond to keyboard events. Continuing from the fourth article about sudoku. …
Ready to get certified? Check out some courses that help you prepare for third-party exams.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
How to fix incompatible JVM issue while installing Eclipse While installing Eclipse in windows, got one error like above and unable to proceed with the installation. This video describes how to successfully install Eclipse. How to solve incompa…

972 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question