Solved

Access violation when deleting CFrameWnd

Posted on 2006-11-02
9
628 Views
Last Modified: 2013-11-20
Ah hello.

I have the following code in a handler for a button on a dialog:

void CDialogAppDlg::OnBnClickedButton1()
{
      if ( m_pFrameWnd )
      {
            m_pFrameWnd->DestroyWindow();
            delete m_pFrameWnd;
      }

      m_pFrameWnd = new CFrameWnd();
      m_pFrameWnd->Create ( NULL, _T("Frame Window") );
      m_pFrameWnd->UpdateWindow();
      m_pFrameWnd->ShowWindow ( SW_SHOW );

}

Assume

CFrameWnd* m_pFrameWnd;

Now, I can click the button once and create the window, but if I click it again I get access violation when calling

m_pFrameWnd->DestroyWindow()

Strangely enough, if I just create the window once, then close the app, I get no memory leaks, which I would expect from

      m_pFrameWnd = new CFrameWnd();

What is going on ?

TIA
0
Comment
Question by:mrwad99
  • 5
  • 4
9 Comments
 
LVL 48

Accepted Solution

by:
AlexFM earned 125 total points
ID: 17857559
CFrameWnd detetes itself in PostNCDestroy, it is enough to call DestroyWindow.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857571
>> CFrameWnd detetes itself in PostNCDestroy

OK so that explains why I get no memory leaks

>> it is enough to call DestroyWindow.

I cannot call DestroyWindow, that is what crashes.  Or are you saying I don't need to ?

Thanks.
0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857611
How exactly does it crash?
Try this:

m_pFrameWnd->SendMessage(WM_CLOSE, 0, 0);
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857635
Thanks.
0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 19

Author Comment

by:mrwad99
ID: 17857638
>> How exactly does it crash?

Not sure what you were getting at there.  Can you elaborate ?

0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857724
Code line, message etc. - as usual. But I think it is enough to remove delete m_pFrameWnd line.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17857825
>> But I think it is enough to remove delete m_pFrameWnd line.

I have stepped though the code and found that I don't even need the

m_pFrameWnd->DestroyWindow(), as this gets called when I close the window via the 'X' button.  But I would need to call this if the user closes the dialog before the main window, otherwise I would get leaks.

Interestingly so, when I do close the dialog with the frame window still active, the frame window does go away, and I get the leak on

m_pFrameWnd = new CFrameWnd();

detected.

I assume the OS destroys the CFrameWnd, but still, I only get one call into

CWnd::DestroyWindow()

which is called for the modal dialog.  Not for the CFrameWnd...

Do you know why this is ?

(Sorry to go on after I have closed this, but I read your last comment a bit late)
0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17857959
When you close dialog, application exits immediately. In this case possibly CFrameWnd is not deleted properly, because OnNCDestroy is not called, and there is memory leak. It is possible to debug this or read MFC code, but closing frame when dialog is closed fixes this problem in any case.
0
 
LVL 19

Author Comment

by:mrwad99
ID: 17858057
Thanks again :o)
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
function returning CString in a regular win32 DLL 8 147
repeateFront java challenge 31 87
ShiftLeft challenge 21 66
sumHeights  challenge 17 60
Introduction: Dynamic window placements and drawing on a form, simple usage of windows registry as a storage place for information. Continuing from the first article about sudoku.  There we have designed the application and put a lot of user int…
Introduction: Load and Save to file, Document-View interaction inside the SDI. Continuing from the second article about sudoku.   Open the project in visual studio. From the class view select CSudokuDoc and double click to open the header …
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now