Experts Exchange connects you with the people and services you need so you can get back to work.

optimize a Preg_match rule

I made this script to get the url and extract the value of the info variable. It works great, but I need to know if there is a better way to rewrite this to be a smaller amount of code. I think it is quite bulky looking.

It can be tested by simply using a url like this:
http://www.domain.com/somepage.ext?info=testdata&blah=moretests

It should only echo: testdata

$s = preg_match("/\\?info=(.*)([&])/i", $_SERVER['REQUEST_URI'], $matches);
      if ($s !== false)
            {
            $tmp = str_replace('&', '', $matches[0]);
            echo $info = str_replace('?info=', '', $tmp);
            }

ray-solomon

Asked: 2006-11-03

Advertise Here

1 Solution

LVL 19

VoteyDiscipleCommented: 2006-11-03

I'd suggest using the parse_url() method to get partway there.

$pieces = parse_url($url);
preg_match('/[&?]info=([^&]+)/', $pieces['query'], $match);
echo $match[1];

LVL 10

ray-solomonAuthor Commented: 2006-11-03

I get this error:

Notice: Undefined offset: 1 in....

I have php 5 with register_globals=off if that helps.

LVL 10

ray-solomonAuthor Commented: 2006-11-03

Here is what is contained in the parse_url array besides the path i modified

Array
(
[path] => /whatever/whatever......
[query] => info=testdata&blah=moretests
)

LVL 19

VoteyDiscipleCommented: 2006-11-03

Whoops; I gave half of one solution and half of another. I was thinking that info would come either after a ? or after an & but of course parse_url() doesn't return the ?

Let's make it:

preg_match(/(^|&)info=([^&]+)/', $pieces['query'], $match);
echo $match[2];

(Noting that I added a set of parens at the beginning so it's now $match[2], not [1].

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

optimize a Preg_match rule

Join & Write a Comment Already a member? Login.

Featured Post