Solved

Magic Square C#

Posted on 2006-11-05
2
3,825 Views
Last Modified: 2012-06-22
I am writing a Magic Square program that finds all the possible combinations of 1 to 9.  I wrote the recursive part of it but it seems to just be going on forever.  I want to print out all the possible ways of 1 to 9 without any repetitions.  Is this right?
using System;

namespace ConsoleApplication4
{
      class Class1
      {
            [STAThread]
            static void Main(string[] args)
            {
                  int n=1;
                  Magic(n);
            }

            public static void Magic(int n)
            {
                  int[] A = new int[10];
                  int[] B = new int[10];

                  for(int i = 1; i <= 9; i++)
                  {
                        if(B[i] == 0) // if i is free
                        {
                              B[i]=1;
                              A[n]=i;

                              if(n<9)
                              {
                                    Magic(n+1);//recurse
                              }
                              else
                              {
                                    TestMagic();//at the end
                              }

                              B[i]=0;
                        }
                        Console.Write(A[n]);
                  }
            }

            public static void TestMagic()
            {

            }
      }
}
0
Comment
Question by:jmkotman
2 Comments
 
LVL 16

Accepted Solution

by:
muzzy2003 earned 500 total points
ID: 17877666
No, this code gets in an infinite loop. Try something like this:

namespace ConsoleApplication
{
    class Class1
    {
        static int[] A = new int[9];

        [STAThread]
        static void Main(string[] args)
        {
            for (int i = 0; i < 9; i++)
            {
                Array.Clear(A, 0, 9);
                A[0] = i + 1;
                Magic(1);
            }
        }

        public static void Magic(int n)
        {
            for (int i = 0; i < 9; i++)
            {
                bool newNumber = true;
                for (int j = 0; j < n; j++)
                {
                    if (A[j] == i + 1)
                    {
                        newNumber = false;
                        break;
                    }
                }
                if (newNumber)
                {
                    A[n] = i + 1;
                    if (n == 8)
                        Print();
                    else
                        Magic(n + 1);
                }
            }
        }
       
        private static void Print()
        {
            Console.WriteLine("{0}{1}{2}{3}{4}{5}{6}{7}{8}", A[0], A[1], A[2], A[3], A[4], A[5], A[6], A[7], A[8]);
        }
    }
}
0
 
LVL 6

Expert Comment

by:_iskywalker_
ID: 17880013
you could do what muzzy2003;
or just exchange this part:
          public static void Magic(int n)
          {
         static      int[] A = new int[10];
          static     int[] B = new int[10];

               for(int i = n; i <= 9; i++)
               {

The problem is that the static makes the number remember they were already used, and the i=n makes the n has a better validity, it will
stop as soon as n=9, and will not go depper and depper, even if n is bigger then 9.
I didnt understand why you set again B[i]=0; it will then go forever.
0

Featured Post

NAS Cloud Backup Strategies

This article explains backup scenarios when using network storage. We review the so-called “3-2-1 strategy” and summarize the methods you can use to send NAS data to the cloud

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

A short article about a problem I had getting the GPS LocationListener working.
Whether you’re a college noob or a soon-to-be pro, these tips are sure to help you in your journey to becoming a programming ninja and stand out from the crowd.
In this fourth video of the Xpdf series, we discuss and demonstrate the PDFinfo utility, which retrieves the contents of a PDF's Info Dictionary, as well as some other information, including the page count. We show how to isolate the page count in a…
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question