Need help with this small program using an array.

manz2
manz2 used Ask the Experts™
on
Hi Experts!,

I'm making this small program that generates 3 randon integers and displays them.
Then it's suppose to sort them and display them letting me know which one is in what element.
I've been working on this trying to follow some book examples, but I'm very lost in the function that sorts them so I can display them back in MAIN()
I must have left out a couple of things or not put the correct commands obviously, if you could please let me know what and where I need to change things.
I want to do this in the most basic way possible, not using other sophisticated ways or commands, cause I'm just learning this as of now.

Thank you for your help.

#include <iostream>
using namespace std;

unsigned int numarray[3];


int RandomNumber(void)

{
   
    int a;
   
    srand(14);
   for(a = 0; a < 3; a++)
   {
       numarray[a] = rand()% 3;
   }
   return 0;
}
int sortArray(void)
{
      int temp, elems = 0;
      bool swap;

      do
      {
            swap = false;
            for (int count = 0; count < (elems - 1); count++)
            {
                  if (numarray[count] > numarray[count +1])
                  {
                        temp = numarray [count];
                        numarray[count] = numarray[count+1];
                        numarray[count +1] = temp;
                        swap = true;
                  }
            }
      } while (swap);

      return 0;

}
int main (void)
{
    int value;
    value=RandomNumber();
      cout << numarray[0] <<"  "<< numarray[1] <<"  " << numarray[2] << endl;
      sortArray();
      cout << "\nThe 1st element is " << numarray[0];
      cout << "\nThe 2nd element is " << numarray[1];
      cout << "\nThe 3rd element is " << numarray[2];
      system ("pause");
    return 0;
}
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Top Expert 2006

Commented:
>for (int count = 0; count < (elems - 1); count++)

elems was initalized to 0 ... so this loop will never be entered ... Also the do while loop will exit immediately since you just set the swap flag to false!!!

On a side note
numarray[a] = rand()% 3; ... why mod 3?

Top Expert 2006

Commented:
elems should have been intialized to number of elements in the array

Author

Commented:
> numarray[a] = rand()% 3; ... why mod 3?

Is it not necessary to make the range of numbers between 0 - 4 ??

I just changed it right now to:

numarray[a] = 1 + rand()% 4;

so that it ranges between 1 -4

correct? or not?
Top Expert 2006
Commented:
%4 will give you range of 0 to 3 ... Why do you need to limit your random numbers? They should be printed and sorted fine even without the restriction ... I hope you are not confusing array indices with the random numbers which are stored at those indices :)

Author

Commented:
These are my actual instructions for the program.

Generate an array of 50 random integers between 0-100. Store the number in a 1-d array and
then sort it. Using binary search, allow the user to input a number and then find if the number
is in the stored array. If it is in the array, then display the first location of that number.

But I decided to start coding one step at a time to see how everything is works along the way.

Eventually I will have to change the random generator from 3 to 50, then I have to work
on adding the binary search part and then displaying the position of the integer.

As of right now the part of the program I listed is working, thanks to you, now I have to add the rest.

If I run into problems, I'll ask again on the site, thanks again sunnycoder! :)
Top Expert 2006

Commented:
Glad to assist :) ... Good luck!

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial