Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 251
  • Last Modified:

Finding highest counter

Hello experts:
I need help with determining the highest counter.
I have a Windows C# application and I accumulate a bunch of counters.

Count1++
Count2++
Count3++
Count4++

How would I go about deterrmining which one has the highest value in the shortest statment possible so that I can
add more logic.

if count1 is highest do something
if count2 is highest do seomthing else
etc

Thanks  
0
lancerxe
Asked:
lancerxe
  • 5
2 Solutions
 
_TAD_Commented:

The method that uses the least amount of line space would be to use a function.

public void Main()
{

int count1;
int count2;
int count3;
int count4;

//load counters

int highest = GetLargest(new int[] {count1, count2, count3, count4});
...
..
.
}

private int GetLargest(int[] vals)
{
    int highest = int.minimum;
   
    for(int i=0;i<vals.Length;i++)
       if(vals[i]>highest)
           highest = vals[i];

   return highest;
}



0
 
_TAD_Commented:

The method that uses the least amount of line space would be to use a function.

public void Main()
{

int count1;
int count2;
int count3;
int count4;

//load counters

int highest = GetLargest(new int[] {count1, count2, count3, count4});
...
..
.
}

private int GetLargest(int[] vals)
{
    int highest = int.minimum;
   
    for(int i=0;i<vals.Length;i++)
       if(vals[i]>highest)
           highest = vals[i];

   return highest;
}



0
 
_TAD_Commented:

The method that uses the least amount of line space would be to use a function.

public void Main()
{

int count1;
int count2;
int count3;
int count4;

//load counters

int highest = GetLargest(new int[] {count1, count2, count3, count4});
...
..
.
}

private int GetLargest(int[] vals)
{
    int highest = int.minimum;
   
    for(int i=0;i<vals.Length;i++)
       if(vals[i]>highest)
           highest = vals[i];

   return highest;
}



0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
AlexNekCommented:
I suggest to create a new Counter class
like
   class myCounter
    {
        const int MAX_COUNTER = 4;

        private int[] mCounter= new int[MAX_COUNTER];
        private int mMaxValue = int.MinValue;
        private int mMaxCounterIndex = -1;

        public myCounter()
        {
            int i;

            for (i = 0; i < MAX_COUNTER; i++)
            {
                mCounter[i] = 0;
            }
        }

        public void IncCounter(int aIndex)
        {
            if (aIndex > 0 && aIndex < MAX_COUNTER)
            {
                mCounter[aIndex]++;
                if (mCounter[aIndex] > mMaxValue)
                {
                    mMaxValue = mCounter[aIndex];
                    mMaxCounterIndex = aIndex;
                }
            }
        }

        public int maxCounterValue
        {
            get
            {
                return mMaxValue;
            }
        }

        public int maxCounterIndex
        {
            get
            {
                return mMaxCounterIndex;
            }
        }
0
 
tpwellsCommented:
if all your counters are of the ame type you can quickly add them to an ArrayList and sort the list. After sorting the last item in the ArrayList will be the highest number.

System.Collections.ArrayList arList= new System.Collections.ArrayList();
arList.Add(counter1);
arList.Add(counter2);
arList.Add(counter3);
arList.Add(counter4);
arList.Sort();
int top = (int)arList[arList.Count-1];
0
 
_TAD_Commented:

I like tpwells' arraylist idea.... (same concept, abreviated code)


ArrayList arList = new ArrayList(new int[] {count1, count2, count3, count4});
arList.Sort();
int top = (int)arList[arList.Count-1];


0
 
_TAD_Commented:

On the same vein, if all of the counters are of the same type, you could simply create an int[] and sort that array.

int[] myArray = new int[]{count1, count2, count3, count4};
Array.Sort(myArray);
int top = myArray[myArray.Length-1];

using this code does two things
  1) It will make your memory footprint a bit smaller because it does not have to include the System.Collections library in memory.

  2) The performance will be bette because it does not have to box and unbox your data.


This is not to detract from tpwells' solution (kudos to him for the idea).  The performance increase and memory footprint arguments are purely accademic.  (around 8 k of memory and < 0.3 ms of time is saved)
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now