Solved

Threading - How can I update an image box regularily from a thread

Posted on 2006-11-21
6
222 Views
Last Modified: 2012-05-05
Hi,

I have an application that receives and displays live video feed (Motion JPEG).  I have a tree view so the user can select which live video feed to view.  Originally the feed was displayed in an image box on my main form.  It was decided that the feed should be displayed in a pop up window.  This is where I have my problems.

I process the video feed in a worker thread and that is working fine.  When my thread and image box were on the main form, in my worker I had the line:
mCameraView.Image = lastFrame;
This was updating just fine.

Now that I've moved the thread and image box to a seperate form, this code works, but if I move or resize the dialog it crashes.  I was told that this may be due to the fact that I'm trying to access the UI from two different threads; myWorker and the original.

My solution was to save the image to a local variable instead of updating the UI directly
Call invalidate on the ImageBox
In the OnPaint update the ImageBox with the image.

Now my program is just freezing.  I assume it is deadlocking somehow.  Anyone know what is going on?  Or if there is a better solution?
0
Comment
Question by:alexatsearidge
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 3
6 Comments
 
LVL 48

Expert Comment

by:AlexFM
ID: 17993701
The first step to solve such kind of problems is to make program working by consistent and predictable way. Add this line to the program initialization code:
Control.CheckForIllegalCrossThreadCalls = true;

In this case every direct cross-thread call causes exception immediately. Fix this by replacing direct call with Invoke and BeginInvoke.
0
 

Author Comment

by:alexatsearidge
ID: 17996392
Hi Alex, sorry you went over me head a little there.  I have pretty much no experience in thread programming.
Control.CheckForIllegalCrossThreadCalls = true; <- I cannot find this method for Control
Mind putting that in laymens terms with perhaps a code example for the Invoke/BeginInvoke?
0
 
LVL 48

Expert Comment

by:AlexFM
ID: 17996522
This is from C# 8.0:
http://msdn2.microsoft.com/en-us/library/system.windows.forms.control.checkforillegalcrossthreadcalls.aspx

What version do you use?

About BeginInvoke/Invoke:
http://www.codeproject.com/csharp/workerthread.asp

.NET doesn't allow to call Windows Forms methods from worker threads. Instead of this, we must use BeginInvoke or Invoke calls. However, .NET 1.1 developers were not consistent, and sometimes illegal cross-thread calls work successfully. Sometimes they give exception, sometimes program hangs.
For backward compatibility, .NET 2.0 supports the same behavior. However, this is undesired because program results are unpredictable.

Control.CheckForIllegalCrossThreadCalls = true;

It is strongly recommended to add this call to the beginning of every .NET 2.0 program. In this case every illegal call causes exception - consistent behavior. You need to fix all these exceptions by replacing direct calls with BeginInvoke or Invoke. Only after this is done, and program still hangs, search for possible deadlock.
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 

Author Comment

by:alexatsearidge
ID: 17998313
I'm using .NET ver 1.1
Does that mean I'm basically stuck?

I'm now using Invoke to call my method to add the image.
The form loads and the picture box streams the image successfully, but as soon as I move or resize the form my program crashes.
0
 
LVL 48

Accepted Solution

by:
AlexFM earned 125 total points
ID: 17998352
With .NET 1.1 this is more difficult. You need to check all your code and exclude all calls to Windows controls from worker threads. Even setting simple property is not allowed. For example:
button1.Enabled = true;
Running this code from worker thread can have unpredictable results.

After fixing this return to your original problem. Does program freezes or crashes - you posted two versions :)
0
 

Author Comment

by:alexatsearidge
ID: 18080543
Thanks for your help Alex,

I had some sample code that used GDI to draw the image instead of updating a picturebox.  I use Monitor.Enter/Exit around the drawing code and it works fine.
0

Featured Post

Secure Your Active Directory - April 20, 2017

Active Directory plays a critical role in your company’s IT infrastructure and keeping it secure in today’s hacker-infested world is a must.
Microsoft published 300+ pages of guidance, but who has the time, money, and resources to implement? Register now to find an easier way.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction Although it is an old technology, serial ports are still being used by many hardware manufacturers. If you develop applications in C#, Microsoft .NET framework has SerialPort class to communicate with the serial ports.  I needed to…
The article shows the basic steps of integrating an HTML theme template into an ASP.NET MVC project
In an interesting question (https://www.experts-exchange.com/questions/29008360/) here at Experts Exchange, a member asked how to split a single image into multiple images. The primary usage for this is to place many photographs on a flatbed scanner…

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question