Solved

INSTR function problem

Posted on 2006-11-22
3
237 Views
Last Modified: 2006-11-22
Hi,
      I am writing a login script with a permission level authenication for a web page, there are 5 sections that require logins on the page.  I am trying assign a letter to each section ie,

A - Admin
B - Process
C - HR
D - Management
E - Escalation

     Depending on the type user ID users can have access to one or many of the sections, so an admin level with access to Process and Escalation would look like "BE" or admin HR would look like "AC".  I am trying to use an INSTR function to facilitate this.  Here is the code I am using.
<%
If request.form.count => 1 Then

            ManagerID = request.Form(ucase("ManagerID"))
            ManagerPassword = request.Form(ucase("ManagerPassword"))
            
            If ManagerPein = "" Or ManagerPassword = "" Then
                  error = "*You Did Not Enter Either A Pein Or Password.<br>"
            End If
                        
            Set verifyRS = objADOConn.execute("Select Top 1 * From tb_Docs Where ManagerID = '"&ManagerID&"' And ManagerPassword = '"&ManagerPassword&"'")
                                                
            if verifyRS.BOF or VerifyRS.EOF Then
                  verify = "*ID Or Password Entered Does Not Match DataBase.<br>"                    
            end if
            
                                'this is where the INSTR function comes in, trying to access escalation section.
                                'compare adminlevel from recordset to required level to access section - "E"  
            if INSTR(1,cstr(verifyRS("AdminLevel")),"E",0) = 0 Then
                  verify = verify & "*You Do Not Have Permission To Enter This Section.<br>"                  end if
            
            if error = "" and verify = "" Then
                                               'if id and password entered are correct and admin level is correct go to escalation section                  
                  response.Redirect("http://escalationlog.asp")
            End If
      End If
%>

     The problem I am having is that if the user enters the correct ID and password the script will take them to the correct section; however, if they don't they get an error stating:

error '80020009'
Exception occurred.
line 30     'this is the line with the INSTR function.

     Also if I take out the part where I use the INSTR function the script works fine.  I have varified using vartype that the datatype reading from the db is a string, so I can't figure out why I am getting this error,  can anyone spot a flaw in my syntax or logic?  Thanks in advance for any help...
0
Comment
Question by:marcus72
  • 2
3 Comments
 
LVL 8

Accepted Solution

by:
esw074 earned 500 total points
ID: 17997059
If the username and password don't pull a record (which is what happens when one is mistyped), then you've got an empty recordset - and in that line you're trying to perform operations on an empty field, which is creating the error.  Try dumping the access level value from the database to a variable, then check to ensure the variable isn't empty, THEN perform this operation on the variable.

0
 

Author Comment

by:marcus72
ID: 17997196
Thanks esw074, I think that helped:

I added an else in my eof or bof

Set verifyRS = objADOConn.execute("Select Top 1 * From tb_OCCNetDocs Where Pein = '"&ManagerPein&"' And OccPassword = '"&ManagerPassword&"'")
            
            if verifyRS.BOF or VerifyRS.EOF Then
                  verify = "*Pein Or Password Entered Does Not Match DataBase.<br>"
            else
'here is the change...                  a_level = verifyRS("AdminLevel")
            end if
                        
            'if a_level = "" then
            '      response.Write("blank")
            'end if
            
            if instr(1,cstr(a_level),"E",1) < 1 Then
                  verify = verify & "*You Do Not Have Permission To Enter This Section.<br>"            
            end if
                  
            if error = "" and verify = "" Then
                  links = "<a href='http://occnet.int.bell.ca/includes/duty/escalationlog.asp'>Create Ticket</a><br><a href='http://escalationview.asp'>View Open Tickets</a>"
                  'response.Redirect("http://occnet.int.bell.ca/includes/duty/escalationlog.asp")
            End If

i am going to do a little more testing before i sign off on this.  but that made sense.  i'll respond again within an hour.
0
 

Author Comment

by:marcus72
ID: 17997843
I changed it again to the following code which I think is better.

                               if verifyRS.BOF or VerifyRS.EOF Then
                  verify = "*Pein Or Password Entered Does Not Match DataBase.<br>"
                 else
                        if INSTR(1,cstr(verifyRS("AdminLevel")),"E",0) = 0 Then
                        verify = verify & "*You Do Not Have Permission To Enter This Section.<br>"
                 end if            
            end if
0

Featured Post

Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Have you ever needed to get an ASP script to wait for a while? I have, just to let something else happen. Or in my case, to allow other stuff to happen while I was murdering my MySQL database with an update. The Original Issue This was written…
I was asked about the differences between classic ASP and ASP.NET, so let me put them down here, for reference: Let's make the introductions... Classic ASP was launched by Microsoft in 1998 and dynamically generate web pages upon user interact…
Two types of users will appreciate AOMEI Backupper Pro: 1 - Those with PCIe drives (and haven't found cloning software that works on them). 2 - Those who want a fast clone of their boot drive (no re-boots needed) and it can clone your drive wh…
This video shows how to use Hyena, from SystemTools Software, to bulk import 100 user accounts from an external text file. View in 1080p for best video quality.

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question