Solved

Resource leak

Posted on 2007-03-26
3
385 Views
Last Modified: 2013-11-20
I have some icons that I place in a new CImageList in the OnCreate in CMainFrame.  I the set several set them as icons to several of my buttons.  In the destructor for CMainFrame, I DeleteImageList() and then delete the CImageList.  When I close the program, Boundschecker tell me that I have resource leaks and tells me that I have to delete the icons that I set to the buttons so in OnClose for CMainFrame I tried to delete the icons like this for each button:
      CButton* btn;
      btn = (CButton*)m_wndMyCTRLBar.GetDlgItem( IDC_BUTTON1);
      DestroyIcon(btn->GetIcon());

Boundschecker still says that I have the resource leaks.  Am I suppose to delete them from another event or am I deleting them incorrectly.  Please help end my confusion.
 
0
Comment
Question by:ITSpgrmr
3 Comments
 
LVL 86

Assisted Solution

by:jkr
jkr earned 100 total points
ID: 18793780
I'd rather suggest to do that in the destructor of your control bar. Apart from that, what does 'DestroyIcon()' return and what 'GetLastError()' if it returns FALSE?
0
 
LVL 39

Accepted Solution

by:
itsmeandnobodyelse earned 400 total points
ID: 18793974
How did you get the HICON handles for the bitmaps? Did you get them by a LoadIcon ? If so, Boundschecker may be wrong cause the resource handles came from the already loaded resource file and don't need to be freed. At least there is no FreeIcon function to call. If you load the icons from file the case is different.

Regards, Alex
0
 
LVL 1

Author Comment

by:ITSpgrmr
ID: 18794217
itsmeandnobodyelse:
I did use LoadIcon and I was getting the icons from the resources and not from files.  So I don't have to worry about it since the resources in the resource file get dumped at the end.  That makes since and I like that answer.

jkr:
DestroyIcon() was returning TRUE.

 I agree, taking care of the icons in the destructor of the toolbar is much better.  Sometimes looking back at my code, I wonder what I was thinking.
0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
is twain_32.dll cmpatible with windows 10 ? 10 186
Annoying "thing" blocks my view 4 115
Problem with SqlConnection 4 178
Embarcadero C++ Builder XE10.1 Berlin red arrow Indicator 2 53
Introduction: Hints for the grid button.  Nested classes, templated collections.  Squash that darned bug! Continuing from the sixth article about sudoku.   Open the project in visual studio. First we will finish with the SUD_SETVALUE messa…
If you use Adobe Reader X it is possible you can't open OLE PDF documents in the standard. The reason is the 'save box mode' in adobe reader X. Many people think the protected Mode of adobe reader x is only to stop the write access. But this fe…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

861 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question