Solved

How to correctly use "On Error Resume Next" in ASP

Posted on 2007-03-27
9
1,535 Views
Last Modified: 2009-12-16
Hello experts,

Currently I have a custom 500 error page set up in IIS that logs errors.  However whenever an error occurs the page stops processing and the 500 error page is loaded.  I would like to instead use the "On Error Resume Next" method, but I having some problems.

First here is the code from my 500 error page that prints out the error details.  This works correctly - whenever there is a 500 error it prints out the error description, the line, and the column:

Set ASPErr = Server.GetLastError()
response.write("Line: " & ASPErr.Line & "<br>")
response.write("Column: " & ASPErr.Column & "<br>")
response.write("Description: " & ASPErr.Description & "<br>")

Here is the code I am using to implement "On error resume next".  This code is not working.

On Error Resume Next
'database request
If Err.number <> 0 then
    Set ASPErr = Server.GetLastError()      
    response.write("Line: " & ASPErr.Line & "<br>")
    response.write("Column: " & ASPErr.Column & "<br>")
    response.write("Description: " & ASPErr.Description & "<br>")
End If

This code does not work correctly.  It always returns 0 as the error line and -1 as the column number, no matter where the error occurs.  It also does not return the description.

Can anyone tell me what I am doing wrong here?  Is it a mistake in my code?  Why does it work correctly on the custom 500 error page but incorrectly when using "On Error Resume Next"?

Thanks in advance!
0
Comment
Question by:greatseats
  • 4
  • 3
  • 2
9 Comments
 
LVL 22

Expert Comment

by:WMIF
ID: 18803861
you shouldnt need the "Set ASPErr = Server.GetLastError()" line in there.  try using the same properties but with the Err object.
0
 

Author Comment

by:greatseats
ID: 18803932
WMIF,

I adjusted my code to read:

If Err.number <> 0 then
    response.write("Line: " & Err.Line & "<br>")
    response.write("Column: " & Err.Column & "<br>")
    response.write("Description: " & Err.Description & "<br>")
End If

The output error description now reads:  "Object doesn't support this property or method".  However that error description is not correct; I get that description for any error, be it an SQL error, Type mismatch, Overflow, etc.

I believe that this error description is in reference to the "Err.Line" and "Err.Column" code; If I remove those two items I get the correct error description for whatever went wrong.  Is there a way to output the error line?
0
 
LVL 22

Expert Comment

by:WMIF
ID: 18803971
what if you write the description property first?
0
 

Author Comment

by:greatseats
ID: 18804026
WMIF,

If I write the description property first I get the correct description.  However I get nothing for the  Err.Column and Err.Line values.
0
What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

 
LVL 70

Expert Comment

by:Chris Dent
ID: 18804071

Line and Column aren't properties of the Err Object in VbScript. You get:

Description
Source
Number

As well as two methods (Raise and Clear).

This may not help too much as it won't help you find a line number. But that's what you get available to you.

You can find lots more on the Err Object and error handling in general in VbScript here:

http://www.microsoft.com/technet/scriptcenter/resources/scriptshop/shop1205.mspx
http://www.microsoft.com/technet/scriptcenter/resources/scriptshop/shop0106.mspx

Silly titles, but good articles.

Chris
0
 

Author Comment

by:greatseats
ID: 18804347
Chris-Dent,

Is there any way for me to get the line number of the error?
0
 
LVL 70

Accepted Solution

by:
Chris Dent earned 500 total points
ID: 18806434

Only from the log files when it fails completely (or the 500 page if you tell it to).

That's part of the problem with the Err object, it's not all the script processor uses to report a fatal error.

When you start to handle the errors yourself (with On Error ...) you get rid of the fatal error, but for an accurate failure reason you must write in full error handling at every point you think is suspect.

I'm sorry it's not better news, it's something I've struggled with in the past as well. All I can suggest is that you minimize the scope for On Error Resume Next by turning it off afterwards with "On Error Goto 0", either that or write yourself a Subroutine that will report the error and a little information about what called the subroutine (which you would have to hard-code).

Chris
0
 

Author Comment

by:greatseats
ID: 18809483
Chris-Dent,

Thanks for the info.  It looks like the hard-coding method is my best bet.  I was just hoping it wouldn't come to that:-).  Thanks again!
0
 
LVL 70

Expert Comment

by:Chris Dent
ID: 18809508

No problem, good luck!

Chris
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Today I came across an interesting issue that had me pulling my hair out.  I was troubleshooting a new internal web site which uses integrated security instead of anonymous.  When browsing the site from my laptop, I was able to access it with no iss…
Running classic asp applications under Windows Server 2008 R2 (x64) and IIS 7 is not as easy as one may think. It took me a while to figure it out while getting error 8002801d a few times. After you install the OS you will need to install the fol…
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
This video gives you a great overview about bandwidth monitoring with SNMP and WMI with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're looking for how to monitor bandwidth using netflow or packet s…

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now