Solved

# Generate unique 4 char values

Posted on 2007-03-28
246 Views
I need to generate some PINs for a login system. I only have 39 values but I would like them to be unique,
how would I do that in PHP?
0
Question by:EddieShipman
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points
• Learn & ask questions
• 3
• 2
• 2
• +1

LVL 5

Expert Comment

ID: 18808895
There are several ways.

Are you saving the pins somewhere to make sure that they are not reused?
If so - we could do something like this:

\$uniqueval = rand(0,9999);
/// do some code to get a list of previously assigned pins (not shown)
// (now do a while loop to go through the previously assigned vals)
while(\$x = 0)
{
if(in_array(\$uniqueval,\$something)
{

}

}
0

LVL 5

Expert Comment

ID: 18808921
oops hit a button on the keyboard and it submitted - try again

if(in_array(\$uniqueval,\$something) {   \$uniqueval=rand(0,9999); \$x =0; }
else { \$x = 1; }

At the conclusion of the loop \$uniqueval should be a unique 4 digit value not previously assigned.
0

LVL 26

Author Comment

ID: 18809051
I have 39 records in a mySQL table named Teams, the field is PIN.
0

LVL 29

Accepted Solution

rdivilbiss earned 500 total points
ID: 18809082
If you want a 4 digit pin, then rand(0,9999); needs to be rand(1111,9999);

<?PHP
\$pins = array();
\$maxPins = 39;

for (\$idx=0; \$idx<\$maxPins; \$idx++) {
\$unique = false;
while (!\$unique) {
\$tmpPin = rand(1111,9999);
if (!array_search(\$tmpPin, \$pins)) {
\$unique=true;
}
}
array_push(\$pins,\$tmpPin);
// you can update a table row \$idx here
}

print_r(\$pins);
?>
0

LVL 27

Expert Comment

ID: 18809085
do{
\$newpin=rand()%1000000000;
\$result=mysql_query("Select * from Teams where PIN=\$newpin;");
}while(mysql_num_rows(\$result)>0);

At the end of this loop, you will have \$newpin equal to a random value that is not in the table.
0

LVL 29

Expert Comment

ID: 18809207
Why do multiple database lookups, when you can determine the uniqueness in code alone, and only hit the database when you update a record with the new PIN.

Also, (although not explicitly stated by the asker,) a PIN is normally a 4 digit integer, where rand()%1000000000; will return many different lengths.
0

LVL 27

Expert Comment

ID: 18809271
OK, so just change the rand statement to generate whatever size number you want for the pin.

However, unless the pins are all generated at the same time and only once, you cannot save them in code.  You will have to do database lookups each time you generate a new one for a new user.
0

LVL 29

Expert Comment

ID: 18809329
He says he already has 39 rows, so only hit each row one time, e.g. to update it with the unique PIN.

If he was adding a new row subsequent, then your query until unique would be a good choice.
0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

### Suggested Solutions

Nothing in an HTTP request can be trusted, including HTTP headers and form data.  A form token is a tool that can be used to guard against request forgeries (CSRF).  This article shows an improved approach to form tokens, making it more difficult toâ€¦
Many old projects have bad code, but the budget doesn't exist to rewrite the codebase. You can update this code to be safer by introducing contemporary input validation, sanitation, and safer database queries.
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn how to create and use a small PHP class to apply a watermark to an image. This video shows the viewer the setup for the PHP watermark as well as important coding language. Continue to Part 2 to learn the core code used in creatâ€¦
###### Suggested Courses
Course of the Month2 days, 11 hours left to enroll

#### 752 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.