Solved

Object reference not set to an instance of an object.

Posted on 2007-03-30
2
339 Views
Last Modified: 2008-02-01
I have a webpage with which I'm loading data into a listbox called "ClientListBox".  The page loads without a problem when I open a Client that does not have any items that are supposed to be selected in the ClientListBox.  If there is supposed to be a client Selected, then I get the error:  Object reference not set to an instance of an object.

I've listed all of the code that this function involves and highlighted the line that gives me the error.  I'm hoping there's a simple solution that I've somehow overlooked doing something.  Thank you!


void Page_LoadComplete(object sender, EventArgs e)
    {
        if (CurrentProject != null)
        {
            SelectProjectClients(CurrentProject.Id);
        }
    }

protected void SelectProjectClients(int projectId)
    {
        ClientListBox.DataBind();
        List<string> clientList = Project.GetProjectClients(projectId);

        foreach (string client in clientList)
        {
                           ListItem item = ClientList.Items.FindByValue(client);
 ERROR----------> item.Selected = true;
        }
    }


    //Project.GetProjectClients
        public static List<string> GetProjectClients(int Id)
        {
            if (Id <= DefaultValues.GetProjectIdMinValue())
                return (new List<string>());

            DataAccess DALLayer = DataAccessHelper.GetDataAccess();
            return (DALLayer.GetProjectClients(Id));
        }


//DALLayer.GetProjectClients
        public override List<string> GetProjectClients(int Id)
        {
            if (Id <= 0)
                throw (new ArgumentOutOfRangeException("Id"));

            SqlCommand sqlCmd = new SqlCommand();
            AddParamToSQLCmd(sqlCmd, "@ProjectId", SqlDbType.Int, 0, ParameterDirection.Input, Id);
            SetCommandType(sqlCmd, CommandType.StoredProcedure, SP_PROJECT_GETPROJECTCLIENTS);
            List<string> clientList = new List<string>();
            TExecuteReaderCmd<string>(sqlCmd, TGenerateClientListFromReader<string>, ref clientList);
            return clientList;
        }

private const string SP_PROJECT_GETPROJECTCLIENTS = "GetProjectClients";

//storedprocedure
CREATE  PROCEDURE [dbo].[GetProjectClients]
      @ProjectId INT
AS

SELECT
 Clients.Name
From
 aspnet_starterkits_ProjectClients
INNER JOIN Clients ON aspnet_starterkits_ProjectClients.ClientId = Clients.ClientId
WHERE
 ProjectId=@ProjectId
SET QUOTED_IDENTIFIER OFF
0
Comment
Question by:deloused
2 Comments
 
LVL 14

Accepted Solution

by:
steveberzins earned 500 total points
ID: 18827382
a few problems.

-you're attempting to look for a value that there is no way it's gonna be there from what I can tell
-you need to select the client id, and name in the select (in the proc), and tell the list which column is going to be the value source, and which will be the display value source
-even if the value is there, and should be found, you should code defensively, and check to make sure an object is not null before accessing/setting a property on it.
if (null != item) item.Selected = true;
0
 

Author Comment

by:deloused
ID: 18827432
Aggh!! woo!  

Sorry, your reply gave me the solution....thank you.  I forgot to mention that the ClientListBox has a sql data source which gets ALL of the clients in the database table.  Of course I had set the DataTextField to display"Name" DataValue Field save "ClientId".  I changed the value field to "Name" and now it works beautifully.  

thank you!
0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

Suggested Solutions

Introduction Hi all and welcome to my first article on Experts Exchange. A while ago, someone asked me if i could do some tutorials on object oriented programming. I decided to do them on C#. Now you may ask me, why's that? Well, one of the re…
Entity Framework is a powerful tool to help you interact with the DataBase but still doesn't help much when we have a Stored Procedure that returns more than one resultset. The solution takes some of out-of-the-box thinking; read on!
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…
Illustrator's Shape Builder tool will let you combine shapes visually and interactively. This video shows the Mac version, but the tool works the same way in Windows. To follow along with this video, you can draw your own shapes or download the file…

760 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now