Solved

Perl FTP download not working.

Posted on 2007-04-04
2
4,229 Views
Last Modified: 2008-01-09
I have created a script to download several zip files over 50 files. There are two problems that I am running into, first there are two folders in the directory were the files are. The folders do not need to be downloaded, and the second is that the script does not download all the files it usually downloads something like 50 - 52 files I need it to download all files but not the folders here is a copy of my script please help me figuer out what I am doing wrong.

[start code]

#!/usr/bin/perl
      use Net::FTP;
      use Archive::Extract;
      use File::Listing qw(parse_dir);

      $host = 'myhost.com';
      $path = '/mydir/data/';

      $ftp = Net::FTP->new($host, Timeout => 1800) or die "Cannot contact $host: $!";

      $ftp->login('username', 'password') or die "Cannot login ($host):" . $ftp->message;

      $ftp->cwd($path) or die "Cannot change directory ($host):" . $ftp->message;

      @Files = $ftp->ls('-lR');
      
      $ftp->binary();         
      
foreach $file (parse_dir(\@Files))
      {
          my($name, $type, $size, $mtime, $mode) = @$file;            
            print "Retrieving $name \n";
            print "File type $type \n";
            
            if ($type != 'f')
            {
                  print "File name: $name";
                  print "File type: $type";
            }
            
            if ($type eq 'f')
            {
                  $ftp->hash($name,102400);
            
                  $ftp->get($name, "C:/Temp/$name") or warn "Could not get $_, skipped: $!";
                  EXTRACT("C:/temp/$name");
            }
      }

$ftp->quit or die "Could not close the connection cleanly: $!";
      
sub EXTRACT
      {
            my $ae = Archive::Extract->new( archive => @_ );
            my $ok = $ae->extract( to => 'C:/temp/central/dnld' );

      }

exit;

[code end]

one last thing I have also include a step to unzip all the files as it finishes the download. What is wrong with this thing.
0
Comment
Question by:leotron
2 Comments
 
LVL 20

Accepted Solution

by:
jmcg earned 500 total points
ID: 18880110
The fact that your script successfully downloads some files means that it is substantially correct and leads me to suspect that there is some data dependency that is causing your script to fail: running into a transfer problem from the FTP server, running out of disk space, etc.

The first thing to check is the content of @Files to be sure that it contains everything you expect it to contain. Then, if the "foreach $file" loop exits early, before all the files are transferred, I'd look at whether there's an uncaught error occurring in the 'extract' method.

For perfectionism, check whether the call to the 'hash' method is working the way you want. As I read it, you should only need to call it once per ftp session, not for every file. The $file parameter you're passing is evaluated as to true or false, but otherwise ignored.
0
 
LVL 1

Author Comment

by:leotron
ID: 19142098
Thank you for your comment the script was timing out so I increased the timeout time and that solved the problem
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Email validation in proper way is  very important validation required in any web pages. This code is self explainable except that Regular Expression which I used for pattern matching. I originally published as a thread on my website : http://www…
There are many situations when we need to display the data in sorted order. For example: Student details by name or by rank or by total marks etc. If you are working on data driven based projects then you will use sorting techniques very frequently.…
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
Learn how to create flexible layouts using relative units in CSS.  New relative units added in CSS3 include vw(viewports width), vh(viewports height), vmin(minimum of viewports height and width), and vmax (maximum of viewports height and width).

863 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now