Using the "IF EXISTS" conditional statement.

I'm trying to gather some user statistics based on 3 conditions. First I want to check if the referring querystring is already in the database. If not insert it into the db. Second, if the querystring is already in the database, then check if the ip-address of the user is already in the database. If it is, then check if the ip address was inserted today. If not, update the "refCountIn" field with +1. The problem lies in the third condition where we check if the ip-address was inserted today and if false, update the "refCountIn" field with +1 and if true, do nothing.Below is the code I have until now:  

Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load

        ' *** Declare the variables
        Dim getStatCmd As String
        Dim updStatCmd As String

        Dim myRef As String = Request.QueryString("ref")
        Dim myQueryString As String = Request.ServerVariables("QUERY_STRING").Replace("ref=", "")
        Dim myRemoteAddr As String = Request.ServerVariables("REMOTE_ADDR")
        Dim myHttpReferer As String = Request.ServerVariables("HTTP_REFERER")

        Dim dtNow As Date = DateTime.Now
        Dim dtToday As Date = DateTime.Today

        ' *** Conditional INSERT command
        getStatCmd = _
            "IF EXISTS(SELECT 'True' FROM tblReferers WHERE robotName = '" & myQueryString & "' AND refIpAddress = '" & myRemoteAddr & "') " & _
            "BEGIN " & _
            "SELECT 'This clickin has already been recorded!'" & _
            "END ELSE BEGIN " & _
            "SELECT 'Clickin recorded' " & _
            "INSERT INTO tblReferers(robotName, refIpAddress, refReferer, refTime) " & _
            "VALUES(" & _
             "'" + myQueryString + "'," & _
             "'" + myRemoteAddr + "'," & _
             "'" + myHttpReferer + "'," & _
             "'" + dtToday + "')" & _
            "END "


        ' *** Conditional UPDATE command
        updStatCmd = _
            "IF EXISTS(SELECT 'True' FROM tblReferers WHERE robotName = '" & myQueryString & "' AND refIpAddress = '" & myRemoteAddr & "' AND refTime > '" & dtToday & "') " & _
            "UPDATE tblReferers " & _
            "SET refCountIn = refCountIn + 1, refTime = '" & dtToday & "' " & _
            "WHERE refIpAddress = '" & myRemoteAddr & "' AND robotName = '" & myRef & "'"

        Dim insConnCmd As New SqlCommand(getStatCmd, New SqlConnection(connSD))
        Dim updConnCmd As New SqlCommand(updStatCmd, New SqlConnection(connSD))

        insConnCmd.Connection.Open()
        insConnCmd.ExecuteNonQuery()
        insConnCmd.Connection.Close()

        updConnCmd.Connection.Open()
        updConnCmd.ExecuteNonQuery()
        updConnCmd.Connection.Close()

    End Sub

Anyone with an idea on how to solve this one? I think I need to write a subquery for the third condition, but I don't have a clue on how to handle this.Thanks in advance for your help!
LVL 4
RineauAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Racim BOUDJAKDJIDatabase Architect - Dba - Data ScientistCommented:
I suggest you use encapsulate your SQL code in stored procedures instead of leaving it in the API code.  It will make it more readable and debuggable...
0
YZlatCommented:
what you have will not work as an inline sql statement. Create a stored procedure like Racimo suggested
0
RineauAuthor Commented:
Thanks guys!
I have just written my very first stored procedure :) Is this correct?

ALTER PROCEDURE sdstats.spGetReferers
      
      (
      @myQueryString varchar(50),
      @myRemoteAddr varchar(12),
      @myHttpReferer varchar(155),
      @dtToday datetime
      )
      
AS
      BEGIN
      SET NOCOUNT ON
      
      IF EXISTS(SELECT 'True' FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr)
      BEGIN
      SELECT 'This clickin has already been recorded!'
      END ELSE BEGIN
      SELECT 'Clickin recorded'
      INSERT INTO tblReferers(robotName, refIpAddress, refReferer, refTime)
      VALUES(@myQueryString, @myRemoteAddr, @myHttpReferer, @dtToday)
      END
      
      IF EXISTS(SELECT 'True' FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr AND refTime > @dtToday)
    UPDATE tblReferers SET refCountIn = refCountIn + 1, refTime = @dtToday
    WHERE refIpAddress = @myRemoteAddr AND robotName = @myQueryString
      END
      RETURN

How do I pass data/execute the stored procedure from the codebehind? Any good tutorials or something?
0
10 Tips to Protect Your Business from Ransomware

Did you know that ransomware is the most widespread, destructive malware in the world today? It accounts for 39% of all security breaches, with ransomware gangsters projected to make $11.5B in profits from online extortion by 2019.

Racim BOUDJAKDJIDatabase Architect - Dba - Data ScientistCommented:
I suggest you use following style in coding...(sp are very practical.  You may either return an output parameter or a dataset or both:))

ALTER PROCEDURE sdstats.spGetReferers
     
      (
      @myQueryString varchar(50),
      @myRemoteAddr varchar(12),
      @myHttpReferer varchar(155),
      @dtToday datetime,
      @return_value int output
      )
     
AS
      BEGIN
      SET NOCOUNT ON
     
      IF NOT EXISTS(SELECT 1 FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr)
            BEGIN
                  set @return_value = 0
      END
      ELSE
      BEGIN
                  INSERT INTO tblReferers(robotName, refIpAddress, refReferer, refTime)
            VALUES(@myQueryString, @myRemoteAddr, @myHttpReferer, @dtToday)
            set @return_value = 1
      END
     
      IF EXISTS (SELECT 1 FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr AND refTime > @dtToday)
      BEGIN
            UPDATE tblReferers SET refCountIn = refCountIn + 1, refTime = @dtToday
            WHERE refIpAddress = @myRemoteAddr AND robotName = @myQueryString
            set @return_value
      END
      RETURN
0
RineauAuthor Commented:
Thank you Racimo, but there seems to be an error in the syntax of the stored procedure. It's in the update part of the code. Visual Studio returns the error: "Incorrect syntax near the keyword 'END'".

I also made a start with the code for exectuting the strored procedure. Does it appear to be correct?

Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load

        Dim sqlConnSD As New SqlConnection("connStrSD")
        Dim trackCmd As New SqlCommand("trackReferer", sqlConnSD)

        Dim myQueryString As String = Request.ServerVariables("QUERY_STRING").Replace("ref=", "")
        Dim myRemoteAddr As String = Request.ServerVariables("REMOTE_ADDR")
        Dim myHttpReferer As String = Request.ServerVariables("HTTP_REFERER")
        Dim dtToday As Date = DateTime.Today

        trackCmd.CommandType = CommandType.StoredProcedure

        trackCmd.Parameters("@myQueryString").Value = myQueryString
        trackCmd.Parameters("@myRemoteAddr").Value = myRemoteAddr
        trackCmd.Parameters("@myHttpReferer").Value = myHttpReferer
        trackCmd.Parameters("@dtToday").Value = dtToday

        sqlConnSD.Open()
        trackCmd.ExecuteNonQuery()
        sqlConnSD.Close()

End Sub

ps: for what it's worth; I raised the number of points to 500

0
Racim BOUDJAKDJIDatabase Architect - Dba - Data ScientistCommented:
Ooops..forgot to set up the last return value  Besides I suggest you separate update/insert/selects in different sp's for manageability...

ALTER PROCEDURE sdstats.spGetReferers
     
      (
      @myQueryString varchar(50),
      @myRemoteAddr varchar(12),
      @myHttpReferer varchar(155),
      @dtToday datetime,
      @return_value int output
      )
     
AS
      BEGIN
      SET NOCOUNT ON
     
      IF NOT EXISTS(SELECT 1 FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr)
            BEGIN
                  set @return_value = 0
      END
      ELSE
      BEGIN
                  INSERT INTO tblReferers(robotName, refIpAddress, refReferer, refTime)
            VALUES(@myQueryString, @myRemoteAddr, @myHttpReferer, @dtToday)
            set @return_value = 1
      END
     
      IF EXISTS (SELECT 1 FROM tblReferers WHERE robotName = @myQueryString AND refIpAddress = @myRemoteAddr AND refTime > @dtToday)
      BEGIN
            UPDATE tblReferers SET refCountIn = refCountIn + 1, refTime = @dtToday
            WHERE refIpAddress = @myRemoteAddr AND robotName = @myQueryString
            set @return_value = 2
      END
      RETURN
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
RineauAuthor Commented:
Thanks very much Racimo! Greatly appreciated!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
ASP.NET

From novice to tech pro — start learning today.