[Webinar] Streamline your web hosting managementRegister Today

x
?
Solved

BASH - script problem

Posted on 2007-04-07
9
Medium Priority
?
316 Views
Last Modified: 2013-12-26
h=0
while [ $h -eq 0 ]; do
if echo "$host" | egrep -e '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$';
then
IFS='.'
arr=($host)
if [ ${arr[0]} -le 255 -a ${arr[1]} -le 255 -a ${arr[2]} -le 255 -a ${arr[3]} -le 255 ];
then
if [ ${arr[0]:0:1} !-eq 0 ] || [ ${arr[1]:0:1} !-eq 0 ] || [ ${arr[2]:0:1} !-eq 0 ]; then
h=1
IFS=''
fi
else
echo "Error: The maximum number you can write is 255, try again."
read host
fi
else
echo "Error: You MUST use only digits from 1 to 5, and the ip must be like xxx.xxx.xxx.xxx, try again."
read host
fi
done

Any ideea whats wrong in this ?
Should i put IFP='' after each else or something ? :|
0
Comment
Question by:rares_dumitrescu
  • 4
  • 3
  • 2
9 Comments
 
LVL 85

Expert Comment

by:ozo
ID: 18869092
h=0
while [ $h -eq 0 ]; do
  if echo "$host" | egrep -e '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$';
  then
    IFS='.'
    arr=($host)
    if [ ${arr[0]} -le 255 -a ${arr[1]} -le 255 -a ${arr[2]} -le 255 -a ${arr[3]} -le 255 ];
    then
      if [ ! ${arr[0]:0:1} -eq 0 ] || [ ${arr[1]:0:1} -ne  0 ] || [ ! ${arr[2]:0:1} -eq 0 ]; then
        h=1
        IFS=''
      fi
    else
      echo "Error: The maximum number you can write is 255, try again."
      read host
    fi
  else
    echo "Error: You MUST use only digits from 1 to 5, and the ip must be like xxx.xxx.xxx.xxx, try again."
    read host
  fi
done
0
 

Author Comment

by:rares_dumitrescu
ID: 18869134
it works if i put: 123.0.123.123
any sugestions ? i want to check if the ip typed is like: xxx.xxx.xxx.xxx (x, xx, or xxx) and if the first number of every xxx isn't 0

Example: 12.237.2.124 -> correct
                73.02.21.14 -> incorrect
                84.14.013.23 -> incorrect

did you get the ideea?
thanx
0
 
LVL 85

Expert Comment

by:ozo
ID: 18870252
h=0
while [ $h -eq 0 ]; do
  if echo "$host" | egrep -e '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$';
  then
    IFS='.'
    arr=($host)
    if [ ${arr[0]} -le 255 -a ${arr[1]} -le 255 -a ${arr[2]} -le 255 -a ${arr[3]} -le 255 ]
    then
      if [ ${arr[0]:0:1} -ne 0 -a ${arr[1]:0:1} -ne  0 -a ${arr[2]:0:1} -ne 0 ] ; then
        h=1
        IFS=''
      else
        echo "Error: The first digit cannot be 0, try again"
        read host
      fi
    else
      echo "Error: The maximum number you can write is 255, try again."
      read host
    fi
  else
    echo "Error: You MUST use only digits from 1 to 5, and the ip must be like xxx.xxx.xxx.xxx, try again."
    read host

fi
done
0
Hire Technology Freelancers with Gigs

Work with freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely, and get projects done right.

 
LVL 7

Expert Comment

by:nixfreak
ID: 18870368
h=0
while [ $h -eq 0 ]; do
        read host
        echo $host | egrep -e '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$' >
/dev/null
        if [ "$?" -ne 0 ] ; then
                echo "Error: The ip must be like xxx.xxx.xxx.xxx, try again."
                continue
        else
                IFS='.'
                arr=($host)
                for i in 0 1 2 3 ; do
                        if [ ${arr[i]} -gt 255 ] ; then
                                echo "Error: The maximum number you can write is 255, try again"
                                continue 2
                        fi
                        echo ${arr[i]} | egrep "0[0-9]+" > /dev/null
                        if [ "$?" -eq 0 ] ; then
                                echo "Error: The first digit cannot be 0, try again"
                                continue 2
                        fi
                done
        fi
        h=1 ; echo "IP accepted!"
done
0
 
LVL 7

Assisted Solution

by:nixfreak
nixfreak earned 400 total points
ID: 18870374
Typo.

h=0
while [ $h -eq 0 ]; do
        read host
        echo $host | egrep -e '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$' > /dev/null
        if [ "$?" -ne 0 ] ; then
                echo "Error: The ip must be like xxx.xxx.xxx.xxx, try again."
                continue
        else
                IFS='.'
                arr=($host)
                for i in 0 1 2 3 ; do
                        if [ ${arr[i]} -gt 255 ] ; then
                                echo "Error: The maximum number you can write is 255, try again"
                                continue 2
                        fi
                        echo ${arr[i]} | egrep "0[0-9]+" > /dev/null
                        if [ "$?" -eq 0 ] ; then
                                echo "Error: The first digit cannot be 0, try again"
                                continue 2
                        fi
                done
        fi
        h=1 ; echo "IP accepted!"
done       
0
 
LVL 85

Accepted Solution

by:
ozo earned 1600 total points
ID: 18870385
the first test could also have been
  if echo "$host" | egrep -e '^[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}$';
but that does not show whats wrong in the original script
0
 

Author Comment

by:rares_dumitrescu
ID: 18872188
yes ozo, finally, "if echo "$host" | egrep -e '^[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}$';"

please, if you can explain what [1-9][0-9]{0,2} or [1-9]{1,3} means, so i can learn, maybe i will need it again sometime.

thanx a lot, and have a HAPPY EASTER :)
0
 
LVL 85

Expert Comment

by:ozo
ID: 18872665
[1-9] means any character fron '1' to '9'
[1-9]{1,3} means any character fron '1' to '9' between 1 and 3 times
][0-9]{0,2} means any character fron '0' to '9' between 0 and 2 times
perl -MYAPE::Regex::Explain -e "print YAPE::Regex::Explain->new('^[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}\.[1-9][0-9]{0,2}$')->explain"
0
 

Author Comment

by:rares_dumitrescu
ID: 18872844
thanx mr ozo
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: Ownerdraw of the grid button.  A singleton class implentation and usage. Continuing from the fifth article about sudoku.   Open the project in visual studio. Go to the class view – CGridButton should be visible as a class.  R…
Ready to get certified? Check out some courses that help you prepare for third-party exams.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
With just a little bit of  SQL and VBA, many doors open to cool things like synchronize a list box to display data relevant to other information on a form.  If you have never written code or looked at an SQL statement before, no problem! ...  give i…
Suggested Courses
Course of the Month9 days, 5 hours left to enroll

590 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question