Problems calculating total directory size inclusive of files and sub directories

I am using the following function to calculate TOTAL directory size, inclusive of sub directories and files.
I works for all of the files within the main directory, but then resets when it goes to the first sub directory.

Can anyone see where it is going wrong and how it can be fixed.

Thanks,
Michael

    Function GetFolderSize(ByVal DirPath As String, Optional ByVal IncludeSubFolders As Boolean = True) As Long

        Dim lngDirSize As Long
        Dim objFileInfo As FileInfo
        Dim objDir As DirectoryInfo = New DirectoryInfo(DirPath)
        Dim objSubFolder As DirectoryInfo

        Try
            'add length of each file
            For Each objFileInfo In objDir.GetFiles()
                lngDirSize += objFileInfo.Length
            Next
            'call recursively to get sub folders
            'if you don't want this set optional
            'parameter to false
            If IncludeSubFolders = True Then
                For Each objSubFolder In objDir.GetDirectories()
                    lngDirSize += GetFolderSize(objSubFolder.FullName)
                Next
            End If
        Catch Ex As Exception
        End Try
        If lngDirSize > 0 Then
            Return BytesToMegabytes(lngDirSize)
        Else
            Throw New Exception("Invalid or unreadable directory")
            Exit Function
        End If
    End Function

    Private Function BytesToMegabytes(ByVal Bytes As Long) _
    As Long
        Dim dblAns As Double
        dblAns = (Bytes / 1024) / 1024
        BytesToMegabytes = Format(dblAns, "###,###,##0.00")
    End Function

It is being called with:

TotalData = GetFolderSize("c:\temp\", True)
webkiwi1Asked:
Who is Participating?
 
Babycorn-StarfishConnect With a Mentor Commented:
hi try this,


    Sub Main()
        Dim totalSize As Long = GetFolderSize("d:\New Folder", True)
        Console.Write("" + BytesToMegabytes(totalSize).ToString())
        Console.Read()
    End Sub

    Function GetFolderSize(ByVal DirPath As String, Optional ByVal IncludeSubFolders As Boolean = True) As Long
        Dim lngDirSize As Long
        Dim objFileInfo As IO.FileInfo
        Dim objDir As IO.DirectoryInfo = New IO.DirectoryInfo(DirPath)
        Dim objSubFolder As IO.DirectoryInfo

        Try
            'add length of each file
            For Each objFileInfo In objDir.GetFiles()
                lngDirSize += objFileInfo.Length
            Next
            'call recursively to get sub folders
            'if you don't want this set optional
            'parameter to false
            If IncludeSubFolders = True Then
                For Each objSubFolder In objDir.GetDirectories()
                    lngDirSize += GetFolderSize(objSubFolder.FullName)
                Next
            End If
        Catch Ex As Exception
        End Try
        GetFolderSize = lngDirSize
    End Function

    Private Function BytesToMegabytes(ByVal Bytes As Long) As Double
        Dim dblAns As Double
        dblAns = (Bytes / 1024) / 1024
        BytesToMegabytes = dblAns 'Format(dblAns, "###,###,##0.00")
    End Function
0
 
Fernando SotoRetiredCommented:
This value of Dim lngDirSize As Long is getting rest to 0 each time the function GetFolderSize is called. Pass in the value of lngDirSize to the function and the first time you call it pass in 0.
0
 
webkiwi1Author Commented:
I understand what you are saying, how would I pass in the value?
0
Introducing Cloud Class® training courses

Tech changes fast. You can learn faster. That’s why we’re bringing professional training courses to Experts Exchange. With a subscription, you can access all the Cloud Class® courses to expand your education, prep for certifications, and get top-notch instructions.

 
Babycorn-StarfishCommented:
Would the call to BytesToMegaBytes towards the bottom of your function affect things too if you're calling it recursively and adding the results together? You're essentially working with two different scales, if this is right call this on the overal result of GetFolderSize
0
 
webkiwi1Author Commented:
Another good point Babycorn-Starfish (?!?!?!)

Perhaps I should move the call to MytesToMegaBytes from the GetFolderSize function to the page load sub.
0
 
Babycorn-StarfishCommented:
comment or uncomment the Format bit depending on what you need. You may want to round it up or down depending on how accurate you need it too
0
 
Babycorn-StarfishCommented:
Sorry, left my file path in there !
0
 
Fernando SotoConnect With a Mentor RetiredCommented:
   Private Sub Button1_Click(ByVal sender As System.Object, _
        ByVal e As System.EventArgs) Handles Button1.Click

        Dim TotalData As Long = GetFolderSize("C:\Temp\MSPress\Crystal_Reports_10\", 0, True)

    End Sub

    Function GetFolderSize(ByVal DirPath As String, ByVal dirSize As Long, _
        Optional ByVal IncludeSubFolders As Boolean = True) As Long

        Dim lngDirSize As Long = dirSize
        Dim objFileInfo As FileInfo
        Dim objDir As DirectoryInfo = New DirectoryInfo(DirPath)
        Dim objSubFolder As DirectoryInfo

        Try
            'add length of each file
            For Each objFileInfo In objDir.GetFiles()
                lngDirSize += objFileInfo.Length
            Next
            'call recursively to get sub folders
            'if you don't want this set optional
            'parameter to false
            If IncludeSubFolders = True Then
                For Each objSubFolder In objDir.GetDirectories()
                    lngDirSize += GetFolderSize(objSubFolder.FullName, lngDirSize)
                Next
            End If
        Catch Ex As Exception
        End Try

        Return lngDirSize

        ' You do not want to do this here, you want to do it once ater the initial call
        'If lngDirSize > 0 Then
        '    Return BytesToMegabytes(lngDirSize)
        'Else
        '    Throw New Exception("Invalid or unreadable directory")
        '    Exit Function
        'End If
    End Function

    Private Function BytesToMegabytes(ByVal Bytes As Long) _
    As Long
        Dim dblAns As Double
        dblAns = (Bytes / 1024) / 1024
        BytesToMegabytes = Format(dblAns, "###,###,##0.00")
    End Function
0
 
Fernando SotoRetiredCommented:
Change my file path in my last post
0
 
Fernando SotoRetiredCommented:
Hi webkiwi1;

As I stated in my post above you want to convert the bytes to megabytes at the very end and not after each directory is completed being tallied up. Also the exception you are throwing is not really true, "Invalid or unreadable directory", because directory info only returns valid names. Also a directory may have no files in it and will have zero bytes returned which does not make it a invalid directory.

       If lngDirSize > 0 Then
           Return BytesToMegabytes(lngDirSize)
       Else
           Throw New Exception("Invalid or unreadable directory")
           Exit Function
       End If

Fernando
0
 
webkiwi1Author Commented:
Got both to work. For some reason the calculated value using Fernado's was off somewhere, but function still worked. Thanks guys for the fast and accurate responses.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.