VB Script problem

bsharath
bsharath used Ask the Experts™
on
Hi,

This script has to add a a group to all users in the OU.

' GroupAddLots.vbs
' Free example VBScript to add users to a group.
' Author Guy Thomas http://computerperformance.co.uk/
' Version 2.3 - May 2005
' ---------------------------------------------------------------'
Option Explicit
Dim objRootLDAP, objGroup, objUser, objOU
Dim strOU, strGroup, strDNSDomain
Dim intCounter

' Check these objects referenced by strOU, strGroup exist in strOU
strOU = "OU=Newport,"
strGroup = "CN=Coal Porters,"

' Bind to Active Directory and get LDAP name
Set objRootLDAP = GetObject("LDAP://RootDSE")
strDNSDomain = objRootLDAP.Get("DefaultNamingContext")

' Prepare the OU and the Group
Set objGroup = GetObject("LDAP://"& strGroup _
& strOU & strDNSDomain)
Set objOU =GetObject("LDAP://" & strOU & strDNSDomain)

' On Error Resume next
intCounter = 1
For Each objUser In objOU
   If objUser.Class = lcase("User") then
      objGroup.add(objUser.ADsPath)
      intCounter = intcounter +1
   End If
Next
WScript.Echo strGroup & " has " & intCounter & " new members"

Wscript.Quit

End of Add lots of members to group VBScript


I get this error.

---------------------------
Windows Script Host
---------------------------
Script:      C:\Add lots of users to a group.vbs
Line:      22
Char:      1
Error:      There is no such object on the server.
Code:      80072030
Source:       (null)

---------------------------
OK  
---------------------------
can anyone help me.Can you modify this if possible to take the names ffrom the file instead of the OU.

REgards
Sharath
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
strOU = "OU=Newport," => is this correct for your situation? This is assumed to be located directly under the root in the domain.
strGroup = "CN=Coal Porters," => is this correct for your situation? The group is assumed to be in the same OU as the users you want to add.

Author

Commented:
No this is Incorrect OU names this does not suit my Domain.

I have made the changes but still get the same error.

Can you help me in changing the script so that it does not take the user names from the OU rather take the names from a file i have.

Or you you know a script which can do this please give me.


Author

Commented:
Any help....
Become a Microsoft Certified Solutions Expert

This course teaches how to install and configure Windows Server 2012 R2.  It is the first step on your path to becoming a Microsoft Certified Solutions Expert (MCSE).

Hi again,
A quick search on the internet and I found this:

'===========================================================================
' Program: autg.vbs (Add users to group)
'
' Purpose: Reads a list of usernames from a text file and adds them to the
'          specified group in Active Directory.
'
'          By default it validates the group name and user names, but does
'          not actually add them.  To perform the add you must use the
'          /di (DoIt) switch.
'    
'          The use of a log file is mandatory - to document what was done
'          in case of the need to roll-back.
'
' Usage:   autg  group_name  user_file_path  log_file_path  [ /di]
'
' Note:    This script will only work if the user running the script has the
'          necessary rights to add the users to the group.  (No message is
'          given if you don't - the additions simple fail.)
'
' Author:  Jim Roberts
'
' Version: 1.1 26th October 06
'
' History: 1.1 - Fixed problem with interpreting command line arguments.
'===========================================================================
Option Explicit

Const programName = "autg.vbs"
Const verNum = "1.1"

' Globals
Dim group          ' Short name of group
Dim groupDN        ' Distinguished name of group

Dim userFSO        ' File system object to read user file
Dim userFileName   ' User file name
Dim objUserFile    ' Object representing user file

Dim logFSO         ' File system object to write log file
Dim logfileName    ' Log file name
Dim objLogFile     ' Object representing log file

Dim domain         ' The current domain
Dim dicUsers       ' A dictionary used to check for duplicate names
                   ' and store user's distinguished names

Dim preProcessedOK ' Flag to indicate that user names were all OK
Dim doIt           ' Flag to indicate that we should add users


'==========================================================
' Main program
'==========================================================
initialise
getCommandLineArguments
groupDN = getGroupDN( group, Domain )
If Not verifyFileExists( userFileName ) Then
  WScript.Echo "Cannot find user file"
  WScript.Quit
End If
checkCanCreateLogFile
' preProcess
openUserFile
  checkUserNames
closeUserFile
If Not preProcessedOK Then
  WScript.Echo "Processing failed - please fix errors in user file then try again"
  WScript.Echo "(No log file written)."
  WScript.Quit
End If
If doIt Then
  ' Make the additions
  openUserFile
    createLogFile
      addUsersToGroup
    closeLogFile
  closeUserFile
Else
  WScript.Echo "(No log file written)."
  WScript.Echo "Use /di switch to actually add users to group."
End If
WScript.Quit



'==========================================================
' Try to open users file
'==========================================================
Sub openUserFile
  On Error Resume Next
    Set userFSO = CreateObject( "scripting.FileSystemObject" )
    Set objUserFile = userFSO.OpenTextFile( userFileName )
    If Err.Number <> 0 Then
      On Error Goto 0
      WScript.Echo "Unable to open user file: " & userFileName
      WScript.Quit
    End If
End Sub



'==========================================================
' Try to create log file
'==========================================================
Sub createLogFile
  On Error Resume Next
    Set logFSO = CreateObject( "scripting.FileSystemObject" )
    Set objLogFile = logFSO.CreateTextFile( logFileName )
    If Err.Number <> 0 Then
      On Error Goto 0
      WScript.Echo "Unable to create log file for writing: " & logfileName
      WScript.Quit
    End If
End Sub



'==========================================================
' Close the user file
'==========================================================
Sub closeUserFile
  objUserFile.Close
End Sub



'==========================================================
' Close the log file
'==========================================================
Sub closeLogFile
  objLogFile.Close
End Sub



'==========================================================
' Check users in file exist and no duplicates
'==========================================================
Sub checkUserNames
  Dim userCount   ' Counter
  Dim userName    ' SAM name of current user
  Dim userDN      ' Distinguished name of current user
  Dim errorCount  ' Error count
 
  WScript.Echo "Validating names in user file."
  userCount = 0  
  errorCount = 0
  Do Until objUserFile.AtEndOfStream
    userCount = userCount + 1
    userName = Trim( objUserFile.ReadLine )
    ' See if the name exists in AD
    If Not getUserDetails( userName, userDN ) Then
      ' User does not exist
      WScript.Echo "Line " & userCount & " - Non existent user : " & userName
      errorCount = errorCount + 1
    Else
      ' User name exists
      ' Have we seen him before?
      If dicUsers.Exists ( userName) Then
        ' Yes we have
        WScript.Echo "Line " & userCount & " - Duplicate user    : " & userName
        errorCount = errorCount + 1      
      Else
        ' No we haven't - so add him to the dictionary.
        dicUsers.Add userName, userDN
      End If
    End If
  Loop
  WScript.Echo "  " & userCount & " lines processed. " & errorCount & " error(s)."
  If errorCount = 0 Then
    preProcessedOK = True
  Else
    preProcessedOK = False
  End If
End Sub


'==========================================================
' Add users to the group
'==========================================================
Sub addUsersToGroup
  Dim lineCount   ' Counts lines processed
  Dim addCount    ' Counts additions
  Dim userName    ' SAM name of current user
  Dim line        ' String to be written
  Dim objGroup    ' Object representing group
 
  ' Create group object  
  Set objGroup = GetObject("LDAP://" & groupDN)

  line = "Adding users to group: " & group
  objLogFile.WriteLine( line )
  WScript.Echo line
 
  lineCount = 0
  addCount = 0
  Do Until objUserFile.AtEndOfStream
    userName = Trim( objUserFile.ReadLine )
    On Error Resume Next
    objGroup.Add( "LDAP://" & dicUsers( userName ) )  
    If Err.Number <> 0 Then
      Err.clear
      On Error Goto 0
      line = "    Failed to add " & userName & " to " & group & "  <<<<<<<"
    Else
      line = "  Adding " & userName & " to " & group    
      addCount = addCount + 1
    End If
    objLogFile.WriteLine( line )
    Wscript.Echo line
    lineCount = lineCount + 1
  Loop
  line = lineCount & " users processed " & addCount & " added to group."
  objLogFile.WriteLine( line )
  WScript.Echo line
End Sub


'==========================================================
' Given a SAM username the first parameter, it attempts
' to return the corresponding distinguished name in the
' second parameter.  The function returns true or false
' depending upon whether or not the user was found.
'==========================================================
Function getUserDetails( ByVal SAM, ByRef userDN )
  Const STR_SCOPE = "subtree"
  Const strAttributeList = "sAMAccountname,distinguishedName"
 
  Dim intRecordCount   ' Number of matching records found
  Dim objCommand       ' Used in building AD query
  Dim objConnection    ' Used in building AD query
  Dim strFilterText    ' Defines what to search for
  Dim strQueryText     ' Holds text of LDAP query
  Dim objRecordSet     ' Set of records returned by name look up
   
  ' Build query
  strFilterText = "(&(objectCategory=person)(objectClass=user)(sAMAccountname=" & SAM & "))"
  strQueryText = " 0 Then
    WScript.Echo vbTab & "LDAP query failed."
    WScript.Echo "Error number      = " & Err.Num
    WScript.Echo "Error description = " & Err.Description
    Err.clear
    WScript.Quit
  Else
    On Error Goto 0
    intRecordCount = 0
    Do Until objRecordSet.EOF
      intRecordCount = intRecordCount + 1
      userDN = objRecordSet.Fields("distinguishedName")
      objRecordSet.MoveNext
    Loop
  End If  
  Select Case intRecordCount
    Case 0      
      getUserDetails = False
    Case 1
      getUserDetails = True
    Case Else  
      WScript.Echo "Internal error - More than one user found for a single name."
  End Select
End Function


'==========================================================
' Reads command line arguments
'==========================================================
Sub getCommandLineArguments
  Dim argCount
  Dim param
  Dim i
 
  argCount = WScript.Arguments.Count  
  Select Case argCount
    Case 1, 2
      param = LCase( WScript.Arguments(0) )
      If param = "/ver" Then
        WScript.Echo "Program name: " & programName
        WScript.Echo "Version:      " & verNum
        WScript.Quit          
      Else
        DisplayUsageInstructions
      End If      
    Case 3, 4
      group        = LCase( WScript.Arguments(0) )
      userFileName = LCase( WScript.Arguments(1) )      
      logfileName  = LCase( WScript.Arguments(2) )            
      If argCount = 4 Then
        If LCase( WScript.Arguments( 3 ) ) = "/di" Then
          doIt = True
        End If
      End If
    Case Else
      DisplayUsageInstructions
  End Select
End Sub


'==========================================================
' Initialise globals
'==========================================================
Sub initialise
  ' Initialise user list - used to look for duplicates
  Set dicUsers = CreateObject("scripting.dictionary")
  ' Set domain
  domain = getDomain()
  preProcessedOK = False
  doIt           = False
End Sub



'==========================================================
' Establish current domain
'==========================================================
Function getDomain
  Dim objRootDSE
  Set objRootDSE = GetObject("LDAP://rootDSE")
  getDomain = objRootDSE.Get("defaultNamingContext")
End Function



'======================================================================================
' Write Usage instructions to the screen.
'======================================================================================
Sub DisplayUsageInstructions
  WScript.Echo "Program: autg.vbs (Add users to group)"
  WScript.Echo
  WScript.Echo "Purpose: Reads a list of usernames from a text file and adds them to the"
  WScript.Echo "         specified group in Active Directory."
  WScript.Echo
  WScript.Echo "         By default it validates the group name and user names, but does"
  WScript.Echo "         not actually add them.  To perform the add you must use the"
  WScript.Echo "         /di (DoIt) switch."
  WScript.Echo
  WScript.Echo "         The use of a log file is mandatory - to document what was done"
  WScript.Echo "         in case of the need to roll-back."
  WScript.Echo
  WScript.Echo "Usage:   autg  group_name  user_file_path  log_file_path  [ /di]"
  WScript.Echo
  WScript.Echo "Note:    This script will only work if the user running the script has the"
  WScript.Echo "         necessary rights to add the users to the group.  (No message is"
  WScript.Echo "         given if you don't - the additions simple fail.)"
  WScript.Echo
  WScript.Echo "Author:  Jim Roberts"
  WScript.Echo
  WScript.Echo "Version: 1.1    26th October 06"
  WScript.Quit
End Sub



'==========================================================
' Given the group SAM name and the domain, searchs AD to
' and returned the distinguished name of the group.
' Terminates if cannot find the group.
'==========================================================
Function getGroupDN( ByVal groupShortName, ByVal strDomain )
  Dim intRecordCount   ' Number of matching records found
  Dim objCommand       ' Used in building AD query
  Dim objConnection    ' Used in building AD query
  Dim strFilterText    ' Defines what to search for
  Dim strQueryText     ' Holds text of LDAP query
  Dim objRootDSE       ' Used to get current domain
  Dim objRecordSet     ' Record set returned by LDAP query
  Dim tempFQDN         ' Temporarily holds FQDN
  Dim tempType         ' Temporarily holds group type

  Const strAttributeList = "distinguishedName,groupType,samAccountName"
  Const STR_SCOPE = "subtree"

  ' Build query
  strFilterText = "(&(objectCategory=group)(cn=" & groupShortName & "))"
  strQueryText = " 0 Then
    ' Query failed
    Wscript.Echo "Internal error: Group name lookup failed."
    WScript.Echo "Error number = " & Err.Number
    WScript.Quit
  Else
    ' Query succeeded
    ' Count number of records returned
    Select Case objRecordSet.RecordCount
      Case 0
        WScript.Echo "Cannot find group: "& groupShortName
        WScript.Echo "Script terminating"
        WScript.Quit
      Case 1
        getGroupDN = objRecordSet.Fields( "distinguishedName" )
      Case Else
        WScript.Echo "Group name is ambiguous.  Please refine."
        intRecordCount = 0
        Do Until objRecordSet.EOF
          intRecordCount = intRecordCount + 1
          WScript.Echo  "   " & objRecordSet.Fields("distinguishedName")
         objRecordSet.MoveNext
        Loop        
        WScript.Echo "Script terminating."
    End Select
  End If
End Function



'======================================================================================
' Check a file exists.
'======================================================================================
Function verifyFileExists( ByVal strInputFile )
  Dim objFSO
  Set objFSO = CreateObject( "scripting.FileSystemObject" )
  verifyFileExists = objFSO.FileExists( strInputFile )
End Function




'======================================================================================
' Check can create output file.
'======================================================================================
Sub checkCanCreateLogFile
  Dim errNum
 
  ' Check if file already exists
  If verifyFileExists( logfileName ) Then
    WScript.Echo "Specified output file already exists."
    WScript.Echo "Please specify the name of a new file."
    WScript.Quit
  End If
  ' If here, then file does not exist,
  ' so try to temporarily create it
  Set logFSO = CreateObject("Scripting.FileSystemObject")
  On Error Resume Next
    Set objLogFile = logFSO.CreateTextFile( logFileName )
    errNum = Err.Number
    Err.Clear
  On Error Goto 0
  If ErrNum <> 0 Then
    ' Couldn't make the file
    WScript.Echo "Unable to create log file: " & logFileName
    WScript.Quit
  Else
    ' Succeeded, so delete file.
    objLogFile.Close
    logFSO.DeleteFile( logfileName )
  End If
End Sub

Author

Commented:
Can you please tell me hat this script does exactly.

What are the changes i need to do in the script.

Shouls i create any other file other than the script.

You should not need to make changes.
Please read the comments at the top of the script for instructions on use.

Author

Commented:
Can you please tell me what this script does exactly.

Author

Commented:
Should i put all this in a single vbs file
yes, all in a single file. Save as autg.vbs
then open a command prompt to the folder where the script is stored, and run the command

autg  group_name  user_file_path  log_file_path

where user_file_path is the path to the textfile containing the user names you want to add, and log_file_path is the filename of the logfile this script will generate.
After running this command, no change is made to the group (it is just a test), but open the log and check that the
result is good. Then you can run the same command, but add /di

autg  group_name  user_file_path  log_file_path /di

Now the users are really added to the group (/di = Do It).

Author

Commented:
I get this error.

---------------------------
Windows Script Host
---------------------------
Script:      C:\autg.vbs
Line:      238
Char:      26
Error:      Unterminated string constant
Code:      800A0409
Source:       Microsoft VBScript compilation error

---------------------------
OK  
---------------------------
Hmmm... as many scripts you can find on the Internet, this has a few serious bugs. I'll try to fix it, may take a couple of hours.

Author

Commented:
Ok Thx............
Ok:
1. Download a bug-free version of the script here: http://the-roberts-family.net/vbscript/autg.zip

2. Run the command line:
cscript.exe autg.vbs  group_name  user_file_path  log_file_path
This will display information, if the usernames are valid, like:

Microsoft (R) Windows Script Host Version 5.6
Copyright (C) Microsoft Corporation 1996-2001. All rights reserved.

Validating names in user file.
  2 lines processed. 0 error(s).
(No log file written).
Use /di switch to actually add users to group.

3. If no errors, run the script again with the /di option:
cscript.exe autg.vbs  group_name  user_file_path  log_file_path /di
4. verify the logfile

Author

Commented:
I did this.

cscript.exe autg.vbs  chennai_fs-sg c:\new  c:\log_file_path

Chennai_fs-sg is a group
Should i create a file New and a log file
Should i put any data in those files.

Author

Commented:
Sorry

Should i create a file user_file_path and enter any content in it.
the first file (user_file_path) should be an existing text file containing the user names. The second file (log_file_path) should not exists, and is created in step 3.
example:
cscript.exe autg.vbs  chennai_fs-sg c:\new_users.txt  c:\logfile.txt

Author

Commented:
I got his


C:\>cscript.exe autg.vbs  chennai_fs-sg c:\user.txt  c:\logfile.txt
Microsoft (R) Windows Script Host Version 5.6
Copyright (C) Microsoft Corporation 1996-2001. All rights reserved.

Validating names in user file.
  2 lines processed. 0 error(s).
(No log file written).
Use /di switch to actually add users to group.

I put 2 users into the users file
Ok, the test is succesful. Now move on to step 3 to actually add the users to the group.

Author

Commented:
What this script does is Searches the user.txt and add all the users in that file to a group.

Am i correct.

Will it take some time to get updated.

I get this now.

C:\>cscript.exe autg.vbs  chennai_fs-sg c:\user.txt  c:\log_file_path /di
Microsoft (R) Windows Script Host Version 5.6
Copyright (C) Microsoft Corporation 1996-2001. All rights reserved.

Validating names in user file.
  3 lines processed. 0 error(s).
Adding users to group: chennai_fs-sg
    Failed to add sharathr to chennai_fs-sg  <<<<<<<
    Failed to add enochj to chennai_fs-sg  <<<<<<<
  Adding selvakumark to chennai_fs-sg
3 users processed 1 added to group.
"Am i correct.">Yes, that was your original question, and it is also stated in the script:
"Purpose: Reads a list of usernames from a text file and adds them to the
'          specified group in Active Directory
PLEASE READ THE RESPONSES (I don't mind answering complicated questions, but I hate repeating myself)

" 3 lines processed"> In your previous post you had 2 users, so you changed it. The user names are found, so they exist. Were the users "sharathr" and "enochj" already member of the group??????? If so, the script works correctly.

Author

Commented:
Thanks a lot i just chcked my ADS the users are now members of the group.

I was prety confused with what i was doing could not get along with the never ending huge code.Sorry to ask you so many questions.But at last you did it.

Thanks a lot again

Ok, good luck!

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial