asked on

Look over this class

Hello everyone thanks for all your support. I have another question. I modified
this class to be able to have a user set a timer and then store the total number
of Milliseconds to a variable. I then need to pass this to a TimerClass or should
i just have it as a inner class in this one?

Can you go over it and see if i got it right.

I added these If statement to stop the down button from working if the int was 0
Will these work?

if (hr = 0) // stoping the down button from working when the number is 0
{
this.guiPanel.downButton.enablied(false)
}

if (hr = 0) // stoping the down button from working when the number is 0
{
this.guiPanel.downButton.enablied(false)
}

I also added these are these correct?

int hrms = hr * 60 * 60 * 1000; // convert hr to Milliseconds
int minms min * 60 * 1000; // convert min to Milliseconds
userTimerAlarm = hrms + minms; // store total Milliseconds

package my.test;

import java.awt.event.ActionEvent;
import javax.swing.AbstractAction;
import javax.swing.JLabel;
import my.test.GuiPanel.Mode;

class AdvanceModeAction extends AbstractAction
{
private final GuiPanel guiPanel;

public AdvanceModeAction(GuiPanel guiPanel, String name)
{
super(name);
this.guiPanel = guiPanel;
}

public void actionPerformed(ActionEvent e)
{
String cmd = e.getActionCommand();

if (this.guiPanel.currentMode == Mode.Timer)
{
this.guiPanel.timeDisplay.setText("00:00:00"); //Reset time to 0

if (cmd.equals(this.guiPanel.hourButton))
{
selected = HR;
}
else if (cmd.equals(this.guiPanel.minutesButton))
{
selected = MIN;
}
else if (cmd.equals(this.guiPanel.upButton))
{
if (selected == HR)
{
String time = this.guiPanel.timeDisplay.getText();
String[] splitTime = time.split(":");

int hr = Integer.parseInt(splitTime[0].trim());
time = Integer.toString(hr + 1) + ":" + splitTime[1] + ":" + splitTime[2];

guiPanel.timeDisplay.setText(time); //modified time
}
else if (selected == MIN)
{
String time = this.guiPanel.timeDisplay.getText();
String[] splitTime = time.split(":");

int min = Integer.parseInt(splitTime[1].trim());
time = splitTime[0] + ":" + Integer.toString(min + 1) + ":" + splitTime[2];

guiPanel.timeDisplay.setText(time); //modified time
}
}
else if (cmd.equals(this.guiPanel.downButton))
{
if (selected == HR)
{
String time = guiPanel.timeDisplay.getText();
String[] splitTime = time.split(":");

                          if (hr = 0) // stoping the down button from working when the number is 0
{
this.guiPanel.downButton.enablied(false)
}

                         int hr = Integer.parseInt(splitTime[0].trim());
time = Integer.toString(hr - 1) + ":" + splitTime[1] + ":" + splitTime[2];

guiPanel.timeDisplay.setText(time); //modified time
}
else if (selected == MIN)
{
String time = guiPanel.timeDisplay.getText();
String[] splitTime = time.split(":");

int min = Integer.parseInt(splitTime[1].trim());

                               if (min = 0) // stoping the down button from working when the number is 0
{
this.guiPanel.downButton.enablied(false)
}

                        time = splitTime[0] + ":" + Integer.toString(min - 1) + ":" + splitTime[2];

guiPanel.timeDisplay.setText(time); //modified time
}
}
else if (cmd.equals(this.guiPanel.okButton.getText()))
{
//time should be stored in timerDisplay

this.guiPanel.alarmStarted = true;

                        Int hrms = hr * 60 * 60 * 1000; // convert hr to Milliseconds
                        Int minms min * 60 * 1000; // convert min to Milliseconds
                        userTimerAlarm = hrms + minms; // store total Milliseconds

                        this.guiPanel.alarmTime = this.guiPanel.timeDisplay.getText();
selected = HR;
this.guiPanel.currentMode = Mode.Clock;
this.guiPanel.modeDisplay.setText(this.guiPanel.currentMode.toString());
this.guiPanel.dispProv.setDispListener(this.guiPanel.timeDisplay);
}
}
}

}

CEHJ

You can use the MyTimer class in your other question if the Mode is correct. I would write the if statements as a switch/case statement as in my earlier examples