We help IT Professionals succeed at work.

PHP Code problems...  please check for errors - or post better code

innercproductions
on
281 Views
Last Modified: 2008-07-17
I'm having trouble with the following code working correctly.
It keeps showing the information in the "logged in" area without having to be logged in.
I don't have anyone else to check it for errors.
Can anyone help?



---------------------------------------------------------------------------------------------------------------------------

<?
session_start(); // start session.

//Includes the header which also includes the variables file
require('inc_header.php');

// custom error function
function custom_die($errormsg) {
      print $errormsg;
      require("inc_footer.php");
      exit();
} // end of custom_die function


// checks to see if the managers account number and password are set
if(!isset($manageracctnum) | !isset($manageracctpass)) {

// the below area is displayed when logged in......
?>


logged in.....
<br />
This is display when the user has logged in.

<?
include('inc_footer.php');

// the above area is displayed when logged in...
exit();
}

// register account number and password as session variables
session_register("manageracctnum");
session_register("manageracctpass");

$db = mysql_connect($database_host, $database_username, $database_password) or die ($database_couldnotconnect);
mysql_select_db($database_name,$db);

$query = "SELECT managerpassword FROM $companytable_name WHERE companynumber = '$manageracctnum'";
$result = mysql_query($query) or custom_die($database_errorinquery);

$fetch_em = mysql_fetch_array($query);
$numrows = mysql_num_rows($query);

if($numrows != "0" & $managerpassword == $fetch_em["manageracctpass"]) {
            $valid_user = 1;
}
else {
            $valid_user = 0;
}
if (!($valid_user)) {
            session_unset();   // Unset session variables.
            session_destroy(); // End Session we created earlier.
// escape from php mode.

?>


<div class="error">
Incorrect login information, please try again.
<br>
You must login to access the Manager Administration Area.
</div>



<form action="<?=$_SERVER['PHP_SELF']?><?if($_SERVER['QUERY_STRING']>' '){echo '?'.$_SERVER['QUERY_STRING'];}?>" method="POST">


<table cellpadding="5" cellspacing="5"><tr>
<td valign="top">

Manager Account Number ( 6 characters ):
<br>
<input type="text" name="manageracctnum" size="30" tabindex="1" maxlength="5">

</td><td valign="top">

Password:
<br>
<input type="password" name="manageracctpass" size="30" tabindex="2" maxlength="20">

</td><td valign="bottom">

<input type="submit" value="Login" tabindex="3">

</td>
</tr>
<tr>
            <td align="left" valign="top" colspan="3">
                  &nbsp;
            </td>
      </tr>
</table>

</form>




<?
include ("inc_footer.php");
?>

<?
exit();
}
?>


Comment
Watch Question

This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION

Gain unlimited access to on-demand training courses with an Experts Exchange subscription.

Get Access
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Empower Your Career
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE

Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Unlock the solution to this question.
Join our community and discover your potential

Experts Exchange is the only place where you can interact directly with leading experts in the technology field. Become a member today and access the collective knowledge of thousands of technology experts.

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.