• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1326
  • Last Modified:

properly delete pointer - hopefully a quickie

The loop below is toggled by a "preview" button. It show the images just fine, but it runs my memory up fast because if I put the line "cvReleaseImage(&pimage_copy) anywhere to release the memory, I get a passing null pointer even though I think I am destroying pointers as I create them. How do I reconcile? Should  I use smart pointers?


while (CameraStatusInst.Start_Button_Status(false, false))
	{
     IplImage* pimage_copy = contour_image;
 
                                    if (pimage_copy != NULL)
                                        {
                                         int key=0;
                                         cvNamedWindow("Mouse Vision", 1);
                                         cvShowImage("Mouse Vision", pimage_copy);
                                         key = cvWaitKey(20);
                                        //cvReleaseImage(&pimage_copy)    <-------------works when commented out
                                        }
                                        else
                                        {
                                        cvReleaseImage(&pimage_copy);
                                        }
 
 
    }

Open in new window

0
Wanderinglazyeye
Asked:
Wanderinglazyeye
  • 2
  • 2
  • 2
  • +2
4 Solutions
 
jkrCommented:
Well, how are you initializing 'contour_image'? If you aren't using 'cvCloneImage()', there is no need to release it. See the demo code at http://softintegration.com/products/thirdparty/opencv/demos/
0
 
Jaime OlivaresSoftware ArchitectCommented:
try with:
while (CameraStatusInst.Start_Button_Status(false, false))
{
     IplImage* pimage_copy = cvCloneImage(contour_image);
 
    if (pimage_copy != NULL)
    {
          int key=0;
          cvNamedWindow("Mouse Vision", 1);
          cvShowImage("Mouse Vision", pimage_copy);
          key = cvWaitKey(20);
          cvReleaseImage(&pimage_copy)
    }
}
    

Open in new window

0
 
itsmeandnobodyelseCommented:
>>>> cvReleaseImage(&pimage_copy)
you pass the 'address' of pimage_copy to cvReleaseImage. So cvReleaseImage takes a IplImage** ?? That is strange beside cvReleaseImage would expect an array of IplImage pointers rather than a single pointer.

>>>> while (CameraStatusInst.Start_Button_Status(false, false))
>>>> {
>>>>     IplImage* pimage_copy = contour_image;

I can't see how that in that while loop you ever would get a pimage_copy == NULL. Even then, why do you call cvReleaseImage(&pimage_copy); with the address of a NULL pointer. What do you expect from that?

I would guess the above loop would fail in the second iteration cause I can't see how contour_image could get a different value (or NULL) in the meantime.

Regards, Alex

0
Get expert help—faster!

Need expert help—fast? Use the Help Bell for personalized assistance getting answers to your important questions.

 
Deepu AbrahamR & D Engineering ManagerCommented:
Hi there,

IplImage* pimage_copy = contour_image;  ---> Seems like this is not filling the correct values here..(it may not be null but some junk values)

Could you be able to check what is happening inide the function cvReleaseImage()

Best Regards,
DeepuAbrahamK



0
 
WanderinglazyeyeAuthor Commented:
Its filling the correct values - the preview window opens up, and the expected images are seen. I removed the loop (pimage_copy == NULL), it works fine. yeah my brain farted.

IplImage* pimage_copy = cvCloneImage(contour_image);
Tried this and releasing it, get run time errors.

Problem is a memory leak when I open the preview window and stops when I close it. It jumps by 10k/second (about) until program crashes. I preview the images by using the sharing image  solution shown in another EE topic that was solved earlier.  My preview code is a thread launched from a GUI event.

Would it be helpful to anyone to post the entire thread?
0
 
jkrCommented:
Well, how are you creating 'clone_image' right now?
0
 
itsmeandnobodyelseCommented:
>>>> Would it be helpful to anyone to post the entire thread?
Yes, and maybe you can tell what is the idea behind the while loop? Or did you drop the loop?  
0
 
WanderinglazyeyeAuthor Commented:
I dropped the loop. In fact, I dropped the threads. I took your idea about the evaluating whether threads were necessary, and simply made two program versions. One with threads, one without. What I found was that the version without thread BLAZED. Still, it provided a learning experience.

Thanks ItsMe

WLE
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

  • 2
  • 2
  • 2
  • +2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now