Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

x
?
Solved

Top Percent with varable

Posted on 2007-11-16
9
Medium Priority
?
750 Views
Last Modified: 2012-08-14
I have the following query in a stored procedure:

insert into @tblTopTenPct
Select DLID = t1.DLID, Qty = t1.Qty, Base = t1.Base, xMonth = t1.xMonth, Issue = 'Old type'
FROM (SELECT TOP 10 Percent * FROM @DLList) AS t1
Where Datediff(mm,Base,GetDate()) > (@EldestCrit * 12)

Works fine. But now the users want to be able to change the percent at runtime
FROM (SELECT TOP 10 Percent * FROM @DLList) AS t1
My understanding is in Sql Server 2005 I can replace 10 percent with a varible @pct
But Im using Sql Server 2000.
I was trying to use dynamic sql but run in the problem with using variable tables. My thougt was to take the X percent a store it in a seperate table within my procedure and just select * in my from statement above.
Any Ideas...
0
Comment
Question by:MadIce
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
  • 2
  • +2
9 Comments
 
LVL 31

Expert Comment

by:James Murrell
ID: 20301781
0
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 20301782

in sql 2000, you cannot do that with PERCENT, unless you would make it dynamic sql
0
 

Author Comment

by:MadIce
ID: 20301902
I tried this:
set @sql = 'Insert into @TopPct Select Top ' + @EldestPercent + ' Percent * from @DLList'
Execute (@Sql)

@TopPct and @DLList'  are tables and I dont think thats allowed in dynamic sql
0
Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 20301920
unfortunately, you cannot use table variables inside dynamic sql unless they are declare altogether inside that same dynamic sql.

0
 
LVL 75

Expert Comment

by:Anthony Perkins
ID: 20301955
Your best bet is to add the entire resultset to a temporary table or variable of type table that has an IDENTITY column in the correct order. You can then easily calculate the percent based on the total number of rows added (@@ROWCOUNT) and so do something like this:

Set @SomeMaxValue = @@ROWCOUNT * @YourPercent / 100

Select *                               -- Replace * with your column names
From @YourTempTable
Where ID Between 1 And @SomeMaxValue
0
 
LVL 75

Accepted Solution

by:
Anthony Perkins earned 2000 total points
ID: 20301967
Missed the ORDER BY clause it should be:

Set @SomeMaxValue = @@ROWCOUNT * @YourPercent / 100

Select *                               -- Replace * with your column names
From @YourTempTable
Where ID Between 1 And @SomeMaxValue
Order By ID

This way you avoid the whole dynamic SQL mess.
0
 
LVL 23

Expert Comment

by:Racim BOUDJAKDJI
ID: 20304083
use dynamic SQL...

--Stored procedure creation
create procedure spr_percent_query(@percentage smallint)
as
begin
       declare@string_execute1 varchar(1000)
       set @string_execute1 = 'insert into @tblTopTenPct
       Select DLID = t1.DLID, Qty = t1.Qty, Base = t1.Base, xMonth = t1.xMonth, Issue = 'Old type'
       FROM (SELECT TOP ' + @percentage + ' Percent * FROM @DLList) AS t1
       Where Datediff(mm,Base,GetDate()) > (@EldestCrit * 12)'
       exec (@string_execute1)
end
go

--Usage
exec spr_percent_query 20 --> top 20 percent

Hope this helps...
0
 

Author Closing Comment

by:MadIce
ID: 31409665
Sorry for delay. Had a problem and wasn't sure of the cause. I was trying something simular when you posted your answer. answer gave me what I needed. Thanks
0
 

Author Comment

by:MadIce
ID: 20323150
Thanks, that's worked out fine.
0

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

A Stored Procedure in Microsoft SQL Server is a powerful feature that it can be used to execute the Data Manipulation Language (DML) or Data Definition Language (DDL). Depending on business requirements, a single Stored Procedure can return differe…
When trying to connect from SSMS v17.x to a SQL Server Integration Services 2016 instance or previous version, you get the error “Connecting to the Integration Services service on the computer failed with the following error: 'The specified service …
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Using examples as well as descriptions, and references to Books Online, show the different Recovery Models available in SQL Server and explain, as well as show how full, differential and transaction log backups are performed

715 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question