Update Dataset Transaction

I am using UpdateDataset functionality of Enterprise Library 3.1  for batch updates in a Dataset
.I am having  begin Transaction Commit RollbackTransactions in my Code as shown in
http://msdn.microsoft.com/msdnmag/issues/05/10/DataPoints/  (Save Multiple Rows At Once Figure 5).
Its the same I am using too... Is it that we need to have transaction even in stored Procedure..??? Or is it enough to have it in code as shown by this Microsoft Example...
dotnet0824Asked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
JimBrandleyConnect With a Mentor Commented:
The transaction is associated with the connection. If you start a transaction, invoke a stored procedure, then commit or rollback in the code on that connection, you should not put any transaction code in the stored procedure. You can make multiple calls to the database server, and keep them all in one transaction. That is defeated if you add transaction code in your SPs.

Jim
0
 
pavaneeshkumarConnect With a Mentor Commented:
There is no requirement to put transaction in database if you are using in your & wiseversa.

This code will handle the transactions itself.
0
 
dotnet0824Author Commented:
my doubt is that in my stored proc I dont have transactions as I have implemented in code... I DONT HAVE RETURN statements or OUTPUT PARAMETERS (As Batch UPdates doesnot support return parameters or Output Parameters) ....Its clearly given by microsoft. Now if an error occours in stored proc how would the code know that its error occoured
0
Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
pavaneeshkumarCommented:
There is no requirement to put transaction in database if you are using in your code & wiseversa.

This code will handle the transactions itself.
0
 
JimBrandleyCommented:
If an error occurs in the stored procedure, an exception should be thrown by the command object. You can deal with the transaction as:
Try
     Invoke stored procedure
     Commit transaction

Catch ex as Exception
     rollback transaction
     Generate error message to pass back to caller, or re-throw the ecxeption

Finally
     close the connection
End Try

Jim
 
0
 
dotnet0824Author Commented:
an exception should be thrown by the command object
I am using the same code posted in my first message
 http://msdn.microsoft.com/msdnmag/issues/05/10/DataPoints/  (Save Multiple Rows At Once Figure 5).
Should I implement any other than that as per ur statement  (Error should be thrown by Command object, thats not mentioned in the microsoft post)
0
 
JimBrandleyCommented:
The following code is from Figure 4 in that page. Note the try - catch. If you attempt an action in a DB, and that action fails, there is an exception throw. It does not matter if it's a stored procedure or not.

Jim


public void InsertRegionsAndTerritoriesInTransaction(
    ArrayList territories, ArrayList regions)
{
    Database db = DatabaseFactory.CreateDatabase();
    IDbConnection connection = db.GetConnection();
    connection.Open();
    IDbTransaction transaction = connection.BeginTransaction();
 
    try
    {
        string insertRegionProc = "prInsertRegion";
        foreach(RegionEntity newRegion in regions)
        {
            DBCommandWrapper regionCmd =
                db.GetStoredProcCommandWrapper(insertRegionProc);
            regionCmd.AddInParameter("id", DbType.Int32, newRegion.ID);
            regionCmd.AddInParameter("region", 
                DbType.String, newRegion.Description);
            db.ExecuteNonQuery(regionCmd, transaction);
        }
 
        string insertTerritoryProc = "prInsertTerritory";
        foreach(TerritoryEntity newTerritory in territories)
        {
            DBCommandWrapper territoryCmd =
                db.GetStoredProcCommandWrapper(insertTerritoryProc);
            territoryCmd.AddInParameter("id", DbType.Int32,
                newTerritory.ID);
            territoryCmd.AddInParameter("territory", 
                DbType.String, newTerritory.Description);
            territoryCmd.AddInParameter("regionID", 
                DbType.Int32, newTerritory.RegionID);
            db.ExecuteNonQuery(territoryCmd, transaction);
        }
        transaction.Commit();
    }
    catch
    {
        transaction.Rollback();
        throw;
    }
    finally
    {
        if (connection.State == ConnectionState.Open) connection.Close();
    }
}

Open in new window

0
 
dotnet0824Author Commented:
Thanks  very much
0
 
JimBrandleyCommented:
My pleasure. Good luck.

Jim
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.