Solved

fix problem in simple asp login page; add username field

Posted on 2007-11-19
5
406 Views
Last Modified: 2012-06-22
I've got a simple asp login page, but it's got two little problems I need to fix.
1) When login fails, we lose the original target url. We need to keep that information.
2) I need to add a username field.

Who can help?

Thanks!

gesswurker
<%@LANGUAGE="VBSCRIPT" CODEPAGE="65001"%>

<%

dim targetUrl

      If Request.Cookies("PasswordIsValidated") = "true" Then

            Response.Redirect(Replace(Request.QueryString("target"),"gggAmPggg","&"))

      End If

      

      If Request.QueryString("action")="login" Then

            dim pwd

            pwd = "password"

            dim username

            username = "username"

       

            If pwd = Trim(Request.Form("txtPassword")) Then

                  Response.Cookies("PasswordIsValidated") = "true"

                  Response.Redirect(Replace(Request.QueryString("target"),"gggAmPggg","&"))

            Else

                  Response.Redirect("password.asp?result=loginfailed") 'here's where I need to include the target url

            End If

      End If

%>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>
 

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

<title>Login</title>

<link href="bibliography.css" rel="stylesheet" type="text/css" />

<style type="text/css">

<!--

body {

	margin-left: 0px;

	margin-top: 0px;

	margin-right: 0px;

}

-->

</style></head>

<br/>

<body>

<table border="0"><tr><td width="50">&nbsp;</td><td>

    <form action="password.asp?action=login&target=<%=Request.QueryString("target")%>" method="post">

            <% If Request.QueryString("result")="loginfailed" Then %>

                <p>Login failed. Please check that you have entered the correct password.</p>

            <% End If %>

            <table width="100%" border="0" cellspacing="0" cellpadding="0">

              <tr>

                <td width="22%"><h1>Login</h1></td>

                <td width="78%">&nbsp;</td>

              </tr>

              <tr>

                <td height="36" colspan="2">A password is required in order to request items from the AIM-VA Catalog. </td>

              </tr>

              <tr>

                <td height="44">Password: </td>

                <td><input type="password" id="txtPassword" name="txtPassword" /></td>

              </tr>

              <tr>

                <td>&nbsp;</td>

                <td>&nbsp;</td>

              </tr>

              <tr>

                <td><input type="submit" id="btnLogin" name="btnLogin" value="Login" onclick="return ValidateLogin();" /></td>

                <td>&nbsp;</td>

              </tr>

            </table>

            <h2>&nbsp;</h2>

            <p>&nbsp;</p>

            <p>&nbsp;</p>

            <p>&nbsp;</p>

    </form>

</td></tr></table>

</body>

</html>

Open in new window

0
Comment
Question by:GessWurker
  • 3
  • 2
5 Comments
 
LVL 82

Accepted Solution

by:
hielo earned 500 total points
ID: 20313772
Response.Redirect("password.asp?result=loginfailed&target=" & Request.QueryString("target")) 'here's where I need to include the target url
0
 

Author Comment

by:GessWurker
ID: 20313841
I also need a username field along with a validation test.
0
 
LVL 82

Expert Comment

by:hielo
ID: 20313881
<%@LANGUAGE="VBSCRIPT" CODEPAGE="65001"%>
<%
dim targetUrl
      If Request.Cookies("PasswordIsValidated") = "true" Then
            Response.Redirect(Replace(Request.QueryString("target"),"gggAmPggg","&"))
      End If
     
      If Request.QueryString("action")="login" Then
            dim pwd
            pwd = "password"
            dim username
            username = "username"
       
            If pwd = Trim(Request.Form("txtPassword")) AND username = Trim(Request.Form("txtUsename")) Then
                  Response.Cookies("PasswordIsValidated") = "true"
                  Response.Redirect(Replace(Request.QueryString("target"),"gggAmPggg","&"))
            Else
                  Response.Redirect("password.asp?result=loginfailed&target=" & Request.QueryString("target")) ) 'here's where I need to include the target url
            End If
      End If
%>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
 
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Login</title>
<link href="bibliography.css" rel="stylesheet" type="text/css" />
<style type="text/css">
<!--
body {
      margin-left: 0px;
      margin-top: 0px;
      margin-right: 0px;
}
-->
</style></head>
<br/>
<body>
<table border="0"><tr><td width="50">&nbsp;</td><td>
    <form action="password.asp?action=login&target=<%=Request.QueryString("target")%>" method="post">
            <% If Request.QueryString("result")="loginfailed" Then %>
                <p>Login failed. Please check that you have entered the correct password.</p>
            <% End If %>
            <table width="100%" border="0" cellspacing="0" cellpadding="0">
              <tr>
                <td width="22%"><h1>Login</h1></td>
                <td width="78%">&nbsp;</td>
              </tr>
              <tr>
                <td height="36" colspan="2">A password is required in order to request items from the AIM-VA Catalog. </td>
              </tr>
              <tr>
                <td height="44">Username: </td>
                <td><input type="text" id="txtUsername" name="txtUsername" /></td>
              </tr>
              <tr>
                <td height="44">Password: </td>
                <td><input type="password" id="txtPassword" name="txtPassword" /></td>
              </tr>
              <tr>
                <td>&nbsp;</td>
                <td>&nbsp;</td>
              </tr>
              <tr>
                <td><input type="submit" id="btnLogin" name="btnLogin" value="Login" onclick="return ValidateLogin();" /></td>
                <td>&nbsp;</td>
              </tr>
            </table>
            <h2>&nbsp;</h2>
            <p>&nbsp;</p>
            <p>&nbsp;</p>
            <p>&nbsp;</p>
    </form>
</td></tr></table>
</body>
</html>
0
 
LVL 82

Expert Comment

by:hielo
ID: 20313914
Corrections: misspelled username here:
Trim(Request.Form("txtUsename"))

and there is an extra/unmatched closing parenthesis here (which you need to remove):
Response.Redirect("password.asp?result=loginfailed&target=" & Request.QueryString("target")) ) 'here's where I need to include the target url
0
 

Author Comment

by:GessWurker
ID: 20315098
Thanks hielo. It's all working now!
0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

Have you ever needed to get an ASP script to wait for a while? I have, just to let something else happen. Or in my case, to allow other stuff to happen while I was murdering my MySQL database with an update. The Original Issue This was written…
I was asked about the differences between classic ASP and ASP.NET, so let me put them down here, for reference: Let's make the introductions... Classic ASP was launched by Microsoft in 1998 and dynamically generate web pages upon user interact…
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now