• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 2631
  • Last Modified:

MFC, C++: Changing a CButton's icon to a custom icon

Hello,

I have an MFC CButton in an MFC dialog that I'd like to give an icon to, in order to have a proper alpha channel for anti-aliasing, which bitmaps don't seem to offer.

I've set the buttons style to icon in dialog editor (there doesn't seem to be a specific facility for selecting an icon, so I guess it's done in code).

I found this reference on MSDN: http://msdn2.microsoft.com/en-us/library/bd24s672(VS.80).aspx .

This cover's CButton's SetIcon() function.

The following example is given:

myButton.SetIcon( ::LoadIcon(NULL, IDI_QUESTION) );

This works for me - My CButton displays the system question mark icon. However, it does not work with my own icons that are imported into the project. I get the following compiler error:

error C2664: 'LoadIconA' : cannot convert parameter 2 from 'int' to 'LPCSTR'

A generic no conversion found error. Theres no point in doing an explicit typecast either.

What have I done wrong? What have I failed to appreciate?

Regards,
Sternocera
0
sternocera
Asked:
sternocera
  • 8
  • 7
1 Solution
 
Jaime OlivaresSoftware ArchitectCommented:
please send the code portion where you load your icons
0
 
sternoceraAuthor Commented:
Jaime,

I don't load my icons -  IDI_QUESTION refers to an icon created with the resource editor.

I don't know how to load icons.
Thanks,
Sternocera
0
 
Jaime OlivaresSoftware ArchitectCommented:
You said:
>>However, it does not work with my own icons that are imported into the project. I get the following compiler error: error C2664: 'LoadIconA' : cannot convert parameter 2 from 'int' to 'LPCSTR'
>>A generic no conversion found error. Theres no point in doing an explicit typecast either.

So I assumed you have tried to load the icon somewhere.
0
Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

 
sternoceraAuthor Commented:
I've imported an icon(*.ico) into resource editor. I named it something like IDI_MY_ICON.

Thanks
0
 
Jaime OlivaresSoftware ArchitectCommented:
>>I've imported an icon(*.ico) into resource editor. I named it something like IDI_MY_ICON.
this operation doesn't cause the error you mentioned: error C2664: 'LoadIconA' : cannot convert parameter 2 from 'int' to 'LPCSTR'

So, again, please post the line which causes that error message.
0
 
sternoceraAuthor Commented:
I have!

myButton.SetIcon( ::LoadIcon(NULL, IDI_QUESTION) );  // myButton is a CButton

that's all there is to it.
0
 
Jaime OlivaresSoftware ArchitectCommented:
OK, there are some confusing stuff:
IDI_QUESTION is a system icon. To load it you need:
::LoadIcon(NULL, MAKEINTRESOURCE(IDI_QUESTION))

since LoadIcon expects a string pointer in second argument, MAKEINTRESOURCE convert the integer to the proper type.
0
 
Jaime OlivaresSoftware ArchitectCommented:
To load an icon from your application you will need:
::LoadIcon(::AfxGetResourceHandle(), MAKEINTRESOURCE(IDI_MY_ICON))
0
 
sternoceraAuthor Commented:
As I said in my original post, I can get it to work with the system icon IDI_QUESTION. This works:
myButton.SetIcon( ::LoadIcon(NULL, IDI_QUESTION) );

However, this does not work:

myButton.SetIcon( ::LoadIcon(NULL, IDI_MY_ICON_FROM_RESOURC_EDITOR) );  // This is the only place this icon appears in the code

It causes the following error message:

error C2664: 'LoadIconA' : cannot convert parameter 2 from 'int' to 'LPCSTR'

I apologise if I  was unclear about that,
Regards,
Sternocera
0
 
sternoceraAuthor Commented:
Jaime,

I don't have access to my windows machine at the moment. I'll let you know how I get on with it tomorrow,

Thanks,
Sternocera
0
 
Jaime OlivaresSoftware ArchitectCommented:
Ok, finally we have the problematic line:
myButton.SetIcon( ::LoadIcon(NULL, IDI_MY_ICON_FROM_RESOURC_EDITOR) );

it should be:
myButton.SetIcon( ::LoadIcon(NULL, MAKEINTRESOURCE(IDI_MY_ICON_FROM_RESOURC_EDITOR)) );

0
 
sternoceraAuthor Commented:
Jaime,

That doesn't work - the program builds, but my button doesn't display the icon,
Regards,
Sternocera
0
 
Jaime OlivaresSoftware ArchitectCommented:
Sorry, ignore my last comment, I had copied and pasted from your. Try with my previous comment:
myButton.SetIcon( ::LoadIcon(::AfxGetResourceHandle(), MAKEINTRESOURCE(IDI_MY_ICON_FROM_RESOURC_EDITOR)))

By the way, you have to be care with this kind of icon usage.
You must load the icon just once, and before destroying the dialog you have to release it, to avoid a memory leak. So you have to store in a variable previously to using it.
0
 
sternoceraAuthor Commented:
Jaime,

Great, that works!

You talk about memory leaks. If this has caused something to be created on the heap, how can the memory be released?

How can I store in in a variable on the stack so it will be destroyed when it goes out of scope?

Thanks,
Sternocera
0
 
Jaime OlivaresSoftware ArchitectCommented:
You should store as a member in the dialog or window class you are using it.
0

Featured Post

Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

  • 8
  • 7
Tackle projects and never again get stuck behind a technical roadblock.
Join Now