Solved

Control contains javascript not working on IE as firefox

Posted on 2007-11-20
5
386 Views
Last Modified: 2013-11-19
I created an Asp.Net user control which supposed to slide from the very bottom of the page to a up a little.

It works fine as i want on Firefox but its not sliding at all in IE, it just show in the final point on IE.

please take a look at the control code and the method i used to call it from another page "default.aspx page".
and tell me whats wrong i did


Thanks,
<%@ Control Language="C#" AutoEventWireup="true" CodeFile="PopUp.ascx.cs" Inherits="PopUp" %>
 
<script language="javascript" type="text/javascript">
 
var X = 0;
var Y = 0;
    function set(title,message,x,y,time)
    {
       X = x;
       Y = y;
       document.getElementById("popup").style.visibility = 'visible' ;
       document.getElementById("popup").style.zIndex=120000;
       document.getElementById("title").innerHTML = title; //'<div style="padding-top: 0px; padding-left: 170px;"><a href="javascript:HidePopUp();">close</a></div>' + 
       document.getElementById("message").innerHTML =message;
 
var height = (document.all) ? document.body.clientHeight+ 30 : window.innerHeight + 30;
//var width = (document.all) ? document.body.clientWidth : window.innerWidth;
       document.getElementById("popup").style.left=x+'px';
       document.getElementById("popup").style.top= height+'px';//document.body.style.height;//y+20+'px';
       doMove();
       
       var t=setTimeout("HidePopUp()",time)
    }
 
 
    function doMove() 
    {
         document.getElementById("popup").style.top = (parseInt(document.getElementById("popup").style.top)-0.5)+'px'; 
         if(parseInt(document.getElementById("popup").style.top) > Y)
            setTimeout(doMove,2); // call doMove() in 2 msec
    }
        
    function HidePopUp()
    {
      document.getElementById("popup").style.visibility = 'hidden' ;
    }
    
</script>
 
<div id="popup" style="top: 0px; left: 0px; height: 60px; width: 200px; position: absolute;
    visibility: hidden; border-right: black thin solid; border-top: black thin solid;
    border-left: black thin solid; border-bottom: black thin solid; background-color:Fuchsia;">
    <div id="title" style="font: bold 8px verdana; padding-top: 0px; padding-left: 0px;">
        <!--<div style="padding-top: 0px; padding-left: 170px;">
            <a href="javascript:HidePopUp();">close</a>
        </div>-->
    </div>
    <div id="message" style="font: bold 12px verdana;">
    </div>
</div>
 
 
 
 
'--------------------------------------------
I CALL IT WITH THIS CODE:
'--------------------------------------------
 
<input type="button" onclick="javascript:set('Hi','This is Me',parseInt(document.body.clientWidth)-210,parseInt(document.body.clientHeight)+35,5000);" value="set value" />

Open in new window

0
Comment
Question by:AmrNet
  • 3
  • 2
5 Comments
 
LVL 29

Accepted Solution

by:
Göran Andersson earned 125 total points
ID: 20322593
When I tried it, it didn't show at all. You set it to move five pixels, from one position outside the window to another positon outside the window.

A timeout of 2 milliseconds is totally off for something that is showing something on the screen. That is about ten times the update rate of your screen, so your are doing a lot of movement that noone ever will be able to see. You should use something closer to the update rate of the screen.

Moving an element half a pixel is pointless. The value will just be rounded when it's displayed. Also, as you used parseInt to read the value, the fraction part would be discarded when you read it.

If you keep the position of the element in a variable, you don't have parse the style to get the position of the element.

I added a parameter to the set function to specify the maximum movement distance, and changed the x and y parameters to specify the size of the element instead.
<script type="text/javascript">
 
function $(id) { return document.getElementById(id); }
 
var targetY, currentY;
 
function set(title,message,w,h,move,time) {
   var x = document.body.clientWidth - w;
   currentY = document.body.clientHeight - h;
   targetY = currentY - move;
   $('popup').style.visibility = 'visible' ;
   $('popup').style.zIndex = 120000;
   $('title').innerHTML = title;
   $('message').innerHTML =message;
   $('popup').style.left = x + 'px';
   doMove();
   window.setTimeout('HidePopUp()', time)
}
 
function doMove() {
   $('popup').style.top = currentY + 'px';
   currentY-=1;
   if (currentY > targetY) {
      window.setTimeout('doMove()', 30); // call doMove() in 30 msec
   }
}
        
function HidePopUp() {
   $('popup').style.visibility = 'hidden' ;
}
 
</script>
 
<div id="popup" style="top: 0px; left: 0px; height: 60px; width: 200px; position: absolute;
    visibility: hidden; border: black 1px solid; background-color:Fuchsia;">
    <div id="title" style="font: bold 8px verdana; padding-top: 0px; padding-left: 0px;">
        <!--<div style="padding-top: 0px; padding-left: 170px;">
            <a href="javascript:HidePopUp();">close</a>
        </div>-->
    </div>
    <div id="message" style="font: bold 12px verdana;">
    </div>
</div>
 
<input type="button" onclick="set('Hi','This is Me', 210, 70, 350, 5000);" value="set value" />

Open in new window

0
 

Author Closing Comment

by:AmrNet
ID: 31410184
You are perfect man :)
Thanks
0
 

Author Comment

by:AmrNet
ID: 20331364
please can you take a look at this question its about the same thing:

http://www.experts-exchange.com/index.jsp?qid=22976552

Thanks
0
 
LVL 29

Expert Comment

by:Göran Andersson
ID: 20331720
No, I can't. The link only takes me to the startpage of EE.
0
 

Author Comment

by:AmrNet
ID: 20331760
0

Featured Post

Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
ASCX file or a newer alternative? 1 35
Passport Expiry 3 44
Help with removing item from Session Array 3 23
Get number of Files in Directory and Sub Directories 2 41
Styling your websites can become very complex. Here I'll show how SASS can help you better organize, maintain and reuse your CSS code.
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.
The viewer will learn the basics of jQuery, including how to invoke it on a web page. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery.: (CODE)

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question