Solved

Best way to optimize recursive CTEs?  View or Stored Procedure.

Posted on 2007-11-20
11
742 Views
Last Modified: 2012-06-07
I have a number of queries occuring on an ASP page which use CTE's to return and categorize a category structure.  The categories have sub categories and so on.

Question is - doing this through regular recordsets each time the page is hit (often) is slow and making the processor bounce pretty high on the DB server. Would putting this logic into an SP or view improve the speed significantly?

Please advise.
DECLARE @hr_job_category_id INT;

SET @hr_job_category_id = 0;
 

;WITH SubCategories(hr_job_category_id, hr_job_category_name) AS ( 

  SELECT hr_job_category_id, hr_job_category_name  

  FROM hr_job_categories  

  WHERE hr_job_category_sub_of = @hr_job_category_id 

  UNION ALL  

  SELECT subs.hr_job_category_id, subs.hr_job_category_name  

  FROM hr_job_categories subs  

    JOIN SubCategories parents  

      ON subs.hr_job_category_sub_of = parents.hr_job_category_id  

)

SELECT hr_job_category_id, hr_job_category_name, (

  SELECT COUNT(*)

  FROM hr_job_category_members

  WHERE hr_job_category_members.hr_job_category_id = SubCategories.hr_job_category_id 

) AS job_count

FROM SubCategories;

Open in new window

0
Comment
Question by:ccleebelt
  • 6
  • 5
11 Comments
 
LVL 18

Expert Comment

by:Yveau
Comment Utility
My guess - note ! no rock solid proof for this ! - would be that it would make no difference whether you return this data by means of a CTE, View or Stored Procedure.
Problem is probably somewhere in the structure of the table and some investigation of the execution plans might lead to the implementation of some smart indexes that could speed up the whole thing.

So not the form, but the underlying database model might be of interest to you ...

Hope this helps ...
0
 

Author Comment

by:ccleebelt
Comment Utility
I've read conflicting opinions that putting the query in an SP compliles/saves the execution plan and can improve performance - is that not the case?
0
 
LVL 18

Expert Comment

by:Yveau
Comment Utility
Yes it will ... but that will not be noticeable by one single user hitting that page once.
But true, best way to do most database related actions in of course the stored procedure !

Don't expect any lightning changes in the performance if you go for the stored procedure ..

Hope this helps ...
0
 

Author Comment

by:ccleebelt
Comment Utility
I m looking for a performance boost on a page which calls this query 20-30 time per second.  Not a single user hitting the single page once....
0
 
LVL 18

Expert Comment

by:Yveau
Comment Utility
Than you should really go for a stored procedure !
But I still would give the indexes a better chance of giving you the boost you are looking for ...

Good index candidates are:
    hr_job_categories.hr_job_category_sub_of
    SubCategories.hr_job_category_id
    hr_job_category_members.hr_job_category_id

Hope this helps ...
0
Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

 

Author Comment

by:ccleebelt
Comment Utility
I already have a PK on SubCategories.hr_job_category_id
 
How do I add an index on hr_job_categories.hr_job_category_sub_of if it is not an identity column or linked to any sort of FK relationship.  

How do I put an index on the SubCategories.hr_job_category_id if it is a CTE?
0
 

Author Comment

by:ccleebelt
Comment Utility
Let me clarify - I have a PK on hr_job_categories.hr_job_category_id - NOT on SubCategories.hr_job_category_id

If I were to create the indexes listed above, what type of index should I use?  
0
 
LVL 18

Accepted Solution

by:
Yveau earned 500 total points
Comment Utility
:-) can't put an index on a CTE ... sorry for that.
You can put an index on any (combination of) columns you like, create index like this:

Hope this helps ...

create index ixHR_Job_Categories on dbo.hr_job_categories (hr_job_category_sub_of)

Open in new window

0
 
LVL 18

Expert Comment

by:Yveau
Comment Utility
Since these are all non-range queries, use nonclustered indexes.
You can create up to ... a lot ! (I thought 250, but it might be that they raised that for SQL 2005) non-clustered indexes on one table. Only one clustered index can be used (that is the physical order of the records)

Hope this helps ...
0
 

Author Closing Comment

by:ccleebelt
Comment Utility
Thanks!  I added an index or two and the performance did get better.
0
 
LVL 18

Expert Comment

by:Yveau
Comment Utility
Glad I could be of any help and thanks for the grade !
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
query help 18 50
Help on Setting up an identical test database 17 50
separate column 24 19
SQL Server 2016 Developers Edition Install 4 56
Let's review the features of new SQL Server 2012 (Denali CTP3). It listed as below: PERCENT_RANK(): PERCENT_RANK() function will returns the percentage value of rank of the values among its group. PERCENT_RANK() function value always in be…
Introduction In my previous article (http://www.experts-exchange.com/Microsoft/Development/MS-SQL-Server/SSIS/A_9150-Loading-XML-Using-SSIS.html) I showed you how the XML Source component can be used to load XML files into a SQL Server database, us…
Familiarize people with the process of utilizing SQL Server functions from within Microsoft Access. Microsoft Access is a very powerful client/server development tool. One of the SQL Server objects that you can interact with from within Microsoft Ac…
Viewers will learn how to use the SELECT statement in SQL and will be exposed to the many uses the SELECT statement has.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now