Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 773
  • Last Modified:

Best way to optimize recursive CTEs? View or Stored Procedure.

I have a number of queries occuring on an ASP page which use CTE's to return and categorize a category structure.  The categories have sub categories and so on.

Question is - doing this through regular recordsets each time the page is hit (often) is slow and making the processor bounce pretty high on the DB server. Would putting this logic into an SP or view improve the speed significantly?

Please advise.
DECLARE @hr_job_category_id INT;
SET @hr_job_category_id = 0;
 
;WITH SubCategories(hr_job_category_id, hr_job_category_name) AS ( 
  SELECT hr_job_category_id, hr_job_category_name  
  FROM hr_job_categories  
  WHERE hr_job_category_sub_of = @hr_job_category_id 
  UNION ALL  
  SELECT subs.hr_job_category_id, subs.hr_job_category_name  
  FROM hr_job_categories subs  
    JOIN SubCategories parents  
      ON subs.hr_job_category_sub_of = parents.hr_job_category_id  
)
SELECT hr_job_category_id, hr_job_category_name, (
  SELECT COUNT(*)
  FROM hr_job_category_members
  WHERE hr_job_category_members.hr_job_category_id = SubCategories.hr_job_category_id 
) AS job_count
FROM SubCategories;

Open in new window

0
ccleebelt
Asked:
ccleebelt
  • 6
  • 5
1 Solution
 
YveauCommented:
My guess - note ! no rock solid proof for this ! - would be that it would make no difference whether you return this data by means of a CTE, View or Stored Procedure.
Problem is probably somewhere in the structure of the table and some investigation of the execution plans might lead to the implementation of some smart indexes that could speed up the whole thing.

So not the form, but the underlying database model might be of interest to you ...

Hope this helps ...
0
 
ccleebeltAuthor Commented:
I've read conflicting opinions that putting the query in an SP compliles/saves the execution plan and can improve performance - is that not the case?
0
 
YveauCommented:
Yes it will ... but that will not be noticeable by one single user hitting that page once.
But true, best way to do most database related actions in of course the stored procedure !

Don't expect any lightning changes in the performance if you go for the stored procedure ..

Hope this helps ...
0
Get free NFR key for Veeam Availability Suite 9.5

Veeam is happy to provide a free NFR license (1 year, 2 sockets) to all certified IT Pros. The license allows for the non-production use of Veeam Availability Suite v9.5 in your home lab, without any feature limitations. It works for both VMware and Hyper-V environments

 
ccleebeltAuthor Commented:
I m looking for a performance boost on a page which calls this query 20-30 time per second.  Not a single user hitting the single page once....
0
 
YveauCommented:
Than you should really go for a stored procedure !
But I still would give the indexes a better chance of giving you the boost you are looking for ...

Good index candidates are:
    hr_job_categories.hr_job_category_sub_of
    SubCategories.hr_job_category_id
    hr_job_category_members.hr_job_category_id

Hope this helps ...
0
 
ccleebeltAuthor Commented:
I already have a PK on SubCategories.hr_job_category_id
 
How do I add an index on hr_job_categories.hr_job_category_sub_of if it is not an identity column or linked to any sort of FK relationship.  

How do I put an index on the SubCategories.hr_job_category_id if it is a CTE?
0
 
ccleebeltAuthor Commented:
Let me clarify - I have a PK on hr_job_categories.hr_job_category_id - NOT on SubCategories.hr_job_category_id

If I were to create the indexes listed above, what type of index should I use?  
0
 
YveauCommented:
:-) can't put an index on a CTE ... sorry for that.
You can put an index on any (combination of) columns you like, create index like this:

Hope this helps ...

create index ixHR_Job_Categories on dbo.hr_job_categories (hr_job_category_sub_of)

Open in new window

0
 
YveauCommented:
Since these are all non-range queries, use nonclustered indexes.
You can create up to ... a lot ! (I thought 250, but it might be that they raised that for SQL 2005) non-clustered indexes on one table. Only one clustered index can be used (that is the physical order of the records)

Hope this helps ...
0
 
ccleebeltAuthor Commented:
Thanks!  I added an index or two and the performance did get better.
0
 
YveauCommented:
Glad I could be of any help and thanks for the grade !
0

Featured Post

Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

  • 6
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now