Should we close _RecordsetPtr ?

Hi
I am connecting with the MSSQL server and using the code attached. Whenever I get the RecordsetPtr , should I close like (pRdSet ->Close() ) within the function when done?

I am keeping the "_ConnectionPtr cn;" open globally and accessing the database using local RecordsetPtr  on multiple threads (above 100)
Could you please advice me on this?
Regards
Eugene
btSQL=(_bstr_t)sSQL;
		_RecordsetPtr pRdSet;
		//TRACE(sSQL);TRACE("\n");
		pRdSet = cn->Execute(btSQL,&bcnstr,0);

Open in new window

shiffinAsked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
Ashish PatelConnect With a Mentor Commented:
Right, that is the only way to efficiently handle this situation, as there are above 500 threads and we dont want to make one connection pool for each thread. Please go ahead, this will get the solution.
0
 
Ashish PatelCommented:
Yes after the use of recordset function is done, you should also close it.
0
 
shiffinAuthor Commented:
Hi
Is it ok if I keep the "_ConnectionPtr cn;"  open always?
After few hours, I start getting exception error when I try to create the recordset. Once the exception starts, its always.
I checked by closing recordset also. Error started coming after few hours.
What must be the issue?
Can I close the _ConnectionPtr recordset failed, and open again? Its it a solution?
The error is normally "unspcified error"
Thanks
Eugene
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
Ashish PatelCommented:
Normally, we dont keep the connection "_ConnectionPtr cn;"  open once everything is done and at the end of the page we close it. And again we open it on the top of the page. So, its like

Opening a connection at the top of the page and closing it at the bottom. This is normal procedure what everyone does. By doing this you dont keep connection pool opened. Hope this helps.

The best way what you do is create a common file where you open you connection and include this file to all pages at the TOP where ever you need, and close it at the end.
0
 
shiffinAuthor Commented:
But, opening the ConnectionPtr in all the threads will delay the process. Isn't?
Eugene
0
 
Ashish PatelCommented:
NO never this happens, Opening a connection pointer takes barely milli seconds but you save keeping a connection pool opened for always. And more you use the application you pool never dies and that can occur into error after some time.
0
 
shiffinAuthor Commented:
So,
Do you advice me to open libe below on every thread I open? Even if its more than 500 ?

hr=cn.CreateInstance(__uuidof(Connection));

Eugene
0
 
Ashish PatelCommented:
Looking at your case, i will suggest you to close and again open the connection when recordset failed untill then keep it opened for all. this will work good.
0
 
shiffinAuthor Commented:
Great!! This is what I thought of doing. I will check for the record set failure and when it fails, I will close the connection pointer and open it again.
Thanks
Eugene
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.