Link to home
Start Free TrialLog in
Avatar of shiffin
shiffin

asked on

Should we close _RecordsetPtr ?

Hi
I am connecting with the MSSQL server and using the code attached. Whenever I get the RecordsetPtr , should I close like (pRdSet ->Close() ) within the function when done?

I am keeping the "_ConnectionPtr cn;" open globally and accessing the database using local RecordsetPtr  on multiple threads (above 100)
Could you please advice me on this?
Regards
Eugene
btSQL=(_bstr_t)sSQL;
		_RecordsetPtr pRdSet;
		//TRACE(sSQL);TRACE("\n");
		pRdSet = cn->Execute(btSQL,&bcnstr,0);

Open in new window

Avatar of Ashish Patel
Ashish Patel
Flag of India image

Yes after the use of recordset function is done, you should also close it.
Avatar of shiffin
shiffin

ASKER

Hi
Is it ok if I keep the "_ConnectionPtr cn;"  open always?
After few hours, I start getting exception error when I try to create the recordset. Once the exception starts, its always.
I checked by closing recordset also. Error started coming after few hours.
What must be the issue?
Can I close the _ConnectionPtr recordset failed, and open again? Its it a solution?
The error is normally "unspcified error"
Thanks
Eugene
Normally, we dont keep the connection "_ConnectionPtr cn;"  open once everything is done and at the end of the page we close it. And again we open it on the top of the page. So, its like

Opening a connection at the top of the page and closing it at the bottom. This is normal procedure what everyone does. By doing this you dont keep connection pool opened. Hope this helps.

The best way what you do is create a common file where you open you connection and include this file to all pages at the TOP where ever you need, and close it at the end.
Avatar of shiffin

ASKER

But, opening the ConnectionPtr in all the threads will delay the process. Isn't?
Eugene
NO never this happens, Opening a connection pointer takes barely milli seconds but you save keeping a connection pool opened for always. And more you use the application you pool never dies and that can occur into error after some time.
Avatar of shiffin

ASKER

So,
Do you advice me to open libe below on every thread I open? Even if its more than 500 ?

hr=cn.CreateInstance(__uuidof(Connection));

Eugene
Looking at your case, i will suggest you to close and again open the connection when recordset failed untill then keep it opened for all. this will work good.
Avatar of shiffin

ASKER

Great!! This is what I thought of doing. I will check for the record set failure and when it fails, I will close the connection pointer and open it again.
Thanks
Eugene
ASKER CERTIFIED SOLUTION
Avatar of Ashish Patel
Ashish Patel
Flag of India image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial