?
Solved

ADP - Must Declare the Scalar Varaible

Posted on 2007-11-22
6
Medium Priority
?
947 Views
Last Modified: 2013-12-05
I am having difficulty with a ADP project, specifically regarding ADO / SQL usage.

I'm currently in the process of writing a function to return a resultset from a SQL table (SQL Server 2005), the code is fairly simple (see attached example).

The problem line looks to be: "Set rs_ = .Execute"... it throws the following error: "Must Declare the Scalar Variable @id".

I have tried to use '?' marks instead, but no luck; does anyone have any ideas (short of creating a stored procedure!).

Cheers
Function Example()
On Error GoTo ErrorHandler:
 
Dim command_ As New ADODB.Command
Dim rs_ As ADODB.Recordset
 
    With command_
    
        .ActiveConnection = CurrentProject.Connection
        .NamedParameters = True
        .CommandType = adCmdText
        .CommandText = "SELECT t.* FROM ticket t WHERE t.id = @id"
        
        .Parameters.Append .CreateParameter("@id", adInteger, adParamInput, , 11)
        
        Set rs_ = .Execute
        
        With rs_
        
            If .State = adStateOpen Then
            
                ' TODO: this bit!
            
            End If
        End With
    End With
    
Tidy:
 
    Set command_ = Nothing
    Set rs_ = Nothing
    
Exit Function
ErrorHandler:
 
    Debug.Print Err.Description: GoTo Tidy
 
End Function

Open in new window

0
Comment
Question by:MISLtd
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
6 Comments
 
LVL 22

Expert Comment

by:Kelvin Sparks
ID: 20333437
Replace "SELECT t.* FROM ticket t WHERE t.id = @id"

with

"SELECT t.* FROM ticket t WHERE t.id = " & the vale for @ID.

IF @ID is text then

"SELECT t.* FROM ticket t WHERE t.id = '" & @ID & "'"
0
 
LVL 1

Author Comment

by:MISLtd
ID: 20333538
While that would work, it leaves things a fairly open to SQL injection attacks as the @id parameter will be generated by user input.
0
 
LVL 22

Expert Comment

by:Kelvin Sparks
ID: 20333549
OK, but you haven't said where @ID is coming from. What you have in the adp is a statement that will be executed. Using ADO you have to pass these parameters in from somewhere.

You are using adCmdText. This just executes the string you create
0
 
LVL 1

Author Comment

by:MISLtd
ID: 20333617
I gave the '?' mark another go and seem to have solved the problem.
Function Example()
On Error GoTo ErrorHandler:
 
Dim command_ As New ADODB.Command
Dim rs_ As ADODB.Recordset
 
    With command_
    
        .ActiveConnection = CurrentProject.Connection
        .NamedParameters = True
        .CommandType = adCmdText
        .CommandText = "SELECT t.* FROM ticket t WHERE t.id = ?"
        
        .Parameters.Append .CreateParameter("id", adInteger, adParamInput, , 11)
        
        Set rs_ = .Execute
        
        With rs_
        
            If .State = adStateOpen Then
            
                ' TODO: this bit!
            
            End If
        End With
    End With
    
Tidy:
 
    Set command_ = Nothing
    Set rs_ = Nothing
    
Exit Function
ErrorHandler:
 
    Debug.Print Err.Description: GoTo Tidy
 
End Function

Open in new window

0
 
LVL 1

Accepted Solution

by:
Computer101 earned 0 total points
ID: 21641033
PAQed with points refunded (500)

Computer101
EE Admin
0

Featured Post

 [eBook] Windows Nano Server

Download this FREE eBook and learn all you need to get started with Windows Nano Server, including deployment options, remote management
and troubleshooting tips and tricks

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

You need to know the location of the Office templates folder, so that when you create new templates, they are saved to that location, and thus are available for selection when creating new documents.  The steps to find the Templates folder path are …
Recently we ran in to an issue while running some SQL jobs where we were trying to process the cubes.  We got an error saying failure stating 'NT SERVICE\SQLSERVERAGENT does not have access to Analysis Services. So this is a way to automate that wit…
In Microsoft Access, when working with VBA, learn some techniques for writing readable and easily maintained code.
Visualize your data even better in Access queries. Given a date and a value, this lesson shows how to compare that value with the previous value, calculate the difference, and display a circle if the value is the same, an up triangle if it increased…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question