Solved

ADP - Must Declare the Scalar Varaible

Posted on 2007-11-22
6
938 Views
Last Modified: 2013-12-05
I am having difficulty with a ADP project, specifically regarding ADO / SQL usage.

I'm currently in the process of writing a function to return a resultset from a SQL table (SQL Server 2005), the code is fairly simple (see attached example).

The problem line looks to be: "Set rs_ = .Execute"... it throws the following error: "Must Declare the Scalar Variable @id".

I have tried to use '?' marks instead, but no luck; does anyone have any ideas (short of creating a stored procedure!).

Cheers
Function Example()

On Error GoTo ErrorHandler:
 

Dim command_ As New ADODB.Command

Dim rs_ As ADODB.Recordset
 

    With command_

    

        .ActiveConnection = CurrentProject.Connection

        .NamedParameters = True

        .CommandType = adCmdText

        .CommandText = "SELECT t.* FROM ticket t WHERE t.id = @id"

        

        .Parameters.Append .CreateParameter("@id", adInteger, adParamInput, , 11)

        

        Set rs_ = .Execute

        

        With rs_

        

            If .State = adStateOpen Then

            

                ' TODO: this bit!

            

            End If

        End With

    End With

    

Tidy:
 

    Set command_ = Nothing

    Set rs_ = Nothing

    

Exit Function

ErrorHandler:
 

    Debug.Print Err.Description: GoTo Tidy
 

End Function

Open in new window

0
Comment
Question by:MISLtd
  • 2
  • 2
6 Comments
 
LVL 22

Expert Comment

by:Kelvin Sparks
Comment Utility
Replace "SELECT t.* FROM ticket t WHERE t.id = @id"

with

"SELECT t.* FROM ticket t WHERE t.id = " & the vale for @ID.

IF @ID is text then

"SELECT t.* FROM ticket t WHERE t.id = '" & @ID & "'"
0
 
LVL 1

Author Comment

by:MISLtd
Comment Utility
While that would work, it leaves things a fairly open to SQL injection attacks as the @id parameter will be generated by user input.
0
 
LVL 22

Expert Comment

by:Kelvin Sparks
Comment Utility
OK, but you haven't said where @ID is coming from. What you have in the adp is a statement that will be executed. Using ADO you have to pass these parameters in from somewhere.

You are using adCmdText. This just executes the string you create
0
 
LVL 1

Author Comment

by:MISLtd
Comment Utility
I gave the '?' mark another go and seem to have solved the problem.
Function Example()

On Error GoTo ErrorHandler:
 

Dim command_ As New ADODB.Command

Dim rs_ As ADODB.Recordset
 

    With command_

    

        .ActiveConnection = CurrentProject.Connection

        .NamedParameters = True

        .CommandType = adCmdText

        .CommandText = "SELECT t.* FROM ticket t WHERE t.id = ?"

        

        .Parameters.Append .CreateParameter("id", adInteger, adParamInput, , 11)

        

        Set rs_ = .Execute

        

        With rs_

        

            If .State = adStateOpen Then

            

                ' TODO: this bit!

            

            End If

        End With

    End With

    

Tidy:
 

    Set command_ = Nothing

    Set rs_ = Nothing

    

Exit Function

ErrorHandler:
 

    Debug.Print Err.Description: GoTo Tidy
 

End Function

Open in new window

0
 
LVL 1

Accepted Solution

by:
Computer101 earned 0 total points
Comment Utility
PAQed with points refunded (500)

Computer101
EE Admin
0

Featured Post

Threat Intelligence Starter Resources

Integrating threat intelligence can be challenging, and not all companies are ready. These resources can help you build awareness and prepare for defense.

Join & Write a Comment

Introduction SQL Server Integration Services can read XML files, that’s known by every BI developer.  (If you didn’t, don’t worry, I’m aiming this article at newcomers as well.) But how far can you go?  When does the XML Source component become …
For both online and offline retail, the cross-channel business is the most recent pattern in the B2C trade space.
Viewers will learn how to use the SELECT statement in SQL to return specific rows and columns, with various degrees of sorting and limits in place.
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

6 Experts available now in Live!

Get 1:1 Help Now