Solved

Can i make this stored procedure more efficent?

Posted on 2007-11-25
8
141 Views
Last Modified: 2012-06-22
I've got a sp i.e. below - which i'm looking to run anything from 0 to 1million times per hour, as such i'm wondering if theres any way i can make this more efficent?

E.g. Merge Call 2 and 3 maybe?
Create PROCEDURE [dbo].StoredProcedureA
 

	@CompanyId int,

	@UsersId int,

	@SentCount int out
 

AS

	 SET NOCOUNT ON

begin
 

------------------

-- CALL 1

------------------

Update Users 

set STATUSID=3 

WHERE UsersId = @UsersId
 

------------------

-- CALL 2

------------------

UPDATE [Company]

	SET 

		countA = countA+1

		,countB = countB+1

	WHERE CompanyId =@CompanyId
 

------------------

-- CALL 3

------------------

select top 1 @SentCount=countA 

from [Company] 

WHERE CompanyId =@CompanyId
 

end

Open in new window

0
Comment
Question by:paulCardiff
8 Comments
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 20346157
i am not sure what exactly u mean by call 1 ,2 and 3
In case you need to perform all the 3 operations with each call, then you need to encapsulate this inside a transaction. Now, in case only one expression need to be executed with a call, then better u modify this as 3 separate sps.
also make sire that you have indexes on the columns which is there in the where clause
0
 

Author Comment

by:paulCardiff
ID: 20346183
Thanks for that
What would be the best way to put this in a single transaction ?
0
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 20346196

BEGIN TRAN 
 

Update Users 

set STATUSID=3 

WHERE UsersId = @UsersId
 

IF @@ERROR<>0 

BEGIN 

	ROLLBACK TRAN

	SELECT -201 AS RetVal

	RETURN

END 

------------------

-- CALL 2

------------------

UPDATE [Company]

        SET 

                countA = countA+1

                ,countB = countB+1

        WHERE CompanyId =@CompanyId
 

IF @@ERROR<>0 

BEGIN 

	ROLLBACK TRAN

	SELECT -202 AS RetVal

	RETURN

END  

------------------

-- CALL 3

------------------

select top 1 @SentCount=countA 

from [Company] 

WHERE CompanyId =@CompanyId

IF @@ERROR<>0 

BEGIN 

	ROLLBACK TRAN

	SELECT -203 AS RetVal

	RETURN

END 

 

Open in new window

0
 

Author Comment

by:paulCardiff
ID: 20346218
do i need to say comit at the end?
0
Complete Microsoft Windows PC® & Mac Backup

Backup and recovery solutions to protect all your PCs & Mac– on-premises or in remote locations. Acronis backs up entire PC or Mac with patented reliable disk imaging technology and you will be able to restore workstations to a new, dissimilar hardware in minutes.

 

Author Comment

by:paulCardiff
ID: 20346223
sorry also what does " SELECT -202 AS RetVal" do?
0
 
LVL 75

Accepted Solution

by:
Aneesh Retnakaran earned 500 total points
ID: 20346257
Yup , you need a COMMIT TRANS statement at the end ...
In case of an error , the sp throws an error value of -201/-202/-203 ; and based on this return value you can set an appropriate error message

BEGIN TRAN

Update Users
set STATUSID=3
WHERE UsersId = @UsersId

IF @@ERROR<>0
BEGIN
      ROLLBACK TRAN
      SELECT -201 AS RetVal
      RETURN
END
------------------
-- CALL 2
------------------
UPDATE [Company]
        SET
                countA = countA+1
                ,countB = countB+1
        WHERE CompanyId =@CompanyId

IF @@ERROR<>0
BEGIN
      ROLLBACK TRAN
      SELECT -202 AS RetVal
      RETURN
END  
------------------
-- CALL 3
------------------
select top 1 @SentCount=countA
from [Company]
WHERE CompanyId =@CompanyId
IF @@ERROR<>0
BEGIN
      ROLLBACK TRAN
      SELECT -203 AS RetVal
      RETURN
END
 
CoMMIT TRAN
SELECT 1 AS RetVal --retval 1 means the operations were successfull

END
0
 
LVL 6

Expert Comment

by:PaultheBroker
ID: 20347268
Check out this cool OUTPUT feature of MSSQL2005: it would prevent you having to rescan the whole of the company statement in CALL 3, so might be marginally more efficient if you are really worried about the processing time.....
http://msdn2.microsoft.com/en-us/library/ms177564.aspx

I think it would work something like this in your case
DECLARE @company table (countA int)
....(update statement here)
OUTPUT  inserted.countA INTO @company
SELECT @SentCount=FIRST(countA) FROM @company

The inserted table contains the value of whatever you've just inserted, so in this case it will be 'countA + 1'....
0
 
LVL 12

Expert Comment

by:kselvia
ID: 20348225
This is probably even faster;

Update Users
set STATUSID=3
WHERE UsersId = @UsersId
AND STATUSID <> 3   -- <-- Prevent updating if the value is already set

-- Get the value of @SentCount when we update the Company table
UPDATE [Company]
      SET
      @SentCount = countA = countA+1   -- <-- Here
            ,countB = countB+1
      WHERE CompanyId =@CompanyId
 

And TOP 1 really had no meaning here;

select top 1 @SentCount=countA
from [Company]
WHERE CompanyId =@CompanyId


I know what you are going to say;  "It means the FIRST matching row", but if there is more than one row, what is the FIRST without an ORDER BY?  I suspect there is only 1 matching row since CompanyID looks like the primary key of [Company].

Also for what it's worth in the UPDATE with OUTPUT, OUTPUT goes before the WHERE clause.  Since the accepted solution returns RetVal, he is now prepared to read the resultset of the proc.  In that case, eliminate the OUTPUT to a table variabale and just output CountA as the resultset (which is the default for OUTPUT anyway)  Still, the method I posted above is even better.

Experts - here is the challenge; How can he write both update statements in one batch to eliminate the need for BEGIN/END TRANSACTION?  I'm not sure it's possible.  Now that the SELECT from company is  elimianted, I'm not sure he needs the transaction anyway.
0

Featured Post

Control application downtime with dependency maps

Visualize the interdependencies between application components better with Applications Manager's automated application discovery and dependency mapping feature. Resolve performance issues faster by quickly isolating problematic components.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
MS SQL Backup 24 70
MS-SQL 2008 Standard - define the security for internal data 4 45
Square brackets 4 0
Stored Procedure 2 0
Load balancing is the method of dividing the total amount of work performed by one computer between two or more computers. Its aim is to get more work done in the same amount of time, ensuring that all the users get served faster.
The Delta outage: 650 cancelled flights, more than 1200 delayed flights, thousands of frustrated customers, tens of millions of dollars in damages – plus untold reputational damage to one of the world’s most trusted airlines. All due to a catastroph…
This videos aims to give the viewer a basic demonstration of how a user can query current session information by using the SYS_CONTEXT function
Viewers will learn how to use the UPDATE and DELETE statements to change or remove existing data from their tables. Make a table: Update a specific column given a specific row using the UPDATE statement: Remove a set of values using the DELETE s…

746 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now